Menu

#219 Added instruction page to settings dialog

v3.x
closed-rejected
nobody
settings (1)
enhancement
2020-03-06
2020-03-05
No

Created a preliminary instruction page for the VICE settings dialog. Right now it looks quite bland. If anyone can help with making it look better, don't hesitate to add your own enhancements.

1 Attachments

Discussion

  • compyx

    compyx - 2020-03-06

    First off, this is not a patch. The easiest way to create a patch is creating a diff while being in the vice dir:

    svn diff > my-patch.diff
    

    That'll create a diff which makes it a little more understandable for us. It'll show the differences between what you did and trunk.

    Your patch will only work for C64-based emulators, not for VIC-20, PET, CBM-II, Plus4, etcetera, since you mention VICII and SID. It also doesn't really add any useful information, I think most users can figure out the 'video' or 'sound' main tree nodes.

    Your patch also doesn't adhere to our code style: you use tabs while we require spaces for indentation, 4 spaces per level. This is a detail that can be fixed.

    Finally, using a GtkLabel isn't the way to go about presenting formatted text, something like a GtkTextView allows for proper formatting, see for example https://sourceforge.net/p/vice-emu/code/HEAD/tree/trunk/vice/src/arch/gtk3/widgets/hvscstilwidget.c

    So, I'll reject this patch. The idea is okay, the execution not so much.

     
  • compyx

    compyx - 2020-03-06
    • status: open --> closed-rejected
     

Log in to post a comment.