Menu

#202 Fix make-bindist_win32.sh arguments for win32/win64 SDL bindistzip target

v3.x
closed-fixed
nobody
None
bugfix
2019-10-17
2019-09-23
No

Fix make-bindist_win32.sh arguments for win32/win64 SDL bindistzip target

The number of arguments for win32/win64 SDL bindistzip target is wrong - make them identical to arguments used in win32/win64 SDL bindist target

Diff/patch attached

BTW: the win32/win64 targets for GTK bindist and bindistgip looks wrong - but my cross compile setup only builds win32/win64 SDL - I'll look at GTK later and send patch if needed.

1 Attachments

Discussion

  • Uffe Jakobsen

    Uffe Jakobsen - 2019-10-15

    Any news on accepting/applying this patch ?

    It is a simple oneliner change that fixes the number of arguments to a script :-)

     
  • compyx

    compyx - 2019-10-17

    Oneliners can be very difficult ;)

    I'll have look, I suspect this could fix the issue where make bindist create a file "SDLVICE-bla" in stead of "SDL2VICE-bla".

    Applied the patch and it does fix the SDL2 thing and also properly copies the vice.pdf when working out-of-tree.

    Thanks for the patch, and sorry for the delay, I tend to stay away from Windows and SDL.

     
    • Uffe Jakobsen

      Uffe Jakobsen - 2019-10-17

      Hahaha :-D thanks a lot for your time :-)

      Yes that is right - the patch fixes various problems around bindist - I think that you've mentioned the two most important ones :-)

      /Uffe :-)

       
  • compyx

    compyx - 2019-10-17
    • status: open --> closed-fixed
     
  • compyx

    compyx - 2019-10-17

    Alright, will mark this 'fixed'.

     

Log in to post a comment.