#2199 Status bar update failure when a snapshot is loaded after a CPU jam

[rice123]

Steps:

1. Snapshot -> Quicksave snapshot
2. Alt+H to open the monitor
3. Execute:

>1000 02
g 1000

1. Select "Continue" from the "D'OH!" prompt
2. Snapshot -> Quickload snapshot

Result:
1. The cpu and fps indicators on the status bar are not updated anymore even though the emulator is running normally
2. When Alt+W or Alt+P is pressed, the warp and pause indicators are not updated
3. "Main CPU: JAM at $1000" is displayed continuously

[gpz]

Does it also happen in SDL?

[rice123]

Unless I'm missing some setting to toggle, there's no status bar in SDL.

[gpz]

It's in the Mainmenu :)

[rice123]

it's also affected, "Main CPU: JAM at $1000" persists after quickloading snapshot and the status bar recovers only after resetting machine CPU/power cycling

[gpz]

Darn. Thanks for trying - the problem must be somewhere in the snapshot-loading code then (i hoped for a GUI glitch)

[rice123]

gtk3 and sdl query machine_is_jammed() which is dependent on the state of the static is_jammed boolean which is set to false only in machine_trigger_reset_internal() and machine_reset().

The problem probably comes from the snapshot-loading code not handling is_jammed in any way.

[gpz]

...Which is kindof strange - the emulator (CPU) shouldn't run in that case either....

will have a look

[rice123]

machine_is_jammed() is checked only in a handful of places - outside the ui code only in monitor_cpuhistory_store(), so chis won't work after loading a snapshot but the CPU can apparently still run when machine_is_jammed() is true.

[gpz]

Yeah, the CPU module has a seperate is_jammed flag - which is handled (which is why loading the snapshot works)

[gpz]

Darn. Saving the state of is_jammed into the snapshot makes it work - except now the entire UI crashes =)
Edit: same when resetting before loading the snapshot, or using the main CPUs jam state (which already is/was in the snapshot)

[gpz]

Bleh. I am giving up on this.

The problem is (yet again) this "lets do random stuff in vsync sometime later"

[rice123]

can you please post your wip patch so that anyone interested can follow up on it without starting from scratch?

[gpz]

Already reverted the local changes, sorry