That looks really odd. I can't reproduce this on my Debian box, what OS/WM are you using? Also, if possible the Gtk, GLib and Pango versions.
I suspect this is an upstream bug, we have a similar issue on Linux with little white lines appearing on top of inverted spaces (doesn't happen on Windows). All our code does is translate petscii to utf-8 and set a string via the Gtk API, and I've checked and double-checked that code. So this is probably due to some bug in Pango.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
not linux.. but windows GTK version... and I compile it with github in the same way you do.
anyway I checked and it happens also with your builds on github (as I thought)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
not linux.. but windows GTK version... and I compile it with github in the same way you do.
anyway I checked and it happens also with your builds on github (as I thought)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've checked this with my Win7 VM with msys2, which I haven't updated in a few weeks. My build doesn't have the issue, but the Github build does. The only difference is Pango being 1.48.5-1 in my msys2 install and the Github buildbot's Pango being 1.48.6-2, Gtk, GLib, Cairo are all the same version.
So this is an upstream bug. I couldn't find any bug report about this on Gnome's bugtracker though.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Pango 1.48.6 is the offending version, it gets installed as a dependency of gtk3.
Downgrading a package is usually not a good idea, it'll (usually) trigger downgrading other packages or breaking them altogether. And having a fixed version for a certain package might lead to people forgetting why we do it, and missing out on any new version with the bug fixed.
Gtk3: Add Cairo and Pango runtime versions to About dialog
The Gtk and GLib versions displayed are compile time, so perhaps the dialog should be expanded to show both compile- and runtime versions for Gtk, GLib, Pango and Cairo.
both in x64.exe and x64sc.exe (probably also others)
That looks really odd. I can't reproduce this on my Debian box, what OS/WM are you using? Also, if possible the Gtk, GLib and Pango versions.
I suspect this is an upstream bug, we have a similar issue on Linux with little white lines appearing on top of inverted spaces (doesn't happen on Windows). All our code does is translate petscii to utf-8 and set a string via the Gtk API, and I've checked and double-checked that code. So this is probably due to some bug in Pango.
not linux.. but windows GTK version... and I compile it with github in the same way you do.
anyway I checked and it happens also with your builds on github (as I thought)
can you confirm you are using one of our builds, not one you have made yourself?
not linux.. but windows GTK version... and I compile it with github in the same way you do.
anyway I checked and it happens also with your builds on github (as I thought)
I've checked this with my Win7 VM with msys2, which I haven't updated in a few weeks. My build doesn't have the issue, but the Github build does. The only difference is Pango being 1.48.5-1 in my msys2 install and the Github buildbot's Pango being 1.48.6-2, Gtk, GLib, Cairo are all the same version.
So this is an upstream bug. I couldn't find any bug report about this on Gnome's bugtracker though.
but in the windows build I don't see pango there:
perhaps we can just install the other version?
http://repo.msys2.org/mingw/x86_64/mingw-w64-x86_64-pango-1.48.6-2-any.pkg.tar.zst
zstd -d mingw-w64-x86_64-pango-1.48.6-2-any.pkg.tar.zst
untar and overwrite mingw directory should work...
or perhaps is possible to specify the version in:
mingw-w64-${{ matrix.arch.arch }}-pango
??
Last edit: Zibri 2021-07-13
Pango 1.48.6 is the offending version, it gets installed as a dependency of gtk3.
Downgrading a package is usually not a good idea, it'll (usually) trigger downgrading other packages or breaking them altogether. And having a fixed version for a certain package might lead to people forgetting why we do it, and missing out on any new version with the bug fixed.
I've opened a ticket at Gnome's bug tracker: https://gitlab.gnome.org/GNOME/pango/-/issues/578, let's see what happens there.
I agree... but until a momento ago I didn't even know what pango was @:)
This bug was fixed in r40416.
r40417 | compyx | 2021-07-28 06:47:04 +0000 (Wed, 28 Jul 2021) | 5 lines
Gtk3: Add Cairo and Pango runtime versions to About dialog
The Gtk and GLib versions displayed are compile time, so perhaps the dialog should be expanded to show both compile- and runtime versions for Gtk, GLib, Pango and Cairo.
r40416 | dqh | 2021-07-28 06:40:07 +0000 (Wed, 28 Jul 2021) | 2 lines
Fixed font rendering issues on Windows MSYS2 builds by using older Pango 1.45 MSYS2 package dlls. DLLs are downloaded and cached in data/pango-1.45.
closing, upstream bug (pango)
The upstream bug is fixed! Pango 1.48.8 doesn't show those verticle lines.
Yup: https://sourceforge.net/p/vice-emu/code/40518/ :)