#1309 Missing and/or corrupted icons; x128 msys2 gtk3 builds give Pango warning couldn't load font "EurostileLTStd-BoldEx2 Not-Rotated 175"...

[Strobe]

In /data/common/ there are various issues with the new icons:

• 128_1024.svg - the text is very small and in a different font to all the other icons, which is causing a warning when launching x128 from msys2 command line:

(x128.exe:1768): Pango-WARNING : 22:55:21.350: couldn't load font "EurostileLTStd-BoldEx2 Not-Rotated 175", falling back to "Sans Not-Rotated 175", expect ugly output.

It also makes the icons look really crap in use ("C128" text is miniscule and illegible)
Grep finds that font only in:
data/common/C128_1024.svg: .st17{font-family:'EurostileLTStd-BoldEx2';

Other issues:

• c128_24.png is missing
• the 128 pixel wide png versions are missing for most icons e.g. C64_128.png, CBM2_128.png etc missing
• some of the very small icons will need some manual pixelling to make them legible, compyx has started on that (?)

[Strobe]

On windows the x128 icon is a different size to the others, but it's like that at every different icon view size in windows explorer, see attachment. So even though there are some missing sizes for the 128 icon, I don't think that's the only issue.
I suspect there is some DPI setting difference between the SVG used to generate the x128 icon vs the others?

[Strobe]

This was mostly fixed in r39272
Looking at windows icon specs, 128x128 is not required.
Todos:

1. 64x64 (which we don't have) is required for classic mode.
2. The small sizes still need some manual pixeling to be legible.

[compyx]

Mostly fixed indeed. And enough for the 3.5 release in my opinion. I'd rather not implement any changes to our build system if not required and I also don't have time to do some pixeling/converting on the existing icons to make 'em look a little better or provide additional sizes. Neither does Sander, who provided the icons.

So we'll keep this open for now, it already looks a lot better than it did.

[compyx]

I'll remove the 128 pixel icons. I still have the original Adobe Illustrator files, so I'll see about adding 64x64 icons, but what is classic mode?

[compyx]

I've added 64x64 pixel icons, scaled down from 256x256, and removed the single 128x128 pixel icon. I'll see about trying to improve the small icons by hand, but that'll be very low priority, there's a lot of other stuff to do.