[Vesta-devel] [ vesta-Bugs-773291 ] Insufficient error checking in TextVC::TextC::TextC

[SourceForge.net <no...@so...>]

Bugs item #773291, was opened at 2003-07-17 17:44
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=410427&aid=773291&group_id=34164

Category: Evaluator
Group: None
Status: Open
Resolution: None
Priority: 6
Submitted By: Kenneth C. Schalk (xorian)
Assigned to: Kenneth C. Schalk (xorian)
Summary: Insufficient error checking in TextVC::TextC::TextC

Initial Comment:
TextVC::TextC::TextC is responsible for storing text
values to backing shortids in certain cases, such as
combining a text string with a file using the +
operator.  Although it checks for errors in opening a
newly created shortid for writing, it doesn't check for
errors on the write or close operations.

I've just debugged a case where shortids referenced
from a cache entry created through this code had 0
length when they should have had some contents.  This
caused downstream tool invocations to fail.  The site
had /vesta-srv as a soft NFS mount, so this may have
been caused by silently ignored write errors.

It shouldn't be hard to add appropriate error checking
in this function.  Probably the simplest way is to use
the FS::Write and FS::Close functions in basics/os. 
However it's probably worth checking for other cases
where more error checking may be needed (e.g. in
writing the shortids for a tool's standard output/error).


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=410427&aid=773291&group_id=34164