Re: [veryquickwiki-develop] virtual wiki bug and patch...

[Marcello T. <mar...@gm...>]

Hi Steve,

Il giorno 30/gen/09, alle ore 12:26, Steve Pugh ha scritto:

>
> Hello VQWiki people,
>
> I have found a bug in the latest release (2.8) which affects virtual  
> wikis. To reproduce:
> 1. Create a virtual wiki
> 2. And pages to the virtual wiki which link to each other. e.g.  
> FirstPage, SecondPage.
> 3. Notice that the links are not recognized as being existing pages,  
> and when you click on them, it takes you to the edit screen.
>
> I believe this is the same problem as described by http://sourceforge.net/mailarchive/forum.php?thread_name=57122.1230917322%40debooy.eu&forum_name=veryquickwiki-users
>
> It is also similar to VQW-209 except that it affects filesystem- 
> based wikis as well. Unfortunately your issue tracking site is  
> currently down so I can't check for more info. The change done in  
> SVN rev1053 also doesn't fix this problem.
>
> Anyway, I decided to try to fix this myself and have a patch for  
> you, which is attached.
>
> The basic problem is as follows:
>
> DefaultWikiParser is creating a LinkLex object, and calls the setter  
> "setVirtualWiki". However this LinkLex object also creates a  
> "LinkLexConvert" object, and crucially, the virtualWiki value is not  
> passed on to this object.
>
> So later, when the "exist" test done to see if topic name exists in  
> the virtual wiki, the virtualWiki value is null and so the wrong  
> test is performed.
>
> Note my patch only applies to the DefaultWikiParser parseLinks()  
> method. You probably want something similar for the  
> parseExportLinks() method as well.
>
> Also it looks to me as though the "virtualWiki" in LinkLex is  
> redundant and unnecessary and instead you should only call  
> "setVirtualWiki" on the "LinkLexConvert" object instead.
>
> I hope you can fix this and release a new version fairly soon as I  
> believe this problem will affect anyone who is using the virtual  
> wiki functionality...

Thanks, I've applied your patch and related it to VQW-209 on Jira. For  
a new release there are a few other bugs to be ironed out, in the  
meanwhile please use the latest from svn.

Marcello