Menu
▾
▴
[vde-users] [ vde-Bugs-2956694 ] port/create does not display the id of the created port
|
From: SourceForge.net <no...@so...> - 2010-07-03 16:31:46
|
Bugs item #2956694, was opened at 2010-02-22 18:28 Message generated for change (Comment added) made by shammash You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=611248&aid=2956694&group_id=95403 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: vde_switch Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: Luca Bigliardi (shammash) Summary: port/create does not display the id of the created port Initial Comment: The current implementation of port/create, when called with N=0 (to use the first unallocated port ID) does not display which port was actually allocated. This is very problematic because there is no easy way to know this id thereafter (and it is even worse when there are multiple concurrent client instances accessing the management socket) Morever port/create will return '1000 Success' even if all ports are already allocated. The attached patch solves these issues. Note that because of the way the cli is designed, it was not possible to display the port id in the response line directly so I had to display it in a data section (which may break backward compatibility with existing clients). To avoid any problem here I created a new function port/createauto. ---------------------------------------------------------------------- >Comment By: Luca Bigliardi (shammash) Date: 2010-07-03 18:31 Message: Hi, sorry for the immense delay! Thank you for the patch, I've applied it with minor changes (like returning ENOSPC instead of EBUSY). You can find it in revision 425. Revision 426 fixes the "always return success" bug in 'port/create'. Thank you for your contribution, Luca ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=611248&aid=2956694&group_id=95403 |