Menu

#14 slirpvde: poor error handling

closed-fixed
None
5
2010-07-03
2008-06-11
No

Forwarding from debian BTS #460734.

As slirpvde will be rewritten with lwip6 this
should disappear.

Hello again,

I have more information for this 'bug'. Well, it's
actually not the bug I thought, since the error is due
to poor error handling. In my experimentations with the
package, the command line I used to use was wrong, hence
the Bus error. Looking at the source code it looks like
he main problems are because a lot of error checking
(even as innocent as File not found) is not done, hence
carrying around NULL pointers. In particular the problem
was after vde_open in slirpvde.c (around line 429) which
doesn't check if the open was succesfull, and after
vde_datafd (around line 443) where the return value is
not check (in this case the previous open failed).

thanks
graziano

Discussion

  • Luca Bigliardi

    Luca Bigliardi - 2010-07-03

    newer slirp improves error handling

     
  • Luca Bigliardi

    Luca Bigliardi - 2010-07-03
    • assigned_to: nobody --> rd235
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB