Re: [Vchanger-users] bacula requesting nonexistent slots

[Josh F. <jf...@ja...>]

On 8/10/23 14:05, Steven A. Falco wrote:
> On 8/10/23 11:19 AM, Josh Fisher wrote:
>> ...
>
> I've checked the log, and I had one instance of:
>
> Aug 09 09:49:09:  [12299]: WARNING! 'update slots' needed in bconsole
> Aug 09 09:49:09:  [12299]: bconsole update slots command success
>
> But after doing the manual "update slots", I don't see any more 
> warnings.  I don't know why bconsole couldn't be run that one time, 
> but I'll keep an eye on it.  Maybe I issued it as an unprivileged user 
> rather than as root.


Maybe. If it persists, then set leg_level = LOG_DEBUG, which will log 
much more detail about the bconsole calls and their return codes. It 
should help determine why the bconsole calls fail.


>
> As an aside, looking at bconsole.cpp I'm surprised that the "success" 
> message would be printed along with the WARNING line. It might be 
> clearer to have the "success" line in an else clause, like:
>
>    if (update_slots) {
>       tFormat(cmd, "update slots storage=\"%s\" drive=\"0\"", 
> conf.storage_name.c_str());
>       if(issue_bconsole_command(cmd.c_str())) {
>          vlog.Error("WARNING! 'update slots' needed in bconsole");
>       } else {
>          vlog.Info("bconsole update slots command success");
>       }
>    }
>
> The same would be true of the label_barcodes a few lines later in the 
> file.


It is supposed to be in an elf clause. That is a bug. Thanks. I'll fix it.


>
> I've also attached a trivial patch, because when reading the log I 
> noticed that there is a typo which I fixed via 
> s/preforming/performing/ in vchanger.cpp (around lines 638-672).
>
>     Thanks for the rapid response!
>     Steve


Thanks for the patch! I've never noticed. I guess my brain 
auto-corrected it.