non-portable code in libvamp
Brought to you by:
cannam
I notice that the code in
vamp-sdk/hostext/PluginLoader.cpp has
the following line:
if (!(e->d_type & DT_REG) || !e->d_name) continue;
However, on Solaris the dirent structure has no d_type
variable and DT_REG is not supported on Solaris. This
is not very portable code.
David Hollister (David.Hollister@sun.com) put together
the attached patch which fixes the code to do the same
thing using the more portable stat() function. I think
this is a better approach to retain the belt-and-braces
code, but without depending on non-portable dirent
features.
Can this patch go upstream?
patch fixing problem, making the code more portable.