From: Jeremy F. <je...@go...> - 2004-04-22 03:50:29
|
On Wed, 2004-04-21 at 17:13, Robert Walsh wrote: > BTW: this patch doesn't actually break regular Valgrind-on-x86 in any > way, so if it seems OK, I'll commit it in the next few days, after I've > heard back from people. Hm, I'm not quite sure about this. I think there's a risk that this will let Valgrind allocate a mapping in the last 64k of the address space, which would be bad. The trouble here is obviously the 4G wrap-around, and that the end address is outside the range. I guess you could put ROUNDUP(argc_addr, 0x10000)-1, but I'm not quite sure what happens if VG_(valgrind_end) isn't page-aligned. J |