|
From: Florian K. <fl...@ei...> - 2026-03-21 10:06:38
|
On 3/21/26 07:42, Paul Floyd wrote: > https://sourceware.org/cgit/valgrind/commit/?id=a34444eb433ef92ecc1a9cf95aaa41df5328a651 > > commit a34444eb433ef92ecc1a9cf95aaa41df5328a651 > Author: Paul Floyd <pj...@wa...> > Date: Sat Mar 21 07:40:29 2026 +0100 > > Remove s390_disasm.c from VEX/Makefile-gcc > > The file was removed as part of the switch to using objdump for > disasm on s390. > The objdump subtree is missing as well in the library. Before I go and fix that I'd like to have a discussion of what to do with Makefile-gcc. We don't ship Makefile-gcc in the release tarball. That is not new. It has been like that for a long time. In the early days when VEX was a repository of its own Makefile-gcc was used to build libvex.a and the test_main executable. In 721ac5231f6bda17f592ebdc8efdfeff36f4ef86 it was decided that test_main.c is for developer use only and not maintained for the general public. As test_main wants to process those .orig files which have been removed in c5218ff4c1215ceaee76bc8bafadbc23484d4be0 and there is no program to create files in that format AFAICT I propose that the following files be removed because they are obsolete now: VEX/Makefile-gcc VEX/useful/test_main.c VEX/useful/Makefile-vex What do you think about that? Florian |