Re: [Valgrind-developers] [PATCH] helgrind: add --show-events debug cmdline option

[Mark W. <ma...@kl...>]

Hi Aaron,

On Mon, 2026-03-16 at 09:03 -0400, Aaron Merey via Valgrind-developers
wrote:
> SHOW_EVENTS in hg_main.c controls whether helgrind prints a trace of its
> internal synchronization, threading and memory events.  It is set to 0
> by default to disable the trace and the only way to enable it is to
> modify the source code and rebuild valgrind.
> 
> This patch replaces SHOW_EVENTS with clo_show_events that is set using
> the new helgrind cmdline option --show-events.  Information about this
> option is included under helgrind's --help-debug.

Nice, very helpful. Having to rebuild helgrind just to get these event
traces is not for everybody, having a comment line flag is much more
discoverable. Note that it helps to (also) file a bug report so we can
track state and don't forget.

Have you thought about just adding this under --verbose?

If we keep it as helgrind specific --show-events then it is missing a
manual update in helgrind/docs/hg-manual.xml under Helgrind Command-
line Options (hg.opts.list) so that it gets documented in the manual
and valgrind man page.


The actual code changes look correct to me.

Thanks,

Mark