|
From: Paul F. <pa...@so...> - 2026-03-19 13:16:49
|
https://sourceware.org/cgit/valgrind/commit/?id=3a31875458a69ac0a3dab25c87b0725daa8b34a7 commit 3a31875458a69ac0a3dab25c87b0725daa8b34a7 Author: Paul Floyd <pj...@wa...> Date: Thu Mar 19 14:10:49 2026 +0100 Darwin: don't remove VALGRIND_LAUNCHER from vg_cleanup_env It gets put there by launcher-darwin.c but it was already removed by initimg-darwin.c by the time the preloads get loaded and this function marked constructor runs. I'll probably also look at not bothering to set DYLD_SHARED_REGION=use on macOS >= 11 since that is the default. Diff: --- coregrind/vg_preloaded.c | 1 - 1 file changed, 1 deletion(-) diff --git a/coregrind/vg_preloaded.c b/coregrind/vg_preloaded.c index baf4cc11c2..4da57aa95a 100644 --- a/coregrind/vg_preloaded.c +++ b/coregrind/vg_preloaded.c @@ -248,7 +248,6 @@ static void vg_cleanup_env(void) __attribute__((constructor)); static void vg_cleanup_env(void) { HChar **envp = (HChar**)*_NSGetEnviron(); - env_unsetenv(envp, "VALGRIND_LAUNCHER"); env_unsetenv(envp, "DYLD_SHARED_REGION"); // GrP fixme should be more like mash_colon_env() env_unsetenv(envp, "DYLD_INSERT_LIBRARIES"); |