Re: [Valgrind-developers] [valgrind] s390x: Simplify POPCNT logic in host_s390_defs.c

[Florian K. <fl...@ei...>]

On 3/10/26 19:39, Andreas Arnez wrote:
> https://sourceware.org/cgit/valgrind/commit/?id=580baf807566236edbde5c7fbc960b51b0a7cbbc
> 
> commit 580baf807566236edbde5c7fbc960b51b0a7cbbc
> Author: Andreas Arnez <ar...@li...>
> Date:   Tue Mar 10 18:20:01 2026 +0100
> 
>      s390x: Simplify POPCNT logic in host_s390_defs.c
>      
>      With the exploitation of the POPCNT instruction, the new s390_insn_tag
>      S390_INSN_POPCNT was introduced.  This requires handling the new tag in
>      s390_get_reg_usage(), s390_insn_map_regs(), and s390_insn_as_string(), as
>      well as providing the interface function s390_insn_popcnt().
>      
>      All of this can go away when using the existing S390_INSN_UNOP instead and
>      just adding a new unary operation type to s390_unop_t.  So do this.
> 

Oh yes! Nice!

   Florian