|
From: Paul F. <pa...@so...> - 2026-03-09 19:44:50
|
https://sourceware.org/cgit/valgrind/commit/?id=2900866885d96b0419145a38d5737de3baaa7773 commit 2900866885d96b0419145a38d5737de3baaa7773 Author: Paul Floyd <pj...@wa...> Date: Mon Mar 9 20:42:44 2026 +0100 Bug 413410 - unhandled amd64-darwin syscall: mach:50 (on macOS 10.15) Was missing setting AFTER. mach traps are quite different to UNIX syscall wrappers so I might have missed some more things. Diff: --- NEWS | 1 + coregrind/m_syswrap/syswrap-darwin.c | 12 ++++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 08db26971c..35c0b8a474 100644 --- a/NEWS +++ b/NEWS @@ -62,6 +62,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 406674 False positive when reading bitfield value on code compiled with clang 7.0 413369 unhandled amd64-darwin syscall: unix:151 (getpgid) +413410 unhandled amd64-darwin syscall: mach:50 (on macOS 10.15) 487055 memcheck/tests/x86-linux/scalar fails running in Docker 503238 s390x: Support miscellaneous-instruction-extensions facility 4 503239 s390x: Support vector-enhancements facility 3 diff --git a/coregrind/m_syswrap/syswrap-darwin.c b/coregrind/m_syswrap/syswrap-darwin.c index 668f2ef029..b92ca8d977 100644 --- a/coregrind/m_syswrap/syswrap-darwin.c +++ b/coregrind/m_syswrap/syswrap-darwin.c @@ -11116,16 +11116,20 @@ POST(kevent_id) } } -PRE(thread_get_special_reply_port) -{ - PRINT("thread_get_special_reply_port()"); -} POST(thread_get_special_reply_port) { record_named_port(tid, RES, MACH_PORT_RIGHT_RECEIVE, "special-reply-%p"); PRINT("special reply port %s", name_for_port(RES)); } + +PRE(thread_get_special_reply_port) +{ + PRINT("thread_get_special_reply_port()"); + AFTER = POST_FN(thread_get_special_reply_port); + +} + #endif /* DARWIN_VERS >= DARWIN_10_13 */ |