Re: [Valgrind-users] New file descriptor leak detection patch (bug fix)

[Crispin F. <cr...@th...>]

On Tue, 2003-04-22 at 08:43, Robert Walsh wrote:
> Hi all,
> 
> Here's a new version of the file descriptor leakage patch that solves a
> memory error (sigh - this is where being able to valgrind valgrind would
> be handy) in my original implementation.  Feedback welcome.
I have been using this quite a bit recently, and it works pretty well,
however I have a comment:

I have some code that calls close() on the first 512 fd's, and although
the stacktrace is only printed once, the "Attempting to close unopened
file descriptor 13" is printed every time, giving me the following
output:

==12597== Invalid close()
==12597==    at 0x402FE97D: __libc_close (in /lib/libc-2.3.1.so)
==12597==    by 0x8171767: ParentBoot() (parent.cpp:1623)
==12597==    by 0x81AB204: main (z4.cpp:613)
==12597==    by 0x4025CA50: __libc_start_main (in /lib/libc-2.3.1.so)
==12597==    Attempting to close unopened file descriptor 13
==12597==    Attempting to close unopened file descriptor 14
==12597==    Attempting to close unopened file descriptor 15
==12597==    Attempting to close unopened file descriptor 16
==12597==    Attempting to close unopened file descriptor 17
==12597==    Attempting to close unopened file descriptor 18
etc.


It would be nice to make this message only get printed once (also I
think that this may make the supressions stuff work for these stack
traces).

Crispin