|
From: Robert W. <rj...@du...> - 2003-04-22 07:41:07
Attachments:
03-fdleak.diff
|
Hi all, Here's a new version of the file descriptor leakage patch that solves a memory error (sigh - this is where being able to valgrind valgrind would be handy) in my original implementation. Feedback welcome. Regards, Robert. -- Robert Walsh Amalgamated Durables, Inc. - "We don't make the things you buy." Email: rj...@du... |
|
From: Crispin F. <cr...@th...> - 2003-05-07 17:15:09
|
On Tue, 2003-04-22 at 08:43, Robert Walsh wrote: > Hi all, > > Here's a new version of the file descriptor leakage patch that solves a > memory error (sigh - this is where being able to valgrind valgrind would > be handy) in my original implementation. Feedback welcome. I have been using this quite a bit recently, and it works pretty well, however I have a comment: I have some code that calls close() on the first 512 fd's, and although the stacktrace is only printed once, the "Attempting to close unopened file descriptor 13" is printed every time, giving me the following output: ==12597== Invalid close() ==12597== at 0x402FE97D: __libc_close (in /lib/libc-2.3.1.so) ==12597== by 0x8171767: ParentBoot() (parent.cpp:1623) ==12597== by 0x81AB204: main (z4.cpp:613) ==12597== by 0x4025CA50: __libc_start_main (in /lib/libc-2.3.1.so) ==12597== Attempting to close unopened file descriptor 13 ==12597== Attempting to close unopened file descriptor 14 ==12597== Attempting to close unopened file descriptor 15 ==12597== Attempting to close unopened file descriptor 16 ==12597== Attempting to close unopened file descriptor 17 ==12597== Attempting to close unopened file descriptor 18 etc. It would be nice to make this message only get printed once (also I think that this may make the supressions stuff work for these stack traces). Crispin |
|
From: Robert W. <rj...@du...> - 2003-05-08 05:53:14
|
> =3D=3D12597=3D=3D Attempting to close unopened file descriptor 13 > =3D=3D12597=3D=3D Attempting to close unopened file descriptor 14 > =3D=3D12597=3D=3D Attempting to close unopened file descriptor 15 > =3D=3D12597=3D=3D Attempting to close unopened file descriptor 16 > =3D=3D12597=3D=3D Attempting to close unopened file descriptor 17 > =3D=3D12597=3D=3D Attempting to close unopened file descriptor 18 > etc. >=20 >=20 > It would be nice to make this message only get printed once (also I > think that this may make the supressions stuff work for these stack > traces). I've a new version coming along any day now that has a number of improvements, including removing these messages altogether. They're an annoyance and not that useful. The new version also supports a number of bits and pieces that I missed the last time (F_DUPFD, creat, etc.) and also tries to figure out more information on sockets to make debugging easier. Regards, Robert. --=20 Robert Walsh Amalgamated Durables, Inc. - "We don't make the things you buy." Email: rj...@du... |