Re: [Valgrind-developers] AT_* in vg_main.c

[Jeremy F. <je...@go...>]

On Fri, 2004-07-30 at 10:03 +0100, Tom Hughes wrote:
> In message <200...@ac...>
>         Julian Seward <js...@ac...> wrote:
> 
> >> Why are AT_UCACHEBSIZE, AT_SYSINFO, AT_SYSINFO_EHDR, AT_ICACHEBSIZE,
> >> AT_DCACHEBSIZE, and AT_SECURE defined in vg_main.c, rather than
> >> vg_kerneliface.h?  I recall these are recent additions, but I didn't pay
> >> attention/understand at the time and now it's of interest to me :)
> >
> > Uh, I don't know, but I'm guessing they should be in vg_kerneliface.h,
> > along with all the other VKI_AT_* ?
> 
> I agree. There's a right mishmash at the moment - some things use
> the AT_ constants and some use the VKI_AT_ ones.

Me too.

The main reason is that ume.[ch] uses elf.h, which contains the glibc
definitions of some of these.  It misses out on newer ones like
AT_SYSINFO_EHDR, so there's some fill-in definitions in there.  But it
isn't pretty or the right way to do it.

	J