Thread: [uml-user] [PATCH 1/2] um: add missing declaration of 'getrlimit()' and friends

Brought to you by: blaisorblade, derrichard, jdike, rusty

user-mode-linux-user

[uml-user] [PATCH 1/2] um: add missing declaration of 'getrlimit()' and friends

From: Sergei T. <sl...@ge...> - 2012-12-29 22:38:21

arch/um/os-Linux/start_up.c: In function 'check_coredump_limit':
arch/um/os-Linux/start_up.c:338:16: error: storage size of 'lim' isn't known
arch/um/os-Linux/start_up.c:339:2: error: implicit declaration of function 'getrlimit' [-Werror=implicit-function-declaration]

Signed-off-by: Sergei Trofimovich <sl...@ge...>
CC: Jeff Dike <jd...@ad...>
CC: Richard Weinberger <ri...@no...>
CC: Al Viro <vi...@ze...>
CC: use...@li...
CC: use...@li...
CC: lin...@vg...
---
 arch/um/os-Linux/start_up.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/um/os-Linux/start_up.c b/arch/um/os-Linux/start_up.c
index da4b9e9..337518c 100644
--- a/arch/um/os-Linux/start_up.c
+++ b/arch/um/os-Linux/start_up.c
@@ -15,6 +15,8 @@
 #include <sys/mman.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
+#include <sys/time.h>
+#include <sys/resource.h>
 #include <asm/unistd.h>
 #include <init.h>
 #include <os.h>
-- 
1.8.0.2

[uml-user] [PATCH 2/2] um: fix build failure due to mess-up of sig_info protorype

From: Sergei T. <sl...@ge...> - 2012-12-29 22:38:21

arch/um/os-Linux/signal.c:18:8: error: conflicting types for 'sig_info'
In file included from /home/slyfox/linux-2.6/arch/um/os-Linux/signal.c:12:0:
arch/um/include/shared/as-layout.h:64:15: note: previous declaration of 'sig_info' was here

Signed-off-by: Sergei Trofimovich <sl...@ge...>
CC: Jeff Dike <jd...@ad...>
CC: Richard Weinberger <ri...@no...>
CC: "Martin Pärtel" <mar...@gm...>
CC: Al Viro <vi...@ze...>
CC: use...@li...
CC: use...@li...
CC: lin...@vg...
---
 arch/um/os-Linux/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c
index b1469fe..9d9f1b4 100644
--- a/arch/um/os-Linux/signal.c
+++ b/arch/um/os-Linux/signal.c
@@ -15,7 +15,7 @@
 #include <sysdep/mcontext.h>
 #include "internal.h"
 
-void (*sig_info[NSIG])(int, siginfo_t *, struct uml_pt_regs *) = {
+void (*sig_info[NSIG])(int, struct siginfo *, struct uml_pt_regs *) = {
 	[SIGTRAP]	= relay_signal,
 	[SIGFPE]	= relay_signal,
 	[SIGILL]	= relay_signal,
-- 
1.8.0.2

Re: [uml-user] [PATCH 2/2] um: fix build failure due to mess-up of sig_info protorype

From: Richard W. <ri...@no...> - 2012-12-30 09:41:01

Am Sun, 30 Dec 2012 01:37:31 +0300
schrieb Sergei Trofimovich <sl...@ge...>:

> arch/um/os-Linux/signal.c:18:8: error: conflicting types for
> 'sig_info' In file included
> from /home/slyfox/linux-2.6/arch/um/os-Linux/signal.c:12:0:
> arch/um/include/shared/as-layout.h:64:15: note: previous declaration
> of 'sig_info' was here
> 
> Signed-off-by: Sergei Trofimovich <sl...@ge...>
> CC: Jeff Dike <jd...@ad...>
> CC: Richard Weinberger <ri...@no...>
> CC: "Martin Pärtel" <mar...@gm...>
> CC: Al Viro <vi...@ze...>
> CC: use...@li...
> CC: use...@li...
> CC: lin...@vg...
> ---

I think both patches need to be backported to -stable.
I'll add the tag and push the patches ASAP to Linus.

Thanks,
//richard

Re: [uml-user] [PATCH 2/2] um: fix build failure due to mess-up of sig_info protorype

From: Sergei T. <sl...@ge...> - 2013-01-11 21:55:53

Attachments: signature.asc

On Sun, 30 Dec 2012 10:40:43 +0100
Richard Weinberger <ri...@no...> wrote:

> Am Sun, 30 Dec 2012 01:37:31 +0300
> schrieb Sergei Trofimovich <sl...@ge...>:
> 
> > arch/um/os-Linux/signal.c:18:8: error: conflicting types for
> > 'sig_info' In file included
> > from /home/slyfox/linux-2.6/arch/um/os-Linux/signal.c:12:0:
> > arch/um/include/shared/as-layout.h:64:15: note: previous declaration
> > of 'sig_info' was here
> > 
> > Signed-off-by: Sergei Trofimovich <sl...@ge...>
> > CC: Jeff Dike <jd...@ad...>
> > CC: Richard Weinberger <ri...@no...>
> > CC: "Martin Pärtel" <mar...@gm...>
> > CC: Al Viro <vi...@ze...>
> > CC: use...@li...
> > CC: use...@li...
> > CC: lin...@vg...
> > ---
> 
> I think both patches need to be backported to -stable.
> I'll add the tag and push the patches ASAP to Linus.

Seems to have got lost.

-- 

  Sergei

Re: [uml-user] [PATCH 2/2] um: fix build failure due to mess-up of sig_info protorype

From: Richard W. <ri...@no...> - 2013-01-11 21:59:24

Am Sat, 12 Jan 2013 00:55:17 +0300
schrieb Sergei Trofimovich <sl...@ge...>:

> On Sun, 30 Dec 2012 10:40:43 +0100
> Richard Weinberger <ri...@no...> wrote:
> 
> > Am Sun, 30 Dec 2012 01:37:31 +0300
> > schrieb Sergei Trofimovich <sl...@ge...>:
> > 
> > > arch/um/os-Linux/signal.c:18:8: error: conflicting types for
> > > 'sig_info' In file included
> > > from /home/slyfox/linux-2.6/arch/um/os-Linux/signal.c:12:0:
> > > arch/um/include/shared/as-layout.h:64:15: note: previous
> > > declaration of 'sig_info' was here
> > > 
> > > Signed-off-by: Sergei Trofimovich <sl...@ge...>
> > > CC: Jeff Dike <jd...@ad...>
> > > CC: Richard Weinberger <ri...@no...>
> > > CC: "Martin Pärtel" <mar...@gm...>
> > > CC: Al Viro <vi...@ze...>
> > > CC: use...@li...
> > > CC: use...@li...
> > > CC: lin...@vg...
> > > ---
> > 
> > I think both patches need to be backported to -stable.
> > I'll add the tag and push the patches ASAP to Linus.
> 
> Seems to have got lost.

Yeah. Sorry for that. I'm currently very busy.
This weekend I'll have some time to prepare all my patches.

Thanks,
//richard