user-mode-linux-user

[uml-user] apache2 won't start with v3.6-rc5 (kernel v3.5 works fine)

[Toralf F. <tor...@gm...>]

Hi,

with current git tree 3.6-rc5 I cannot longer start apache2 at a
UML image with an unstable Gentoo Linux.

The apache error log gives :

[Sun Sep 09 11:53:25.225818 2012] [core:emerg] [pid 1054:tid 1078662848]
(22)Invalid argument: AH00023: Couldn't create the rewrite-map mutex
AH00016: Configuration Failed

I did not found anything else in the logs.

Known issue ?


-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Re: [uml-user] SMP on UML

[richard -r. w. <ric...@gm...>]

On Fri, Aug 24, 2012 at 6:19 PM, Dragos Diaconescu
<dia...@gm...> wrote:
> Hello,
>
> I try to compile the UML, from a linux kernel(make ARCH=um SUBARCH=i386)
> and I have configured it to use SMP (make config). I am getting the
> following error:
>
>   CHK     include/generated/utsrelease.h
>   CC      arch/um/kernel/asm-offsets.s
> In file included from include/linux/sched.h:77:0,
>                  from
> /home/dragos/work/linux-3.5.2/arch/x86/um/shared/sysdep/kernel-offsets.h:2,
>                  from arch/um/kernel/asm-offsets.c:1:
> include/linux/topology.h: In function ‘numa_node_id’:
> include/linux/topology.h:217:9: error: ‘current_thread’ undeclared (first
> use in this function)
> include/linux/topology.h:217:9: note: each undeclared identifier is reported
> only once for each function it appears in
> include/linux/topology.h:217:9: warning: left-hand operand of comma
> expression has no effect [-Wunused-value]
> make[1]: *** [arch/um/kernel/asm-offsets.s] Error 1
>
> Do you have any ideas?

config SMP
        bool "Symmetric multi-processing support (EXPERIMENTAL)"
        default n
        depends on BROKEN
        help
          This option enables UML SMP support.

/me really wonders why you have CONFIG_BROKEN=y :-)

-- 
Thanks,
//richard

Re: [uml-user] SMP on UML

[Antoine M. <an...@na...>]

On 08/24/2012 11:19 PM, Dragos Diaconescu wrote:
> Hello,
>
> I try to compile the UML, from a linux kernel(make ARCH=um SUBARCH=i386)
> and I have configured it to use SMP (make config). I am getting the
> following error:
>
>    CHK     include/generated/utsrelease.h
>    CC      arch/um/kernel/asm-offsets.s
> In file included from include/linux/sched.h:77:0,
>                   from
> /home/dragos/work/linux-3.5.2/arch/x86/um/shared/sysdep/kernel-offsets.h:2,
>                   from arch/um/kernel/asm-offsets.c:1:
> include/linux/topology.h: In function ‘numa_node_id’:
> include/linux/topology.h:217:9: error: ‘current_thread’ undeclared
> (first use in this function)
> include/linux/topology.h:217:9: note: each undeclared identifier is
> reported only once for each function it appears in
> include/linux/topology.h:217:9: warning: left-hand operand of comma
> expression has no effect [-Wunused-value]
> make[1]: *** [arch/um/kernel/asm-offsets.s] Error 1
>
> Do you have any ideas?
http://uml.devloop.org.uk/faq.html#smp
Q: Can I use SMP? (more than one CPU)
A: No.

Cheers
Antoine


>
> Thanks,
>
> Dragos
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> User-mode-linux-user mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-user
>

[uml-user] SMP on UML

[Dragos D. <dia...@gm...>]

Hello,

I try to compile the UML, from a linux kernel(make ARCH=um SUBARCH=i386)
and I have configured it to use SMP (make config). I am getting the
following error:

  CHK     include/generated/utsrelease.h
  CC      arch/um/kernel/asm-offsets.s
In file included from include/linux/sched.h:77:0,
                 from
/home/dragos/work/linux-3.5.2/arch/x86/um/shared/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/topology.h: In function ‘numa_node_id’:
include/linux/topology.h:217:9: error: ‘current_thread’ undeclared (first
use in this function)
include/linux/topology.h:217:9: note: each undeclared identifier is
reported only once for each function it appears in
include/linux/topology.h:217:9: warning: left-hand operand of comma
expression has no effect [-Wunused-value]
make[1]: *** [arch/um/kernel/asm-offsets.s] Error 1

Do you have any ideas?

Thanks,

Dragos

Re: [uml-user] TSC register

[richard -r. w. <ric...@gm...>]

On Fri, Aug 24, 2012 at 5:09 PM, Dragos Diaconescu
<dia...@gm...> wrote:
> Can you please
>   give me some directions? Shall I implement in the same manner as is
> implemented in
>   /arch/x86/lib/delay.c . What are the big differences between this
> implementation and in an implementation
>   for UML?

If you are lucky you can copy&paste it. :-)

-- 
Thanks,
//richard

Re: [uml-user] TSC register

[Dragos D. <dia...@gm...>]

On Thu, Aug 23, 2012 at 6:52 PM, richard -rw- weinberger <
ric...@gm...> wrote:

> On Wed, Aug 22, 2012 at 6:34 PM, Dragos Diaconescu
> <dia...@gm...> wrote:
> >    at an interval of some nanoseconds and to use the ndelay function. I
> saw
> > that in the kernel implementation
> >    for the uml there is no "delay_tsc"
> >    function and there is only the "delay_loop" function. I am wondering
> why
> > the delay_tsc is not implemented. Is it not
> >    possible to read the TSC register?
> >    I would need this for having a nanosecond precision.
>
> You can access TSC from user space, so also UML can read it.
> There is no delay_tsc() in UML because nobody cared so far.
> Feel free to implement it and send me a patch. :-)
>
>    I will try to implement a delay_tsc for UML andI will send you a patch.
Can you please
  give me some directions? Shall I implement in the same manner as is
implemented in
  /arch/x86/lib/delay.c . What are the big differences between this
implementation and in an implementation
  for UML?

 --
> Thanks,
> //richard
>

  Many thanks,

  Dragos

Re: [uml-user] TSC register

[richard -r. w. <ric...@gm...>]

On Wed, Aug 22, 2012 at 6:34 PM, Dragos Diaconescu
<dia...@gm...> wrote:
>    at an interval of some nanoseconds and to use the ndelay function. I saw
> that in the kernel implementation
>    for the uml there is no "delay_tsc"
>    function and there is only the "delay_loop" function. I am wondering why
> the delay_tsc is not implemented. Is it not
>    possible to read the TSC register?
>    I would need this for having a nanosecond precision.

You can access TSC from user space, so also UML can read it.
There is no delay_tsc() in UML because nobody cared so far.
Feel free to implement it and send me a patch. :-)

-- 
Thanks,
//richard

Re: [uml-user] TSC register

[Dragos D. <dia...@gm...>]

On Wed, Aug 22, 2012 at 5:39 PM, richard -rw- weinberger <
ric...@gm...> wrote:

> On Wed, Aug 22, 2012 at 3:23 PM, Dragos Diaconescu
> <dia...@gm...> wrote:
> > On an ubuntu kernel I used a busy waiting, with  ndelay function which
> uses
> > the TSC register, but
> > I have noticed that this register cannot be read from an UML.
>
> Please provide a test case.
>  I don't have yet a test case. What I want to do is to make a busy
> waiting, and interrupt this busy waiting
>
   at an interval of some nanoseconds and to use the ndelay function. I saw
that in the kernel implementation
   for the uml there is no "delay_tsc"
   function and there is only the "delay_loop" function. I am wondering why
the delay_tsc is not implemented. Is it not
   possible to read the TSC register?
   I would need this for having a nanosecond precision.

--
> Thanks,
> //richard
>

   Best wishes,

   Dragos

Re: [uml-user] TSC register

[richard -r. w. <ric...@gm...>]

On Wed, Aug 22, 2012 at 3:23 PM, Dragos Diaconescu
<dia...@gm...> wrote:
> On an ubuntu kernel I used a busy waiting, with  ndelay function which uses
> the TSC register, but
> I have noticed that this register cannot be read from an UML.

Please provide a test case.

-- 
Thanks,
//richard

[uml-user] TSC register

[Dragos D. <dia...@gm...>]

Hello,

I am currently writing a kernel module that I would like to use it in the
UML, on ubuntu.
In this module I have some events that I would like to generate with a ns
precision. (e.g every 10 ns).

On an ubuntu kernel I used a busy waiting, with  ndelay function which uses
the TSC register, but
I have noticed that this register cannot be read from an UML.
Can you tell me please what is the reason for not being able to read the
TSC register from kernel,
and if there is other possibility to obtain ns precision as the ndelay
implementation has?

Best wishes,

Dragos

Re: [uml-user] Receive segv when creating unix domain socket on hostfs mounted directory

[richard -r. w. <ric...@gm...>]

Hi!

On Tue, Aug 21, 2012 at 5:15 PM, 张东亚 <for...@gm...> wrote:
> Hi,
>   I am running linux 3.4 uml,it works quite well, however recently I
> want to running openvswitch on the uml instance,I will got an segv
> fault.

What segfaulted? The UML kernel or some user space application?

>   I set a breadpoint in the kernel for unix_bind and found the
> following error, /usr/work/umser is the host directory which I mounted
> as uml /usr.
>   Because I am not quite familiar with kernel code, hope that someone
> can give me a hint how to fix this, thanks a lot.
>

What exactly is the problem?

>
> Breakpoint 2, do_mknod (
>     file=0x17d9d000
> "//usr/work/umusr/local/var/run/openvswitch/ovsdb-server.858.ctl",
> mode=49600,
>     major=0, minor=0) at fs/hostfs/hostfs_user.c:323
>
> int do_mknod(const char *file, int mode, unsigned int major, unsigned int minor)
> {
>         int err;
>
>         err = mknod(file, mode, os_makedev(major, minor));
>         if (err)
>                 return -errno;   // return -12???

-12 is ENOMEM.
Looks like your machine runs out of memory...

-- 
Thanks,
//richard

[uml-user] Receive segv when creating unix domain socket on hostfs mounted directory

[张东亚 <for...@gm...>]

Hi,
  I am running linux 3.4 uml,it works quite well, however recently I
want to running openvswitch on the uml instance,I will got an segv
fault.
  I set a breadpoint in the kernel for unix_bind and found the
following error, /usr/work/umser is the host directory which I mounted
as uml /usr.
  Because I am not quite familiar with kernel code, hope that someone
can give me a hint how to fix this, thanks a lot.



Breakpoint 2, do_mknod (
    file=0x17d9d000
"//usr/work/umusr/local/var/run/openvswitch/ovsdb-server.858.ctl",
mode=49600,
    major=0, minor=0) at fs/hostfs/hostfs_user.c:323

int do_mknod(const char *file, int mode, unsigned int major, unsigned int minor)
{
	int err;

	err = mknod(file, mode, os_makedev(major, minor));
	if (err)
		return -errno;   // return -12???
	return 0;
}

Re: [uml-user] linxu kernel 3.5 - first experience

[richard -r. w. <ric...@gm...>]

On Sun, Jul 22, 2012 at 2:06 PM, Toralf Förster <tor...@gm...> wrote:
> On 07/22/2012 01:18 PM, richard -rw- weinberger wrote:
> After a given time the system becomes non-reactive.
> Neither at the command line (xterm) nor via  a network connection the
> systems gave any response.
> The appropriate linux-3.5 process tooks up to 100% of one core.

UML hang in an infinite loop and the backtrace is mostly useless.

> I had to kill all linux-3.5 and port-helper processes.
> A core file was not produced.
>
> With (host + guest) kernel 3.4.6 I didn't observed this behaviour.

And now you have 3.5 on host and guest?
Does 3.5 on top of 3.4 work?
Can you reproduce the problem?

-- 
Thanks,
//richard

Re: [uml-user] linxu kernel 3.5 - first experience

[Toralf F. <tor...@gm...>]

On 07/22/2012 01:18 PM, richard -rw- weinberger wrote:
> Toralf,
> 
> please more details.

It is an unstable Gentoo Linux image, where I have cups-15.3, apache-2.4.2,
mysql-5.1.62 and courier-~0.68.2.20120626 running.

After a given time the system becomes non-reactive.
Neither at the command line (xterm) nor via  a network connection the
systems gave any response.
The appropriate linux-3.5 process tooks up to 100% of one core.
I had to kill all linux-3.5 and port-helper processes.
A core file was not produced.

With (host + guest) kernel 3.4.6 I didn't observed this behaviour.


-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Re: [uml-user] linxu kernel 3.5 - first experience

[richard -r. w. <ric...@gm...>]

Toralf,

On Sun, Jul 22, 2012 at 12:42 PM, Toralf Förster <tor...@gm...> wrote:
> With Linux n22 3.5.0-rc7+ as a host kernel and 3.5 as guest kernel my unstable Gentoo system hangs after a while.
> The back trace derived from gdb shows :

please more details.
I've told you many times that we need more than a random gdb backtrace.
Especially because in UML backtraces are sometimes very misleading.

So, what exactly have you done?
Please define "hang"
Did it crash? Was it nonreactive? Consumed the process on the host
side 100% CPU?
...

-- 
Thanks,
//richard

[uml-user] linxu kernel 3.5 - first experience

[Toralf F. <tor...@gm...>]

With Linux n22 3.5.0-rc7+ as a host kernel and 3.5 as guest kernel my unstable Gentoo system hangs after a while.
The back trace derived from gdb shows :

(gdb) bt
#0  0x0805f43b in from_irq_stack (nested=0) at arch/um/kernel/irq.c:462
#1  0x080739ec in hard_handler (sig=<optimized out>, info=0x83aac8c, p=0x83aad0c) at arch/um/os-Linux/signal.c:174
#2  <signal handler called>
#3  0xb774b424 in __kernel_vsyscall ()
#4  0x4b407633 in __write_nocancel () at ../sysdeps/unix/syscall-template.S:82
#5  0x08069d50 in net_write (fd=14, buf=0x1b972056, len=74) at arch/um/drivers/net_user.c:127
#6  0x08075845 in tuntap_write (fd=14, skb=0x1fdf4900, lp=0x1fcc23a0) at arch/um/os-Linux/drivers/tuntap_kern.c:46
#7  0x080688db in uml_net_start_xmit (skb=0x1fdf4900, dev=0x1fcc2000) at arch/um/drivers/net_kern.c:220
#8  0x08283cdc in dev_hard_start_xmit (skb=0x1fdf4900, dev=0x1fcc2000, txq=0x1fd38280) at net/core/dev.c:2212
#9  0x082992f3 in sch_direct_xmit (skb=0x1fdf4900, q=0x1ff31400, dev=0x1fcc2000, txq=0x1fd38280, root_lock=0x1ff3145c) at net/sched/sch_generic.c:124
#10 0x082841ad in __dev_xmit_skb (txq=<optimized out>, dev=0x1fcc2000, q=0x1ff31400, skb=0x1fdf4900) at net/core/dev.c:2415
#11 dev_queue_xmit (skb=0x1fdf4900) at net/core/dev.c:2508
#12 0x082a8a48 in neigh_hh_output (hh=<optimized out>, skb=<optimized out>) at include/net/neighbour.h:351
#13 neigh_output (skb=<optimized out>, n=0x1fd89100) at include/net/neighbour.h:358
#14 ip_finish_output2 (skb=<optimized out>) at net/ipv4/ip_output.c:210
#15 ip_finish_output (skb=<optimized out>) at net/ipv4/ip_output.c:243
#16 0x082a8c11 in ip_output (skb=0x1fdf4900) at net/ipv4/ip_output.c:316
#17 0x082a7ae3 in dst_output (skb=0x1fdf4900) at include/net/dst.h:435
#18 ip_local_out (skb=0x1fdf4900) at net/ipv4/ip_output.c:110
#19 0x082a7c17 in ip_build_and_send_pkt (skb=0x1fdf4900, sk=0x1ffb4e40, saddr=838969536, daddr=4261456064, opt=0x0) at net/ipv4/ip_output.c:175
#20 0x082c21f4 in tcp_v4_send_synack (sk=0x1ffb4e40, dst=0x1fe6c180, req=0x1feb2d80, rvp=0x1b866608, queue_mapping=0) at net/ipv4/tcp_ipv4.c:845
#21 0x082c460d in tcp_v4_conn_request (sk=0x1ffb4e40, skb=0x1fdf4780) at net/ipv4/tcp_ipv4.c:1426
#22 0x082bc44c in tcp_rcv_state_process (sk=0x1ffb4e40, skb=0x1fdf4780, th=0x1ff7c062, len=40) at net/ipv4/tcp_input.c:6034
#23 0x082c292d in tcp_v4_do_rcv (sk=0x1ffb4e40, skb=0x1fdf4780) at net/ipv4/tcp_ipv4.c:1652
#24 0x082c518d in tcp_v4_rcv (skb=0x1fdf4780) at net/ipv4/tcp_ipv4.c:1755
#25 0x082a3f55 in ip_local_deliver_finish (skb=0x1fdf4780) at net/ipv4/ip_input.c:226
#26 ip_local_deliver (skb=0x1fdf4780) at net/ipv4/ip_input.c:264
#27 0x082a432f in dst_input (skb=0x1fdf4780) at include/net/dst.h:441
#28 ip_rcv_finish (skb=0x1fdf4780) at net/ipv4/ip_input.c:365
#29 ip_rcv (skb=<optimized out>, dev=0x1fcc2000, pt=0x83c1be0, orig_dev=0x1fcc2000) at net/ipv4/ip_input.c:443
#30 0x08281960 in __netif_receive_skb (skb=0x1fdf4780) at net/core/dev.c:3235
#31 0x08281b66 in process_backlog (napi=0x83c4300, quota=2) at net/core/dev.c:3685
#32 0x082853fc in net_rx_action (h=0x83e0ecc) at net/core/dev.c:3843
#33 0x08085c06 in __do_softirq () at kernel/softirq.c:238
#34 0x08085de5 in do_softirq () at kernel/softirq.c:285
#35 0x08086025 in invoke_softirq () at kernel/softirq.c:319
#36 irq_exit () at kernel/softirq.c:338
#37 0x0805f01a in do_IRQ (irq=5, regs=0x1b8668f0) at arch/um/kernel/irq.c:295
#38 0x0805f08b in sigio_handler (sig=29, regs=0x1b8668f0) at arch/um/kernel/irq.c:53
#39 0x08073ced in sig_handler_common (sig=29, mc=0x0) at arch/um/os-Linux/signal.c:43
#40 0x08073c7e in unblock_signals () at arch/um/os-Linux/signal.c:278
#41 0x0822e185 in arch_local_irq_enable () at /home/tfoerste/devel/linux/arch/um/include/asm/irqflags.h:21
#42 spin_unlock_irq (lock=<optimized out>) at include/linux/spinlock.h:335
#43 blk_queue_bio (q=0x1fd7e000, bio=0x1feb2600) at block/blk-core.c:1531
#44 0x0822cbd6 in generic_make_request (bio=0x1feb2600) at block/blk-core.c:1782
#45 0x0822ccb6 in submit_bio (rw=96, bio=0x1feb2600) at block/blk-core.c:1829
#46 0x08128a6c in submit_bh (rw=96, bh=0x1d162620) at fs/buffer.c:2917
#47 0x081633f5 in ext3_find_entry (dir=0x1e30b7b4, entry=0x1d163994, res_dir=0x1b866d08) at fs/ext3/namei.c:915
#48 0x0816357d in ext3_lookup (dir=0x1e30b7b4, dentry=0x1d163980, nd=0x1b866df0) at fs/ext3/namei.c:1023
#49 0x0810a221 in lookup_real (nd=0x1b866df0, dentry=0x1d163980, dir=<optimized out>) at fs/namei.c:1102
#50 __lookup_hash (name=0x1b866df8, base=0x1e2ed280, nd=0x1b866df0) at fs/namei.c:1120
#51 0x0810b40a in lookup_slow (nd=0x1b866df0, name=<optimized out>, path=0x1b866d98) at fs/namei.c:1239
#52 0x0810c6cf in walk_component (follow=1, name=0x1b866df8, path=0x1b866d98, nd=0x1b866df0, type=<optimized out>) at fs/namei.c:1329
#53 lookup_last (path=0x1b866d98, nd=0x1b866df0) at fs/namei.c:1739
#54 path_lookupat (dfd=<optimized out>, name=0x41 <Address 0x41 out of bounds>, flags=65, nd=0x1b866df0) at fs/namei.c:1774
#55 0x0810c715 in do_path_lookup (dfd=-100, name=0x1fe75000 "/usr/share/doc/apache-2.4.2/manual/style/css/manual.css", flags=1, nd=0x1b866df0) at fs/namei.c:1809
#56 0x0810cbfb in user_path_at_empty (dfd=-100, name=0x42210558 <Address 0x42210558 out of bounds>, flags=1, path=0x1b866e90, empty=0x0) at fs/namei.c:1929
#57 0x0810cc8e in user_path_at (dfd=-100, name=0x42210558 <Address 0x42210558 out of bounds>, flags=1, path=0x1b866e90) at fs/namei.c:1940
#58 0x08104f87 in vfs_fstatat (dfd=-100, filename=0x42210558 <Address 0x42210558 out of bounds>, stat=0x1b866ec4, flag=<optimized out>) at fs/stat.c:88
#59 0x08104ff8 in vfs_stat (name=0x42210558 <Address 0x42210558 out of bounds>, stat=0x1b866ec4) at fs/stat.c:101
#60 0x08105249 in sys_stat64 (filename=0x42210558 <Address 0x42210558 out of bounds>, statbuf=0x4e316f80) at fs/stat.c:376
#61 0x08062e73 in handle_syscall (r=0x1b875e90) at arch/um/kernel/skas/syscall.c:35
#62 0x08077224 in handle_trap (local_using_sysemu=2, regs=0x1b875e90, pid=2444) at arch/um/os-Linux/skas/process.c:193
#63 userspace (regs=0x1b875e90) at arch/um/os-Linux/skas/process.c:418
#64 0x0805fc94 in fork_handler () at arch/um/kernel/process.c:181
#65 0x00000000 in ?? ()

:-(

-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Re: [uml-user] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

[David M. <da...@da...>]

From: Joe Perches <jo...@pe...>
Date: Thu, 12 Jul 2012 22:33:04 -0700

> net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
> added a new style API.  Rename random_ether_addr to eth_random_addr to
> create some API symmetry.

Series applied, thanks Joe.

Re: [uml-user] [PATCH net-next 8/8] arch: Use eth_random_addr

[Ralf B. <ra...@li...>]

On Thu, Jul 12, 2012 at 10:33:12PM -0700, Joe Perches wrote:

> Convert the existing uses of random_ether_addr to
> the new eth_random_addr.
> 
> Signed-off-by: Joe Perches <jo...@pe...>
> ---
>  arch/blackfin/mach-bf537/boards/stamp.c |    2 +-
>  arch/c6x/kernel/soc.c                   |    2 +-
>  arch/mips/ar7/platform.c                |    4 ++--
>  arch/mips/powertv/powertv_setup.c       |    6 +++---
>  arch/um/drivers/net_kern.c              |    2 +-
>  5 files changed, 8 insertions(+), 8 deletions(-)

Acked-by: Ralf Baechle <ra...@li...>

Thanks,

  Ralf

Re: [uml-user] [PATCH net-next 8/8] arch: Use eth_random_addr

[Mark S. <ms...@re...>]

On Thu, 2012-07-12 at 22:33 -0700, Joe Perches wrote:
> Convert the existing uses of random_ether_addr to
> the new eth_random_addr.
> 
> Signed-off-by: Joe Perches <jo...@pe...>
> ---
>  arch/blackfin/mach-bf537/boards/stamp.c |    2 +-
>  arch/c6x/kernel/soc.c                   |    2 +-

Acked-by: Mark Salter <ms...@re...>

Re: [uml-user] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

[David M. <da...@da...>]

From: Felipe Balbi <ba...@ti...>
Date: Mon, 16 Jul 2012 14:12:19 +0300

> Acked-by: Felipe Balbi <ba...@ti...>

You need to provide this in a reply to the patch you actually want
to ACK, so that the patch tracking system attaches your ACK to
the proper patch.

Thank you.

Re: [uml-user] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

[Felipe B. <ba...@ti...>]

Hi,

On Mon, Jul 16, 2012 at 03:29:01AM -0700, David Miller wrote:
> From: Felipe Balbi <ba...@ti...>
> Date: Mon, 16 Jul 2012 13:14:38 +0300
> 
> > if you're really renaming the function, then this patch alone will break
> > all of the below users. That should all be a single patch, I'm afraid.
> 
> It would help if you actually read his patches before saying what they
> might or might not do.
> 
> He provides a macro in the first patch that provides the old name,
> and this will get removed at the end.

that's why I put an "if" there. The subject was misleading and I really
couldn't bother going search for the patch on the mail archives.

Anyway, if nothing will be broken then for drivers/usb/gadget/:

Acked-by: Felipe Balbi <ba...@ti...>

-- 
balbi

Re: [uml-user] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

[David M. <da...@da...>]

From: Felipe Balbi <ba...@ti...>
Date: Mon, 16 Jul 2012 13:14:38 +0300

> if you're really renaming the function, then this patch alone will break
> all of the below users. That should all be a single patch, I'm afraid.

It would help if you actually read his patches before saying what they
might or might not do.

He provides a macro in the first patch that provides the old name,
and this will get removed at the end.

Re: [uml-user] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

[Felipe B. <ba...@ti...>]

On Thu, Jul 12, 2012 at 10:33:04PM -0700, Joe Perches wrote:
> net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
> added a new style API.  Rename random_ether_addr to eth_random_addr to
> create some API symmetry.
> 
> Joe Perches (8):
>   etherdevice: Rename random_ether_addr to eth_random_addr

if you're really renaming the function, then this patch alone will break
all of the below users. That should all be a single patch, I'm afraid.

>   ethernet: Use eth_random_addr
>   net: usb: Use eth_random_addr
>   wireless: Use eth_random_addr
>   drivers/net: Use eth_random_addr
>   s390: Use eth_random_addr
>   usb: Use eth_random_addr
>   arch: Use eth_random_addr
> 
>  arch/blackfin/mach-bf537/boards/stamp.c           |    2 +-
>  arch/c6x/kernel/soc.c                             |    2 +-
>  arch/mips/ar7/platform.c                          |    4 ++--
>  arch/mips/powertv/powertv_setup.c                 |    6 +++---
>  arch/um/drivers/net_kern.c                        |    2 +-
>  drivers/net/ethernet/atheros/atl1c/atl1c_hw.c     |    2 +-
>  drivers/net/ethernet/atheros/atlx/atl1.c          |    2 +-
>  drivers/net/ethernet/atheros/atlx/atl2.c          |    2 +-
>  drivers/net/ethernet/ethoc.c                      |    2 +-
>  drivers/net/ethernet/intel/igb/igb_main.c         |    4 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c    |    2 +-
>  drivers/net/ethernet/lantiq_etop.c                |    2 +-
>  drivers/net/ethernet/micrel/ks8851.c              |    2 +-
>  drivers/net/ethernet/micrel/ks8851_mll.c          |    2 +-
>  drivers/net/ethernet/smsc/smsc911x.c              |    2 +-
>  drivers/net/ethernet/ti/cpsw.c                    |    2 +-
>  drivers/net/ethernet/tile/tilegx.c                |    2 +-
>  drivers/net/ethernet/wiznet/w5100.c               |    2 +-
>  drivers/net/ethernet/wiznet/w5300.c               |    2 +-
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c |    2 +-
>  drivers/net/tun.c                                 |    2 +-
>  drivers/net/usb/smsc75xx.c                        |    2 +-
>  drivers/net/usb/smsc95xx.c                        |    2 +-
>  drivers/net/usb/usbnet.c                          |    2 +-
>  drivers/net/wimax/i2400m/driver.c                 |    2 +-
>  drivers/net/wireless/adm8211.c                    |    2 +-
>  drivers/net/wireless/p54/eeprom.c                 |    2 +-
>  drivers/net/wireless/rt2x00/rt2400pci.c           |    2 +-
>  drivers/net/wireless/rt2x00/rt2500pci.c           |    2 +-
>  drivers/net/wireless/rt2x00/rt2500usb.c           |    2 +-
>  drivers/net/wireless/rt2x00/rt2800lib.c           |    2 +-
>  drivers/net/wireless/rt2x00/rt61pci.c             |    2 +-
>  drivers/net/wireless/rt2x00/rt73usb.c             |    2 +-
>  drivers/net/wireless/rtl818x/rtl8180/dev.c        |    2 +-
>  drivers/net/wireless/rtl818x/rtl8187/dev.c        |    2 +-
>  drivers/s390/net/qeth_l2_main.c                   |    2 +-
>  drivers/s390/net/qeth_l3_main.c                   |    2 +-
>  drivers/usb/atm/xusbatm.c                         |    4 ++--
>  drivers/usb/gadget/u_ether.c                      |    2 +-
>  include/linux/etherdevice.h                       |   14 ++++++++------
>  40 files changed, 52 insertions(+), 50 deletions(-)
> 
> -- 
> 1.7.8.111.gad25c.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to maj...@vg...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
balbi

Re: [uml-user] [PATCH net-next 8/8] arch: Use eth_random_addr

[Mike F. <va...@ge...>]

On Friday 13 July 2012 01:33:12 Joe Perches wrote:
> Convert the existing uses of random_ether_addr to
> the new eth_random_addr.
> 
> Signed-off-by: Joe Perches <jo...@pe...>
> ---
>  arch/blackfin/mach-bf537/boards/stamp.c |    2 +-

Acked-by: Mike Frysinger <va...@ge...>
-mike

[uml-user] [PATCH net-next 8/8] arch: Use eth_random_addr

[Joe P. <jo...@pe...>]

Convert the existing uses of random_ether_addr to
the new eth_random_addr.

Signed-off-by: Joe Perches <jo...@pe...>
---
 arch/blackfin/mach-bf537/boards/stamp.c |    2 +-
 arch/c6x/kernel/soc.c                   |    2 +-
 arch/mips/ar7/platform.c                |    4 ++--
 arch/mips/powertv/powertv_setup.c       |    6 +++---
 arch/um/drivers/net_kern.c              |    2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
index c9d9473..5ed654a 100644
--- a/arch/blackfin/mach-bf537/boards/stamp.c
+++ b/arch/blackfin/mach-bf537/boards/stamp.c
@@ -873,7 +873,7 @@ static struct adf702x_platform_data adf7021_platform_data = {
 };
 static inline void adf702x_mac_init(void)
 {
-	random_ether_addr(adf7021_platform_data.mac_addr);
+	eth_random_addr(adf7021_platform_data.mac_addr);
 }
 #else
 static inline void adf702x_mac_init(void) {}
diff --git a/arch/c6x/kernel/soc.c b/arch/c6x/kernel/soc.c
index 0748c94..3ac7408 100644
--- a/arch/c6x/kernel/soc.c
+++ b/arch/c6x/kernel/soc.c
@@ -80,7 +80,7 @@ int soc_mac_addr(unsigned int index, u8 *addr)
 		if (have_fuse_mac)
 			memcpy(addr, c6x_fuse_mac, 6);
 		else
-			random_ether_addr(addr);
+			eth_random_addr(addr);
 	}
 
 	/* adjust for specific EMAC device */
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
index 1a24d31..1bbc24b 100644
--- a/arch/mips/ar7/platform.c
+++ b/arch/mips/ar7/platform.c
@@ -310,10 +310,10 @@ static void __init cpmac_get_mac(int instance, unsigned char *dev_addr)
 					&dev_addr[4], &dev_addr[5]) != 6) {
 			pr_warning("cannot parse mac address, "
 					"using random address\n");
-			random_ether_addr(dev_addr);
+			eth_random_addr(dev_addr);
 		}
 	} else
-		random_ether_addr(dev_addr);
+		eth_random_addr(dev_addr);
 }
 
 /*****************************************************************************
diff --git a/arch/mips/powertv/powertv_setup.c b/arch/mips/powertv/powertv_setup.c
index 3933c37..820b848 100644
--- a/arch/mips/powertv/powertv_setup.c
+++ b/arch/mips/powertv/powertv_setup.c
@@ -254,7 +254,7 @@ early_param("rfmac", rfmac_param);
  * Generates an Ethernet MAC address that is highly likely to be unique for
  * this particular system on a network with other systems of the same type.
  *
- * The problem we are solving is that, when random_ether_addr() is used to
+ * The problem we are solving is that, when eth_random_addr() is used to
  * generate MAC addresses at startup, there isn't much entropy for the random
  * number generator to use and the addresses it produces are fairly likely to
  * be the same as those of other identical systems on the same local network.
@@ -269,7 +269,7 @@ early_param("rfmac", rfmac_param);
  * Still, this does give us something to work with.
  *
  * The approach we take is:
- * 1.	If we can't get the RF MAC Address, just call random_ether_addr.
+ * 1.	If we can't get the RF MAC Address, just call eth_random_addr.
  * 2.	Use the 24-bit NIC-specific bits of the RF MAC address as the last 24
  *	bits of the new address. This is very likely to be unique, except for
  *	the current box.
@@ -299,7 +299,7 @@ void platform_random_ether_addr(u8 addr[ETH_ALEN])
 	if (!have_rfmac) {
 		pr_warning("rfmac not available on command line; "
 			"generating random MAC address\n");
-		random_ether_addr(addr);
+		eth_random_addr(addr);
 	}
 
 	else {
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 0d60c56..458d324 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -339,7 +339,7 @@ static int setup_etheraddr(char *str, unsigned char *addr, char *name)
 random:
 	printk(KERN_INFO
 	       "Choosing a random ethernet address for device %s\n", name);
-	random_ether_addr(addr);
+	eth_random_addr(addr);
 	return 1;
 }
 
-- 
1.7.8.111.gad25c.dirty