From: William S. <wst...@po...> - 2004-04-28 06:37:51
|
Good evening, Jeff, all, The 2.4.24-2 patch goes in pretty well to 2.4.27-pre1, just a few offsets and the following minor issues: - include/asm-um/system-i386.h has a duplicate definition of __cmpxchg . It looks close enough to the one in include/asm/arch/system.h that I just commented out asm-um's. - when compiling the aio code, there's a missing aio_abi.h. make[2]: Entering directory `/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/os-Linux' gcc -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -U__i386__ -Ui386 -g -D__arch_um__ -DSUBARCH=\"i386\" -D_LARGEFILE64_SOURCE -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/kernel/tt/include -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/kernel/skas/include -D_GNU_SOURCE -c -o aio.o aio.c aio.c:12:27: linux/aio_abi.h: No such file or directory aio.c: In function `init_aio_26': aio.c:253: warning: implicit declaration of function `io_setup' aio.c:253: error: `ctx' undeclared (first use in this function) aio.c:253: error: (Each undeclared identifier is reported only once aio.c:253: error: for each function it appears in.) aio.c:260: error: `aio_thread' undeclared (first use in this function) aio.c: In function `submit_aio_26': aio.c:324: warning: implicit declaration of function `do_aio' aio.c:324: error: `ctx' undeclared (first use in this function) make[2]: *** [aio.o] Error 1 make[2]: Leaving directory `/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/os-Linux' make[1]: *** [first_rule] Error 2 make[1]: Leaving directory `/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/os-Linux' make: *** [_dir_arch/um/os-Linux] Error 2 [wstearns@sparrow linux-2.4.27-pre1-uml24242-netfilter20040427]$ By copying one from 2.6.x to /usr/include/linux/ , the compile goes through to the final linking stage. The binary links and runs. I'll upload it to http://www.stearns.org/uml/ There are a bunch of warnings about __initcal, __exit_call, and __init_call redefinitions. Cheers, - Bill --------------------------------------------------------------------------- Codito, ergo sum "I code, therefore I am" Nolo Codito, ergo nada "My code is so horrible that I ceased to exist last Tuesday." -- Ross Carlson and William Stearns -------------------------------------------------------------------------- William Stearns (wst...@po...). Mason, Buildkernel, freedups, p0f, rsync-backup, ssh-keyinstall, dns-check, more at: http://www.stearns.org -------------------------------------------------------------------------- |
From: Henrik N. <um...@he...> - 2004-04-28 07:06:55
|
On Wed, 28 Apr 2004, William Stearns wrote: > - include/asm-um/system-i386.h has a duplicate definition of __cmpxchg . > It looks close enough to the one in include/asm/arch/system.h that I > just commented out asm-um's. Patch was sent some weeks ago. It is needed for 2.4.26 as well. Your change is correct. > - when compiling the aio code, there's a missing aio_abi.h. Sent a patch for this some days ago. Also sent a patch which fixes hostfs which is somewhat broken in 2.4.24-2. copying aio_abi.h from 2.6 is also ok, but does not fix hostfs.. > Thre are a bunch of warnings about __initcal, __exit_call, and > __init_call redefinitions. Which warnings? Regards Henrik |
From: William S. <wst...@po...> - 2004-04-28 14:53:46
|
Good day, Henrik, On Wed, 28 Apr 2004, Henrik Nordstrom wrote: > On Wed, 28 Apr 2004, William Stearns wrote: > > > Thre are a bunch of warnings about __initcal, __exit_call, and > > __init_call redefinitions. > > Which warnings? A sample from late in the build: gcc -D__KERNEL__ -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -U__i386__ -Ui386 -g -D__arch_um__ -DSUBARCH="i386" -D_LARGEFILE64_SOURCE -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include -Derrno=kernel_errno -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/kernel/tt/include -I/usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/kernel/skas/include -nostdinc -iwithprefix include -DKBUILD_BASENAME=line -c -o line.o line.c In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_user.h:9, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_kern.h:11, from line.c:12: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/init.h:103:1: warning: "__initcall" redefined In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/arch/system.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system-generic.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/spinlock.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/wait.h:16, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/fs.h:12, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/capability.h:17, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/binfmts.h:5, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/sched.h:9, from line.c:6: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/init.h:54:1: warning: this is the location of the previous definition In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_user.h:9, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_kern.h:11, from line.c:12: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/init.h:106:1: warning: "__init_call" redefined In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/arch/system.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system-generic.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/spinlock.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/wait.h:16, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/fs.h:12, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/capability.h:17, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/binfmts.h:5, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/sched.h:9, from line.c:6: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/init.h:84:1: warning: this is the location of the previous definition In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_user.h:9, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/chan_kern.h:11, from line.c:12: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/init.h:107:1: warning: "__exit_call" redefined In file included from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/arch/system.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system-generic.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/asm/system.h:4, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/spinlock.h:6, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/wait.h:16, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/fs.h:12, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/capability.h:17, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/binfmts.h:5, from /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/sched.h:9, from line.c:6: /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/init.h:85:1: warning: this is the location of the previous definition rm -f built-in.o Nothing fatal, just bringing it up. Cheers, - Bill --------------------------------------------------------------------------- If you've been pounding nails with your forehead for years, it may feel strange the first time somebody hands you a hammer. But that doesn't mean that you should strap the hammer to a headband just to give your skull that old familiar jolt. -- Wayne Throop, during the ``TCL Wars'' (Courtesy of Steve Dodd <di...@lo...>) -------------------------------------------------------------------------- William Stearns (wst...@po...). Mason, Buildkernel, freedups, p0f, rsync-backup, ssh-keyinstall, dns-check, more at: http://www.stearns.org -------------------------------------------------------------------------- |
From: Henrik N. <um...@he...> - 2004-04-28 15:17:15
|
On Wed, 28 Apr 2004, William Stearns wrote: > /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/arch/um/include/init.h:103:1: > warning: "__initcall" redefined > /usr/src/uml-linux/linux-2.4.27-pre1-uml24242-netfilter20040427/include/linux/init.h:54:1: > warning: this is the location of the previous definition Looks like Linux has added a generic __initcall definition available to all architectures. Please look into if the two are compatible. If they are then delete the one from arch/um/include/init.h, if not it is probably visible in include/linux/init.h how an arch should indicate it uses it's own __initcall method (usually done via a CONFIG_xx directive) Regards Henrik |