user-mode-linux-devel

Re: [uml-devel] [PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

[Geert U. <ge...@li...>]

Hi Greg,

On Sun, Feb 21, 2016 at 5:23 AM, Greg Kroah-Hartman
<gr...@li...> wrote:
> On Tue, Feb 16, 2016 at 04:10:57PM +0100, Geert Uytterhoeven wrote:
>> Some platforms don't have DMA, but we should still be able to build USB
>> drivers for these platforms. They could still be used through vhci_hcd,
>> usbip_host, or maybe something like USB passthrough in UML from a
>> capable host.
>>
>> If NO_DMA=y:
>>
>>     ERROR: "dma_pool_destroy" [drivers/usb/core/usbcore.ko] undefined!
>>     ERROR: "bad_dma_ops" [drivers/usb/core/usbcore.ko] undefined!
>>     ERROR: "dma_pool_free" [drivers/usb/core/usbcore.ko] undefined!
>>     ERROR: "dma_pool_alloc" [drivers/usb/core/usbcore.ko] undefined!
>>     ERROR: "dma_pool_create" [drivers/usb/core/usbcore.ko] undefined!
>>
>> Add a few checks for CONFIG_HAS_DMA to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <ge...@li...>
>> Acked-by: Vegard Nossum <veg...@or...>
>> ---
>> v2:
>>   - Replace remaining #ifdefs by IS_ENABLED() checks,
>>   - Add to patch description that this actually allows using USB on UML,
>>   - Add Acked-by.
>
> This patch didn't apply to my tree, can you rebase it against usb-next
> of usb.git and resend?

Are you sure it's this one that didn't apply? It's already in usb-testing?

"[2/3] usb: host: Host drivers relying on DMA should depend on HAS_DMA"
doesn't apply, as your tree gained some HAS_IOMEM dependencies, so I'll
resend.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [uml-devel] [PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

[Greg Kroah-H. <gr...@li...>]

On Sun, Feb 21, 2016 at 10:46:59PM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Sun, Feb 21, 2016 at 5:23 AM, Greg Kroah-Hartman
> <gr...@li...> wrote:
> > On Tue, Feb 16, 2016 at 04:10:57PM +0100, Geert Uytterhoeven wrote:
> >> Some platforms don't have DMA, but we should still be able to build USB
> >> drivers for these platforms. They could still be used through vhci_hcd,
> >> usbip_host, or maybe something like USB passthrough in UML from a
> >> capable host.
> >>
> >> If NO_DMA=y:
> >>
> >>     ERROR: "dma_pool_destroy" [drivers/usb/core/usbcore.ko] undefined!
> >>     ERROR: "bad_dma_ops" [drivers/usb/core/usbcore.ko] undefined!
> >>     ERROR: "dma_pool_free" [drivers/usb/core/usbcore.ko] undefined!
> >>     ERROR: "dma_pool_alloc" [drivers/usb/core/usbcore.ko] undefined!
> >>     ERROR: "dma_pool_create" [drivers/usb/core/usbcore.ko] undefined!
> >>
> >> Add a few checks for CONFIG_HAS_DMA to fix this.
> >>
> >> Signed-off-by: Geert Uytterhoeven <ge...@li...>
> >> Acked-by: Vegard Nossum <veg...@or...>
> >> ---
> >> v2:
> >>   - Replace remaining #ifdefs by IS_ENABLED() checks,
> >>   - Add to patch description that this actually allows using USB on UML,
> >>   - Add Acked-by.
> >
> > This patch didn't apply to my tree, can you rebase it against usb-next
> > of usb.git and resend?
> 
> Are you sure it's this one that didn't apply? It's already in usb-testing?
> 
> "[2/3] usb: host: Host drivers relying on DMA should depend on HAS_DMA"
> doesn't apply, as your tree gained some HAS_IOMEM dependencies, so I'll
> resend.

Thanks, I think you were right.

greg k-h