From: Jeff D. <jd...@ad...> - 2007-03-28 01:39:02
|
I started getting warnings from atomic.h about cmpxchg not having a prototype. It's declared in system.h, so including that fixes the UML build warnings and has no noticable ill effects on the i386 build. Signed-off-by: Jeff Dike <jd...@li...> -- include/asm-i386/atomic.h | 1 + 1 file changed, 1 insertion(+) Signed-off-by: Jeff Dike <jd...@li...> -- Index: linux-2.6.21-mm/include/asm-i386/atomic.h =================================================================== --- linux-2.6.21-mm.orig/include/asm-i386/atomic.h 2007-03-27 12:25:16.000000000 -0400 +++ linux-2.6.21-mm/include/asm-i386/atomic.h 2007-03-27 12:26:38.000000000 -0400 @@ -3,6 +3,7 @@ #include <linux/compiler.h> #include <asm/processor.h> +#include <asm/system.h> /* * Atomic operations that C can't guarantee us. Useful for |
From: Andi K. <ak...@su...> - 2007-03-28 19:08:41
|
> #include <linux/compiler.h> > #include <asm/processor.h> > +#include <asm/system.h> Sorry no. system.h is the header from hell and putting it into a "basic" header like atomic_t will likely cause all kinds of problems. If it's a real issue move cmpxchhg into a different header and include that from system.h and atomic.h. system.h has too much stuff anyways so it could use any cleanup. -Andi |
From: Jeff D. <jd...@ad...> - 2007-03-30 01:19:29
|
On Wed, Mar 28, 2007 at 09:05:03PM +0200, Andi Kleen wrote: > > > #include <linux/compiler.h> > > #include <asm/processor.h> > > +#include <asm/system.h> > Sorry no. system.h is the header from hell and putting it into a > "basic" header like atomic_t will likely cause all kinds of > problems. OK, I'll figure out someplace else for it. Jeff -- Work email - jdike at linux dot intel dot com |