From: Paul W. <pa...@ku...> - 2004-04-21 08:29:32
Attachments:
PGP.sig
|
Hi all, These comments are based on the development code as provided by sikkh, as such not everything might be relevant, but I believe that the primary code changed by sikkh is in the metadata interface. Anyway, here goes: hostfs.h: struct externfs_file_ops: Almost all of the functions have the naming form verb_noun, except for file_create(). I would suggest to reverse this for the sake of consistency. Most functions have "long names" that is open_file, link_file, access_file, etc. The exceptions to this are mkdir(), rmdir(), mknod(), readlink(), and statfs(). This cannot be done to "keep standard semantics" since open_dir() is not in it's standard form either. I would suggest to rename all of the "short form" functions into the standardised form. Jeff, if you agree with the above, let me know, and you will receive a patch for it later today. Cheers, Paul |
From: Jeff D. <jd...@ad...> - 2004-04-21 14:35:00
|
On Wed, Apr 21, 2004 at 10:29:13AM +0200, Paul Wagland wrote: > struct externfs_file_ops: > Almost all of the functions have the naming form verb_noun, except > for file_create(). I would suggest to reverse this for the sake of > consistency. Yup. I'm schizophrenic on verb-noun vs noun-verb, sometimes within the same interface, as you've noticed. > > Most functions have "long names" that is open_file, link_file, > access_file, etc. The exceptions to this are mkdir(), rmdir(), mknod(), > readlink(), and statfs(). This cannot be done to "keep standard > semantics" since open_dir() is not in it's standard form either. I > would suggest to rename all of the "short form" functions into the > standardised form. Yup. > Jeff, if you agree with the above, let me know, and you will receive a > patch for it later today. OK, can you make it on top of sikkh's patch? Jeff |