From: Nikola C. <ext...@li...> - 2004-04-13 17:03:30
|
Hello, I was trying to get openswan working under UML, module compiles fine, but trying to load it fails with complaint about unresolved symbol memset and strstr I've found that those symbols are exported in i386 ksyms, but not in uml ksyms, so I've created little patch (enclosed), and everythink seems to work well. I'd like to ask, if my solution is 'clean' and if yes, wouldn;t it be usefull to add all such missing symbols (for work wish strings etc). if yes, i'd gladly create patch for inclusion thanks nik applied patch: diff -Naur linux-2.4.25/arch/um/kernel/ksyms.c linux-2.4.25-uml-fixmissingsymbols/arch/um/kernel/ksyms.c --- linux-2.4.25/arch/um/kernel/ksyms.c Tue Apr 13 08:35:36 2004 +++ linux-2.4.25-uml-fixmissingsymbols/arch/um/kernel/ksyms.c Tue Apr 13 08:32:55 2004 @@ -23,6 +23,7 @@ EXPORT_SYMBOL(stop); EXPORT_SYMBOL(strtok); +EXPORT_SYMBOL(strstr); EXPORT_SYMBOL(uml_physmem); EXPORT_SYMBOL(set_signals); EXPORT_SYMBOL(get_signals); @@ -111,6 +112,14 @@ EXPORT_SYMBOL(smp_num_cpus); #endif + +#undef memcpy +#undef memset +extern void * memset(void *,int,__kernel_size_t); +extern void * memcpy(void *,const void *,__kernel_size_t); +EXPORT_SYMBOL_NOVERS(memcpy); +EXPORT_SYMBOL_NOVERS(memset); + /* * Overrides for Emacs so that we follow Linus's tabbing style. |
From: BlaisorBlade <bla...@ya...> - 2004-04-13 17:34:34
|
Alle 19:03, marted=EC 13 aprile 2004, Nikola Ciprich ha scritto: > Hello, I was trying to get openswan working under UML, module compiles > fine, but trying to load it fails with complaint about unresolved symbol > memset and strstr > I've found that those symbols are exported in i386 ksyms, but not in uml > ksyms, so I've created little patch (enclosed), and everythink seems to > work well. > I'd like to ask, if my solution is 'clean' and if yes, Yes, it is clean (just it should go inside user_syms.c), but IIRC it has be= en=20 applied to late 2.4 & 2.6 UML kernels (I could be wrong). Check against=20 latest version and if it is not there (look inside user_syms.c) send the=20 patch, after making the change in user_syms.c, to Jeff Dike. Bye =2D-=20 Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 |
From: Nikola C. <ext...@li...> - 2004-04-14 10:30:41
|
thanks for reply, I took a look to user_syms.c of version I'm using, and really both memset and strstr are exported, but with EXPORT_SYMBOL_PROTO. whats the difference between EXPORT_SYMBOL and EXPORT_SYMBOL_PROTO? and it did not work, so should I just remove _PROTO? thanks in advance V =C3=9At, 13. 04. 2004 v 19:47, BlaisorBlade p=C3=AD=C5=A1e: > Alle 19:03, marted=C3=AC 13 aprile 2004, Nikola Ciprich ha scritto: > > Hello, I was trying to get openswan working under UML, module compile= s > > fine, but trying to load it fails with complaint about unresolved sym= bol > > memset and strstr > > I've found that those symbols are exported in i386 ksyms, but not in = uml > > ksyms, so I've created little patch (enclosed), and everythink seems = to > > work well. >=20 > > I'd like to ask, if my solution is 'clean' and if yes, > Yes, it is clean (just it should go inside user_syms.c), but IIRC it ha= s been=20 > applied to late 2.4 & 2.6 UML kernels (I could be wrong). Check against= =20 > latest version and if it is not there (look inside user_syms.c) send th= e=20 > patch, after making the change in user_syms.c, to Jeff Dike. >=20 > Bye |