user-mode-linux-devel

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ri...@no...>]

Thomas,

Can you please give the attached patch a try?

Thanks,
//richard

Re: [uml-devel] warning at vma_merge

[Richard W. <ric...@gm...>]

Anton, Thomas,

On Sun, May 7, 2017 at 10:27 PM, Anton Ivanov
<ant...@ko...> wrote:
> Have a look at the list archive, this was covered a couple of weeks ago.
>
> I believe Richard is working on a fix.

Yep, this reminds me that I have to ping mm folks about this.
Please see: http://lkml.iu.edu/hypermail/linux/kernel/1703.2/02256.html

-- 
Thanks,
//richard

Re: [uml-devel] [uml-user] UML on WSL

[Anton I. <ant...@ko...>]

So far it is late 2.6. The high res timer subsystem settled fully 
somewhere circa 2.6.10 if memory serves me right. One of those lovely 
kernels which had VM collapse bugs :)

I am finishing testing the vector IO drivers and epoll irq controller 
for them you will need 3.0 onwards

In fact, I have run into brokennes in the core net_sched in 4.11 so I 
cannot fully test the xmit path in the new network drivers, otherwise I 
would have sent them out by now.

I have asked on linux-net, but no answer so far, trying to debug it 
myself. It is seriously broken (both for us and for virtio so kvm/qemu 
should be affected too).

A.


On 08/05/17 17:15, Richard Weinberger wrote:
> Thomas,
>
> Am 08.05.2017 um 18:09 schrieb Thomas Meyer:
>> Or asked he other way around:
>>
>> Is somewhere documented what's the minimum host kernel version that a UML kernel will run on?
>>
>> E.g.:
>> building a UML kernel from 4.11 will need a host kernel version 2.6.18 with features x, y and z enabled?
> Not really. But let's be realistic, we don't have to support a 2.4 host.
> UML should run on any kernel of a supported distro.
>
> On the other hand, if we can help WSL with a small change to UML, I'll happily apply such a patch.
>
> Thanks,
> //richard
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
>

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ri...@no...>]

Thomas,

Am 08.05.2017 um 18:09 schrieb Thomas Meyer:
> Or asked he other way around:
> 
> Is somewhere documented what's the minimum host kernel version that a UML kernel will run on?
> 
> E.g.:
> building a UML kernel from 4.11 will need a host kernel version 2.6.18 with features x, y and z enabled?

Not really. But let's be realistic, we don't have to support a 2.4 host.
UML should run on any kernel of a supported distro.

On the other hand, if we can help WSL with a small change to UML, I'll happily apply such a patch.

Thanks,
//richard

Re: [uml-devel] [uml-user] UML on WSL

[Thomas M. <th...@m3...>]

> Am 08.05.2017 um 17:40 schrieb Thomas Meyer <th...@m3...>:
> 
> 
>> Am 08.05.2017 um 17:35 schrieb Richard Weinberger <ri...@no...>:
>> 
>> Thomas,
>> 
>> Am 08.05.2017 um 17:32 schrieb Thomas Meyer:
>>>> We could figure how to report issues to WSL, create self-hosting unit tests and ask them to add/fix
>>>> these features.
>>> 
>>> Turns out there was already a bug report by somebody about missing UML support in WSL:
>>> 
>>> https://github.com/Microsoft/BashOnWindows/issues/1692
>> 
>> Ah, there are tons of ptrace() features missing.
>> UML is a major user of ptrace(), worse than GDB. ;-\
> 
> Yes, I know.
> 
> Probably also worh quoting the discussion from the relevant GH issue regarding OLDPTRACE :
> 
> "
> Also, for a little context, the onlysoftware I can find on the planet that cares is User Mode Linux. Unless someone tries to run some statically linked strace or maybe gdb binary from the 2.4 era, this will simply never be hit on WSL in 2017. UML seems to still care, entirely academically, to maintain binary compatibility with 2.4. You can think of it as UML never buying into the idea the value changed, while everyone else moved"
> 

Or asked he other way around:

Is somewhere documented what's the minimum host kernel version that a UML kernel will run on?

E.g.:
building a UML kernel from 4.11 will need a host kernel version 2.6.18 with features x, y and z enabled?

>> 
>> Thanks,
>> //richard
>> 
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> User-mode-linux-devel mailing list
>> Use...@li...
>> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-user mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-user

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ri...@no...>]

Thomas,

Am 08.05.2017 um 17:40 schrieb Thomas Meyer:
> "
> Also, for a little context, the /only/software I can find /on the planet/ that cares is User Mode Linux. Unless someone tries to run some statically linked |strace| or
> maybe |gdb| binary from the 2.4 era, this will simply never be hit on WSL in 2017. UML seems to still care, entirely academically, to maintain binary compatibility with 2.4. You
> can think of it as UML never buying into the idea the value changed, while everyone else moved"

-ENOPATCH. :-)

Thanks,
//richard

Re: [uml-devel] [uml-user] UML on WSL

[Thomas M. <th...@m3...>]

> Am 08.05.2017 um 17:35 schrieb Richard Weinberger <ri...@no...>:
> 
> Thomas,
> 
> Am 08.05.2017 um 17:32 schrieb Thomas Meyer:
>>> We could figure how to report issues to WSL, create self-hosting unit tests and ask them to add/fix
>>> these features.
>> 
>> Turns out there was already a bug report by somebody about missing UML support in WSL:
>> 
>> https://github.com/Microsoft/BashOnWindows/issues/1692
> 
> Ah, there are tons of ptrace() features missing.
> UML is a major user of ptrace(), worse than GDB. ;-\

Yes, I know.

Probably also worh quoting the discussion from the relevant GH issue regarding OLDPTRACE :

"
Also, for a little context, the onlysoftware I can find on the planet that cares is User Mode Linux. Unless someone tries to run some statically linked strace or maybe gdb binary from the 2.4 era, this will simply never be hit on WSL in 2017. UML seems to still care, entirely academically, to maintain binary compatibility with 2.4. You can think of it as UML never buying into the idea the value changed, while everyone else moved"

> 
> Thanks,
> //richard
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ri...@no...>]

Thomas,

Am 08.05.2017 um 17:32 schrieb Thomas Meyer:
>> We could figure how to report issues to WSL, create self-hosting unit tests and ask them to add/fix
>> these features.
> 
> Turns out there was already a bug report by somebody about missing UML support in WSL:
> 
> https://github.com/Microsoft/BashOnWindows/issues/1692

Ah, there are tons of ptrace() features missing.
UML is a major user of ptrace(), worse than GDB. ;-\

Thanks,
//richard

Re: [uml-devel] [uml-user] UML on WSL

[Thomas M. <th...@m3...>]

> Am 08.05.2017 um 17:05 schrieb Richard Weinberger <ri...@no...>:
> 
> Thomas,
> 
>> Am 08.05.2017 um 17:02 schrieb Thomas Meyer:
>> Sadly, UML executable bails out very early. it Looks like WSL is missing some PTRACE stuff:
>> 
>> thomas@DESKTOP-DQBDJ0U:/mnt/c/Users/thomas/Downloads$ ./linux
>> Core dump limits :
>>        soft - NONE
>>        hard - NONE
>> Checking that ptrace can change system call numbers...check_ptrace: PTRACE_OLDSETOPTIONS failed: Invalid Argument
> 
> We could figure how to report issues to WSL, create self-hosting unit tests and ask them to add/fix
> these features.

Turns out there was already a bug report by somebody about missing UML support in WSL:

https://github.com/Microsoft/BashOnWindows/issues/1692

> 
> Thanks,
> //richard
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ri...@no...>]

Thomas,

Am 08.05.2017 um 17:02 schrieb Thomas Meyer:
> Sadly, UML executable bails out very early. it Looks like WSL is missing some PTRACE stuff:
> 
> thomas@DESKTOP-DQBDJ0U:/mnt/c/Users/thomas/Downloads$ ./linux
> Core dump limits :
>         soft - NONE
>         hard - NONE
> Checking that ptrace can change system call numbers...check_ptrace: PTRACE_OLDSETOPTIONS failed: Invalid Argument

We could figure how to report issues to WSL, create self-hosting unit tests and ask them to add/fix
these features.

Thanks,
//richard

Re: [uml-devel] [uml-user] UML on WSL

[Thomas M. <th...@m3...>]

Zitat von Richard Weinberger <ric...@gm...>:

> Thomas,
>
> On Sun, May 7, 2017 at 1:44 PM, Thomas Meyer <th...@m3...> wrote:
>> Hi,

Hi,

>>
>> Did anybody try to run UML on the new Windows 10 subsystem for Linux? I
>> wonder what missing functions may hinder to run UML on WSL?
>
> No idea.
> Can you try? I don't have access to a Windows 10 system right now
> where I could test.

Sadly, UML executable bails out very early. it Looks like WSL is  
missing some PTRACE stuff:

thomas@DESKTOP-DQBDJ0U:/mnt/c/Users/thomas/Downloads$ ./linux
Core dump limits :
         soft - NONE
         hard - NONE
Checking that ptrace can change system call numbers...check_ptrace:  
PTRACE_OLDSETOPTIONS failed: Invalid Argument

>
> --
> Thanks,
> //richard
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] warning at vma_merge

[Anton I. <ant...@ko...>]

Have a look at the list archive, this was covered a couple of weeks ago.

I believe Richard is working on a fix.

A.

On 07/05/17 21:06, Thomas Meyer wrote:
> Hi,
>
> with the current rw/linux-next I see a lot of those:
>
> Mai 07 22:01:34 bifrst kernel: ------------[ cut here ]------------
> Mai 07 22:01:34 bifrst kernel: WARNING: CPU: 0 PID: 505 at mm/mmap.c:1112 vma_merge+0x323/0x3c0
> Mai 07 22:01:34 bifrst kernel: Modules linked in:
> Mai 07 22:01:34 bifrst kernel: CPU: 0 PID: 505 Comm: less Tainted: G        W       4.11.0-00006-gce45860 #279
> Mai 07 22:01:34 bifrst kernel: Stack:
> Mai 07 22:01:34 bifrst kernel:  9e69da50 600c5bf4 00000009 00000000
> Mai 07 22:01:34 bifrst kernel:  6015c8e6 00000000 9e69da60 604f536c
> Mai 07 22:01:34 bifrst kernel:  9e69dac0 600671ae 45800000000 601a38d3
> Mai 07 22:01:34 bifrst kernel: Call Trace:
> Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] ? vma_merge+0x323/0x3c0
> Mai 07 22:01:34 bifrst kernel:  [<6015c8e6>] ? printk+0x0/0x94
> Mai 07 22:01:34 bifrst kernel:  [<60044ac9>] show_stack+0x129/0x190
> Mai 07 22:01:34 bifrst kernel:  [<600c5bf4>] ? dump_stack_print_info+0xe4/0xf0
> Mai 07 22:01:34 bifrst kernel:  [<6015c8e6>] ? printk+0x0/0x94
> Mai 07 22:01:34 bifrst kernel:  [<604f536c>] dump_stack+0x2a/0x2e
> Mai 07 22:01:34 bifrst kernel:  [<600671ae>] __warn+0x11e/0x150
> Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] ? vma_merge+0x323/0x3c0
> Mai 07 22:01:34 bifrst kernel:  [<6006732f>] warn_slowpath_null+0x1f/0x30
> Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] vma_merge+0x323/0x3c0
> Mai 07 22:01:34 bifrst kernel:  [<601a5140>] ? may_expand_vm+0x0/0x170
> Mai 07 22:01:34 bifrst kernel:  [<601a781d>] mprotect_fixup+0x14d/0x2e0
> Mai 07 22:01:34 bifrst kernel:  [<601de54c>] setup_arg_pages+0x10c/0x470
> Mai 07 22:01:34 bifrst kernel:  [<6083cb34>] ? _raw_spin_unlock+0x34/0x40
> Mai 07 22:01:34 bifrst kernel:  [<604fe410>] ? memcmp+0x0/0x50
> Mai 07 22:01:34 bifrst kernel:  [<60837704>] ? mutex_unlock+0x14/0x20
> Mai 07 22:01:34 bifrst kernel:  [<602545aa>] load_elf_binary+0x47a/0xfe0
> Mai 07 22:01:34 bifrst kernel:  [<600ba966>] ? lock_release+0x736/0x7f0
> Mai 07 22:01:34 bifrst kernel:  [<600ba1e3>] ? lock_acquire+0x203/0x250
> Mai 07 22:01:34 bifrst kernel:  [<600b4c3e>] ? lock_acquired+0x4ae/0x530
>
> any idea what is going on here?
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
>

[uml-devel] warning at vma_merge

[Thomas M. <th...@m3...>]

Hi,

with the current rw/linux-next I see a lot of those:

Mai 07 22:01:34 bifrst kernel: ------------[ cut here ]------------
Mai 07 22:01:34 bifrst kernel: WARNING: CPU: 0 PID: 505 at mm/mmap.c:1112 vma_merge+0x323/0x3c0
Mai 07 22:01:34 bifrst kernel: Modules linked in:
Mai 07 22:01:34 bifrst kernel: CPU: 0 PID: 505 Comm: less Tainted: G        W       4.11.0-00006-gce45860 #279
Mai 07 22:01:34 bifrst kernel: Stack:
Mai 07 22:01:34 bifrst kernel:  9e69da50 600c5bf4 00000009 00000000
Mai 07 22:01:34 bifrst kernel:  6015c8e6 00000000 9e69da60 604f536c
Mai 07 22:01:34 bifrst kernel:  9e69dac0 600671ae 45800000000 601a38d3
Mai 07 22:01:34 bifrst kernel: Call Trace:
Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] ? vma_merge+0x323/0x3c0
Mai 07 22:01:34 bifrst kernel:  [<6015c8e6>] ? printk+0x0/0x94
Mai 07 22:01:34 bifrst kernel:  [<60044ac9>] show_stack+0x129/0x190
Mai 07 22:01:34 bifrst kernel:  [<600c5bf4>] ? dump_stack_print_info+0xe4/0xf0
Mai 07 22:01:34 bifrst kernel:  [<6015c8e6>] ? printk+0x0/0x94
Mai 07 22:01:34 bifrst kernel:  [<604f536c>] dump_stack+0x2a/0x2e
Mai 07 22:01:34 bifrst kernel:  [<600671ae>] __warn+0x11e/0x150
Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] ? vma_merge+0x323/0x3c0
Mai 07 22:01:34 bifrst kernel:  [<6006732f>] warn_slowpath_null+0x1f/0x30
Mai 07 22:01:34 bifrst kernel:  [<601a38d3>] vma_merge+0x323/0x3c0
Mai 07 22:01:34 bifrst kernel:  [<601a5140>] ? may_expand_vm+0x0/0x170
Mai 07 22:01:34 bifrst kernel:  [<601a781d>] mprotect_fixup+0x14d/0x2e0
Mai 07 22:01:34 bifrst kernel:  [<601de54c>] setup_arg_pages+0x10c/0x470
Mai 07 22:01:34 bifrst kernel:  [<6083cb34>] ? _raw_spin_unlock+0x34/0x40
Mai 07 22:01:34 bifrst kernel:  [<604fe410>] ? memcmp+0x0/0x50
Mai 07 22:01:34 bifrst kernel:  [<60837704>] ? mutex_unlock+0x14/0x20
Mai 07 22:01:34 bifrst kernel:  [<602545aa>] load_elf_binary+0x47a/0xfe0
Mai 07 22:01:34 bifrst kernel:  [<600ba966>] ? lock_release+0x736/0x7f0
Mai 07 22:01:34 bifrst kernel:  [<600ba1e3>] ? lock_acquire+0x203/0x250
Mai 07 22:01:34 bifrst kernel:  [<600b4c3e>] ? lock_acquired+0x4ae/0x530

any idea what is going on here?

Re: [uml-devel] [uml-user] UML on WSL

[Richard W. <ric...@gm...>]

Thomas,

On Sun, May 7, 2017 at 1:44 PM, Thomas Meyer <th...@m3...> wrote:
> Hi,
>
> Did anybody try to run UML on the new Windows 10 subsystem for Linux? I
> wonder what missing functions may hinder to run UML on WSL?

No idea.
Can you try? I don't have access to a Windows 10 system right now
where I could test.

-- 
Thanks,
//richard

Re: [uml-devel] [uml:linux-next 2/5] arch/um/os-Linux/skas/process.c:236:19: error: 'NR_CPUS' undeclared here (not in a function)

[Richard W. <ri...@no...>]

Am 04.05.2017 um 03:19 schrieb kbuild test robot:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
> head:   5b4236e17cc1bd9fa14b2b0c7a4ae632d41f2e20
> commit: 8bba077066d6d0a135b7be1970691522075bf905 [2/5] um: Set number of CPUs
> config: um-x86_64_defconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 8bba077066d6d0a135b7be1970691522075bf905
>         # save the attached .config to linux build tree
>         make ARCH=um SUBARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/um/os-Linux/skas/process.c:236:19: error: 'NR_CPUS' undeclared here (not in a function)
>     int userspace_pid[NR_CPUS];

Fix is already in UML next.

Thanks,
//richard

[uml-devel] [uml:linux-next 2/5] arch/um/os-Linux/skas/process.c:236:19: error: 'NR_CPUS' undeclared here (not in a function)

[kbuild t. r. <fen...@in...>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
head:   5b4236e17cc1bd9fa14b2b0c7a4ae632d41f2e20
commit: 8bba077066d6d0a135b7be1970691522075bf905 [2/5] um: Set number of CPUs
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 8bba077066d6d0a135b7be1970691522075bf905
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

All errors (new ones prefixed by >>):

>> arch/um/os-Linux/skas/process.c:236:19: error: 'NR_CPUS' undeclared here (not in a function)
    int userspace_pid[NR_CPUS];
                      ^~~~~~~

vim +/NR_CPUS +236 arch/um/os-Linux/skas/process.c

abaf6977 Gennady Sharapov 2006-01-18  230  	}
abaf6977 Gennady Sharapov 2006-01-18  231  
512b6fb1 Jeff Dike        2007-10-16  232  	kill(os_getpid(), SIGSTOP);
ba180fd4 Jeff Dike        2007-10-16  233  	return 0;
abaf6977 Gennady Sharapov 2006-01-18  234  }
abaf6977 Gennady Sharapov 2006-01-18  235  
abaf6977 Gennady Sharapov 2006-01-18 @236  int userspace_pid[NR_CPUS];
abaf6977 Gennady Sharapov 2006-01-18  237  
abaf6977 Gennady Sharapov 2006-01-18  238  int start_userspace(unsigned long stub_stack)
abaf6977 Gennady Sharapov 2006-01-18  239  {

:::::: The code at line 236 was first introduced by commit
:::::: abaf69773d8dda98b917d94c07757f6520da7bec [PATCH] uml: move libc-dependent skas process handling

:::::: TO: Gennady Sharapov <Gen...@in...>
:::::: CC: Linus Torvalds <tor...@g5...>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [uml-devel] [uml-user] [PATCH] um: Fix _print_addr()

[Richard W. <ric...@gm...>]

On Sun, Dec 25, 2016 at 11:11 PM, Richard Weinberger <ri...@no...> wrote:
> Recent changes to printk() broke UML's stack trace
> output. Kill the root of the problem by using a single
> printk() statement.
>
> Signed-off-by: Richard Weinberger <ri...@no...>
> ---
>  arch/um/kernel/sysrq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index aa1b56f5ac68..18eddf677ec6 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -17,10 +17,8 @@
>
>  static void _print_addr(void *data, unsigned long address, int reliable)
>  {
> -       pr_info(" [<%08lx>]", address);
> -       pr_cont(" %s", reliable ? "" : "? ");
> -       print_symbol("%s", address);
> -       pr_cont("\n");
> +       pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> +               (void *)address);
>  }
>
>  static const struct stacktrace_ops stackops = {

Applied.

-- 
Thanks,
//richard

Re: [uml-devel] [PATCH v2] um: Set number of CPUs

[Richard W. <ric...@gm...>]

On Fri, Mar 3, 2017 at 9:11 AM, Richard Weinberger <ri...@no...> wrote:
> Nikola,
>
> Am 02.03.2017 um 14:16 schrieb Nikola Kotur:
>> Define NR_CPUS required by the timer subsystem.
>>
>> Fixes this make warning:
>>
>>     scripts/kconfig/conf  --oldconfig arch/x86/um/Kconfig
>>     kernel/time/Kconfig:155:warning: range is invalid
>>
>> Signed-off-by: Nikola Kotur <ko...@gm...>
>
> Looks good!
>
> Thanks,
> //richard
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> User-mode-linux-devel mailing list
> Use...@li...
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Applied.

-- 
Thanks,
//richard

Re: [uml-devel] [PATCH] um: Fix PTRACE_POKEUSER on x86_64

[Richard W. <ric...@gm...>]

On Sat, Apr 1, 2017 at 12:41 AM, Richard Weinberger <ri...@no...> wrote:
> This is broken since ever but sadly nobody noticed.
> Recent versions of GDB set DR_CONTROL unconditionally and
> UML dies due to a heap corruption. It turns out that
> the PTRACE_POKEUSER was copy&pasted from i386 and assumes
> that addresses are 4 bytes long.
>
> Fix that by using 8 as address size in the calculation.
>
> Cc: <st...@vg...>
> Reported-by: jie cao <cj...@gm...>
> Signed-off-by: Richard Weinberger <ri...@no...>
> ---
>  arch/x86/um/ptrace_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/ptrace_64.c b/arch/x86/um/ptrace_64.c
> index a5c9910d234f..09a085bde0d4 100644
> --- a/arch/x86/um/ptrace_64.c
> +++ b/arch/x86/um/ptrace_64.c
> @@ -125,7 +125,7 @@ int poke_user(struct task_struct *child, long addr, long data)
>         else if ((addr >= offsetof(struct user, u_debugreg[0])) &&
>                 (addr <= offsetof(struct user, u_debugreg[7]))) {
>                 addr -= offsetof(struct user, u_debugreg[0]);
> -               addr = addr >> 2;
> +               addr = addr >> 3;
>                 if ((addr == 4) || (addr == 5))
>                         return -EIO;
>                 child->thread.arch.debugregs[addr] = data;

Applied.

-- 
Thanks,
//richard

Re: [uml-devel] [PATCH] um: Include kbuild.h instead of duplicating its macros

[Richard W. <ric...@gm...>]

On Mon, Apr 3, 2017 at 9:54 PM, Matthias Kaehlcke <mk...@ch...> wrote:
> Signed-off-by: Matthias Kaehlcke <mk...@ch...>
> ---
>  arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
>  #include <linux/sched.h>
>  #include <linux/elf.h>
>  #include <linux/crypto.h>
> +#include <linux/kbuild.h>
>  #include <asm/mman.h>
>
> -#define DEFINE(sym, val) \
> -       asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> -       DEFINE(sym, offsetof(struct str, mem));
> -
>  void foo(void)
>  {
>  #include <common-offsets.h>
> --
> 2.12.2.564.g063fe858b8-goog
>

Applied.

-- 
Thanks,
//richard

Re: [uml-devel] [PATCH] um: Fix to call read_initrd after init_bootmem

[Richard W. <ric...@gm...>]

On Thu, Apr 27, 2017 at 5:15 AM, Masami Hiramatsu <mhi...@ke...> wrote:
> Since read_initrd() invokes alloc_bootmem() for allocating
> memory to load initrd image, it must be called after init_bootmem.
>
> This makes read_initrd() called directly from setup_arch()
> after init_bootmem() and mem_total_pages().
>
> Signed-off-by: Masami Hiramatsu <mhi...@ke...>
> ---
>  arch/um/kernel/initrd.c  |    4 +---
>  arch/um/kernel/um_arch.c |    6 ++++++
>  2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/um/kernel/initrd.c b/arch/um/kernel/initrd.c
> index 48bae81..6f6e789 100644
> --- a/arch/um/kernel/initrd.c
> +++ b/arch/um/kernel/initrd.c
> @@ -14,7 +14,7 @@
>  static char *initrd __initdata = NULL;
>  static int load_initrd(char *filename, void *buf, int size);
>
> -static int __init read_initrd(void)
> +int __init read_initrd(void)
>  {
>         void *area;
>         long long size;
> @@ -46,8 +46,6 @@ static int __init read_initrd(void)
>         return 0;
>  }
>
> -__uml_postsetup(read_initrd);
> -
>  static int __init uml_initrd_setup(char *line, int *add)
>  {
>         initrd = line;
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index 4b85acd..64a1fd0 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -338,11 +338,17 @@ int __init linux_main(int argc, char **argv)
>         return start_uml();
>  }
>
> +int __init __weak read_initrd(void)
> +{
> +       return 0;
> +}
> +
>  void __init setup_arch(char **cmdline_p)
>  {
>         stack_protections((unsigned long) &init_thread_info);
>         setup_physmem(uml_physmem, uml_reserved, physmem_size, highmem);
>         mem_total_pages(physmem_size, iomem_size, highmem);
> +       read_initrd();
>
>         paging_init();
>         strlcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
>

Applied.

-- 
Thanks,
//richard

Re: [uml-devel] [PATCH] um: Fix to call read_initrd after init_bootmem

[Richard W. <ri...@no...>]

Masami,

Am 28.04.2017 um 00:40 schrieb Masami Hiramatsu:
> Finally, git bisect shows that below commit caused this issue.
> 
> b63236972e1344b247750451e2be0a06cd125f21 is the first bad commit
> commit b63236972e1344b247750451e2be0a06cd125f21
> Author: Richard Weinberger <ri...@no...>

Meh, it's always me. ;-)

> 
> For the stable, any kernel later than v4.8 has this issue.

Thanks,
//richard

Re: [uml-devel] [PATCH] um: Fix to call read_initrd after init_bootmem

[Richard W. <ri...@no...>]

Masami,

Am 27.04.2017 um 05:15 schrieb Masami Hiramatsu:
> Since read_initrd() invokes alloc_bootmem() for allocating
> memory to load initrd image, it must be called after init_bootmem.
> 
> This makes read_initrd() called directly from setup_arch()
> after init_bootmem() and mem_total_pages().

Thanks for fixing this! Did you figure since when this is broken?
I think that should go into -stable.

Thanks,
//richard

Re: [uml-devel] [PATCH] um: Include kbuild.h instead of duplicating its macros

[Richard W. <ri...@no...>]

Matthias,

Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
> 
>> Signed-off-by: Matthias Kaehlcke <mk...@ch...>
>> ---
>>  arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>>  1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> @@ -2,16 +2,9 @@
>>  #include <linux/sched.h>
>>  #include <linux/elf.h>
>>  #include <linux/crypto.h>
>> +#include <linux/kbuild.h>
>>  #include <asm/mman.h>
>>  
>> -#define DEFINE(sym, val) \
>> -	asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>> -
>> -#define BLANK() asm volatile("\n->" : : )
>> -
>> -#define OFFSET(sym, str, mem) \
>> -	DEFINE(sym, offsetof(struct str, mem));
>> -
>>  void foo(void)
>>  {
>>  #include <common-offsets.h>
>> -- 
> 
> Ping, any comment on this patch?

Looks good, nothing exploded while a quick test.
I'll queue it for the next merge window. :-)

Thanks,
//richard

Re: [uml-devel] [PATCH] um: use KERN_CONT in stack dump

[Vegard N. <veg...@gm...>]

On 12 March 2017 at 10:47, Vegard Nossum <veg...@or...> wrote:
> On 12/03/2017 10:45, Richard Weinberger wrote:
>> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
>> index aa1b56f5ac68..18eddf677ec6 100644
>> --- a/arch/um/kernel/sysrq.c
>> +++ b/arch/um/kernel/sysrq.c
>> @@ -17,10 +17,8 @@
>>
>>  static void _print_addr(void *data, unsigned long address, int reliable)
>>  {
>> -       pr_info(" [<%08lx>]", address);
>> -       pr_cont(" %s", reliable ? "" : "? ");
>> -       print_symbol("%s", address);
>> -       pr_cont("\n");
>> +       pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ",
>> +               (void *)address);
>>  }
>
> Tested-by: Vegard Nossum <veg...@or...>

Just a heads up, this still appears unfixed in Linus's repo.


Vegard