Re: [uml-devel] [PATCH 1/2] um: vector: Fix a memory allocation check

[Anton I. <ant...@ko...>]

Thanks, looks correct, +1

Richard, can you add it to the next pull.

Thanks in advance,

A.

On 27/01/18 10:53, Christophe JAILLET wrote:
> Checking the result of the previous 'kstrdup()' call is expected here, so
> we should test 'params' and not 'str' (which is known to be non-NULL at
> this point)
>
> Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
> Signed-off-by: Christophe JAILLET <chr...@wa...>
> ---
>  arch/um/drivers/vector_kern.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index d1d53015d572..3c1e6ad91016 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -723,7 +723,7 @@ static int vector_config(char *str, char **error_out)
>  	 */
>  
>  	params = kstrdup(params, GFP_KERNEL);
> -	if (str == NULL) {
> +	if (params == NULL) {
>  		*error_out = "vector_config failed to strdup string";
>  		return -ENOMEM;
>  	}