Re: [uml-devel] [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open()

[Richard W. <ric...@gm...>]

On Sun, Jan 10, 2016 at 6:13 AM, Peter Hurley <pe...@hu...> wrote:
> Evaluate the conditions which prevent this tty being the controlling
> terminal in one place, just before setting the controlling terminal.
>
> Signed-off-by: Peter Hurley <pe...@hu...>
> ---
>  drivers/tty/tty_io.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)

Peter,

This commit breaks existing userspace.
I noticed that on UserModeLinux with Debian Squeeze as userspace, getty does not
give me a controlling tty upon login.
It does not seem to happen on newer distros. But still this needs
further investigation.

Please me know what debug information you need.

-- 
Thanks,
//richard