Re: [uml-devel] [PATCH] um: handle GCC 5.x like GCC 4.x

[Richard W. <ric...@gm...>]

On Sun, May 24, 2015 at 3:23 PM, Hans-Werner Hilse <hw...@gm...> wrote:
> Compiler compatibility macros were conditionally defined based on
> the compiler version. The it tested __GNUC__, but compared it to
> a maximum value of 4, breaking compilation on now current GCC 5.x.
> Thus, the check is extended to check for version 4.x and beyond.
>
> Signed-off-by: Hans-Werner Hilse <hw...@gm...>
> ---
>  arch/um/include/shared/init.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/include/shared/init.h b/arch/um/include/shared/init.h
> index b3906f8..ecdec48 100644
> --- a/arch/um/include/shared/init.h
> +++ b/arch/um/include/shared/init.h
> @@ -54,7 +54,7 @@ typedef void (*exitcall_t)(void);
>  #endif
>
>  #else
> -#if __GNUC__ == 4
> +#if __GNUC__ >= 4
>  # define __used                        __attribute__((__used__))
>  #endif
>  #endif

Hmm, instead of continue with that hack it would be much nicer to get rid
of the copy&pasted __user define.

-- 
Thanks,
//richard