Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support

[Daniel W. <sa...@0x...>]

----- Original Message -----
> From: "Thomas Meyer" <th...@m3...>
> To: "user-mode-linux-devel" <use...@li...>
> Sent: Sunday, October 19, 2014 4:14:13 PM
> Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
> 
> Add TRACE_IRQFLAGS_SUPPORT to UML.
> This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.


FYI: I'm currently working on porting ftrace() support to
uml. It will take another week or two since I don't have enough
time to debug, and it isn't stable yet (read as is panic()ing randomly)


> 
> Signed-off-by: Thomas Meyer <th...@m3...>
> ---
> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> index 87bc868..6a33c3a 100644
> --- a/arch/um/Kconfig.common
> +++ b/arch/um/Kconfig.common
> @@ -28,10 +28,9 @@ config PCI
>  config PCMCIA
>  	bool
>  
> -# Yet to do!
>  config TRACE_IRQFLAGS_SUPPORT
>  	bool
> -	default n
> +	default y
>  
>  config LOCKDEP_SUPPORT
>  	bool
> diff --git a/arch/um/include/asm/irqflags.h
> b/arch/um/include/asm/irqflags.h
> index c780d8a..c5b636e 100644
> --- a/arch/um/include/asm/irqflags.h
> +++ b/arch/um/include/asm/irqflags.h
> @@ -34,9 +34,9 @@ static inline unsigned long
> arch_local_irq_save(void)
>  	return flags;
>  }
>  
> -static inline bool arch_irqs_disabled(void)
> +static inline int arch_irqs_disabled_flags(unsigned long flags)
>  {
> -	return arch_local_save_flags() == 0;
> +	return flags == 0;
>  }
>  
>  #endif

I'm not sure if this is correct. I'd rather would have another function
implemented instead of removing the check for disabled irqs.


cheers,

daniel