Re: [uml-devel] When opening /tmp/uml.ctl fails, what do we get?

[Jeff D. <jd...@ad...>]

On Thu, Feb 22, 2007 at 12:54:04AM +0100, Blaisorblade wrote:
> Looking into the code, I saw that:
> 1) daemon_user_init is confusing because it saved any error into pri->fd, 
> instead of returning it to the caller. 

Yup.

> Also, it would make sense to move this into daemon_open.

The current behavior is on purpose.  The thinking is that device
initialization is equivalent to plugging a box into a switch.  The
device isn't up (and the box might in fact be turned off).  Bringing
the interface up comes later, as a separate step.

You may be right, and we can talk about it, but the current code is no
accident.

> 2) connect_to_switch uses the same errno twice - it shouldn't, and we're 
> hitting this. um_interrupt is called with fd => 0 because errno is cleared 
> after printk (verified under debugging, I did not trace it fully to where 
> it's changing but it's sufficient for a patch anyway).

We've seen this before, and I thought I made a pass over all of UML
and fixed everything.  Sigh.

				Jeff

-- 
Work email - jdike at linux dot intel dot com