#99 urjtag dependencies missing autoconf checks

[Erik Smit]

The current SVN revision (1653) has dependencies which, when missing, result in non-obvious compilation failures.

If the machine is missing flex, or you try to build with --disable-bsdl, it will fail with:

Making all in po
make[2]: Entering directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/po'
make urjtag.pot-update
make[3]: Entering directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/po'
make[3]: *** No rule to make target `../src/bsdl/bsdl_bison.c', needed by `urjtag.pot-update'. Stop.
make[3]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/po'
make[2]: *** [urjtag.pot] Error 2
make[2]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/po'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work'
make: *** [all] Error 2

If you have flex, but not yacc, it will fail with:
Making all in svf
make[3]: Entering directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/svf'
test -f svf_bison.c || /bin/sh ../../tools/ylwrap svf_bison.y y.tab.c svf_bison.c y.tab.h svf_bison.h y.output svf_bison.output -- yacc -d
../../tools/ylwrap: line 111: yacc: command not found
make[3]: *** [svf_bison.c] Error 1
make[3]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/svf'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work'
make: *** [all] Error 2

If you have flex and yacc, but not bison, it will fail with:

Making all in svf
make[3]: Entering directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/svf'
test -f svf_bison.c || /bin/sh ../../tools/ylwrap svf_bison.y y.tab.c svf_bison.c y.tab.h svf_bison.h y.output svf_bison.output -- byacc -d
byacc: e - line 27 of "/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/svf/svf_bison.y", syntax error
%pure-parser
^
make[3]: *** [svf_bison.c] Error 1
make[3]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/svf'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work'
make: *** [all] Error 2

If you are missing the headers for libreadline, it will fail with:

Making all in src/apps/jtag
make[2]: Entering directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/apps/jtag'
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../.. -I../../../include/urjtag -DLOCALEDIR=\"/usr/local/share/locale\" -I../../.. -I../../../include -Wall -Wmissing-prototypes -Wstrict-prototypes -Wpointer-arith -Werror -g -O2 -MT jtag.o -MD -MP -MF .deps/jtag.Tpo -c -o jtag.o jtag.c
jtag.c:39:31: error: readline/readline.h: No such file or directory
cc1: warnings being treated as errors
jtag.c: In function 'urj_cmd_completion':
jtag.c:121: error: implicit declaration of function 'rl_completion_matches'
jtag.c:121: error: assignment makes pointer from integer without a cast
jtag.c: In function 'jtag_load_history':
jtag.c:135: error: implicit declaration of function 'using_history'
jtag.c:157: error: implicit declaration of function 'read_history'
jtag.c: In function 'jtag_save_history':
jtag.c:190: error: implicit declaration of function 'write_history'
jtag.c: In function 'jtag_readline_loop':
jtag.c:247: error: 'HIST_ENTRY' undeclared (first use in this function)
jtag.c:247: error: (Each undeclared identifier is reported only once
jtag.c:247: error: for each function it appears in.)
jtag.c:247: error: 'hptr' undeclared (first use in this function)
jtag.c:257: error: implicit declaration of function 'readline'
jtag.c:257: error: assignment makes pointer from integer without a cast
jtag.c:273: error: 'history_length' undeclared (first use in this function)
jtag.c:274: error: implicit declaration of function 'add_history'
jtag.c:277: error: implicit declaration of function 'history_get'
jtag.c: In function 'main':
jtag.c:566: error: 'rl_attempted_completion_function' undeclared (first use in this function)
make[2]: *** [jtag.o] Error 1
make[2]: Leaving directory `/home/zoiah/tmp/urjtag/trunk/urjtag.work/src/apps/jtag'

Perhaps you can check for these things in the autoconf script? Especially the missing bison was rather non-obvious.

[Arnim Läuger]

Thanks for reporting!
I've addressed the first issue with SVN r1657. The others will follow.

[Mike Frysinger]

readline checks are already in there. you'll need to post actual log files (like config.log) if they arent working for you.

[Geert Stappers]

Lowered priority from 5 to 7 due text in ticket saying something about partial fix.