Re: [Unichrome-devel] Crashing bug in CVS.

[Ivor H. <iv...@iv...>]

Luc Verhaegen wrote:

>On Thu, Oct 28, 2004 at 01:14:27PM +0200, Luc Verhaegen wrote:
> =20
>
>>On Thu, Oct 28, 2004 at 09:17:48AM +0200, Thomas Hellstr=F6m wrote:
>>   =20
>>
>>>Hi!
>>>
>>>We have a bug in our CVS that crashes the computer solid when X is
>>>terminated or even reset (upon logout). Haven't started tracking yet.
>>>
>>>/Thomas
>>>
>>>     =20
>>>
>>Yes, I've been seeing this too while testing bad mode handling (Pieter=20
>>Peers dug it up).=20
>>
>>I've not forgotten about this, in fact, the quite safe=20
>>clean_Save_and_Restore tag is a direct result of testing this.
>>
>>The way i now have things done semi-cleanly is by having VIARestore
>>free pVia and subsequently having X segfault on me. This surely is not
>>good.
>>
>>The rest of cleaning this up is done by moving FindModeUseBIOSTable=20
>>into ValidMode, removal of the FreeRecs and moving FindMode before=20
>>vgaHWInit in WriteMode. At first X reverted to lower colour depths, but=
=20
>>after removal of those from the config, the box hardlocks again.
>>
>>How about undocumented options like noDRI, noXV? Those would enable us=20
>>to quickly isolate problems (like with XAA on x86-64).
>>
>>Luc Verhaegen.
>>
>>   =20
>>
>Well, well. Of course i saw it when while testing bad mode handling. I=20
>introduced it while testing bad mode handling:
>
>VIARegRec Regs =3D pVia->SavedReg;
>Regs.SR14 =3D hwp->readSeq(hwp, 0x14);
>
>leaves pVia->SavedReg.SR14 still uninitialised. Regs is a copy of=20
>SavedRegs, not a reference to... And libv is an utter idiot.
>
>Anyway, this (of course) fixes all the hardlocking, and makes the rest=20
>of the bad mode handling working nicely. The ScreenInit handling is=20
>very solid now, but, the driver should not refuse a mode any more after=20
>PreInit as FindModeUseBIOSTable is now also called from ValidMode.
>
>Certainly not as clean or versatile as free modes, but the next best=20
>thing possible with modetables.
>
>Anyway, resuming release, even though i doubt that i'll be able to=20
>finish this this morning.
>
>Luc Verhaegen.
>
Yay star. Nice one Luc.