twiki-dev — TWiki core SVN commit notices

[TWiki-Dev] [SVN] HideyoImazu r30286 - in twiki/trunk/ExcelImportExportPlugin: data/TWiki lib/TWiki/Plugins lib/TWiki/Plugins/ExcelImportExportPlugin

[<de...@de...>]

Author: HideyoImazu
Date: 2016-12-12 23:57:03 +0000 (Mon, 12 Dec 2016)
New Revision: 30286
Trac url: http://develop.twiki.org/trac/changeset/30286

Modified:
   twiki/trunk/ExcelImportExportPlugin/data/TWiki/ExcelImportExportPlugin.txt
   twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin.pm
   twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin/Export.pm
Log:
Item7763: table2excel of ExcelImportExportPlugin to be able to supress the config sheet

Modified: twiki/trunk/ExcelImportExportPlugin/data/TWiki/ExcelImportExportPlugin.txt
===================================================================
--- twiki/trunk/ExcelImportExportPlugin/data/TWiki/ExcelImportExportPlugin.txt	2016-11-22 07:33:18 UTC (rev 30285)
+++ twiki/trunk/ExcelImportExportPlugin/data/TWiki/ExcelImportExportPlugin.txt	2016-12-12 23:57:03 UTC (rev 30286)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1473929367" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1481534952" format="1.1" version="$Rev$"}%
 ---+ <nop>ExcelImportExportPlugin
 <!--
    Contributions to this plugin are appreciated. Please update the plugin page at
@@ -73,6 +73,7 @@
    <tr><td> =&amp;#124;= </td><td> &#124; </td></tr>\
    </table> | off |
    | =scale="..."= | The print scale factor of the resulting spreadsheet.  | 100 |
+   | =configsheet="off"= | Usually, the TWiki form definition used for the spreadsheet generation is put to the !Sheet2 of the resulting Excel workbook. You may need to avoid having the sheet, in which case you specify =configsheet="off"= parameter. | on |
 
    * Syntax: =%SCRIPTURL{"topics2excel"}%=
    * Synopsis: Generates an Excel 2003 spreadsheet file from the topics which have the designated form, such that each topic will result in a row of the generated spreadsheet and where the fields of the form indicate the columns of the spreadsheet. 
@@ -154,12 +155,19 @@
 
 ---++ Plugin Info
 
+%TABLE{ tablewidth="100%" columnwidths="170," }%
 |  Plugin Author: | TWiki:Main.ThomasWeigert, based on code by TWiki:Main.ClausLanghans |
 |  Copyright: | &copy; 2001-2016 %SYSTEMWEB%.TWikiContributor %BR% &copy; 2006 Motorola TWiki:Main.ThomasWeigert %BR% &copy; 2006 TWiki:Main.ClausLanghans |
 |  License: | GPL ([[http://www.gnu.org/copyleft/gpl.html][GNU General Public License]]) |
-|  Plugin Version: | 2016-09-15 |
-|  Change History: | <!-- versions below in reverse order -->&nbsp; |
-|  2016-09-15: | TWikibug:Item7758: some html2text="on" shortcomings are taken care of -- TWki:Main.HideyoImazu |
+|  Plugin Version: | 2016-12-12 |
+%TWISTY{
+ mode="div"
+ showlink="Show Change History %ICONURL{toggleopen}%"
+ hidelink="Hide Change History %ICONURL{toggleclose}% "
+}%
+%TABLE{ tablewidth="100%" columnwidths="170," }%
+|  2016-12-12: | TWikibug:Item7763: table2excel to be able to suppress the config sheet -- TWiki:Main.HideyoImazu |
+|  2016-09-15: | TWikibug:Item7758: some html2text="on" shortcomings are taken care of -- TWiki:Main.HideyoImazu |
 |  2016-09-12: | TWikibug:Item7756: =number= type support -- TWki:Main.HideyoImazu |
 |  2016-06-22: | TWikibug:Item7703: Fix bug in manifest (Config.spec missing) -- TWiki:Main.PeterThoeny |
 |  2015-05-29: | TWikibug:Item7604: Switch from GPL v2 to v3 |
@@ -172,6 +180,8 @@
 |  July 2008: | 4.2.x compatibility, Update Topic data from changed Form definition. - TWiki:Main.SvenDowideit |
 |  04 Nov 2006: | Added abilty to upload spreadsheet. Rewritten for consistency and made more resilient. Enhanced documentation. |
 |  13 Aug 2006: | Initial version |
+%ENDTWISTY%
+%TABLE{ tablewidth="100%" columnwidths="170," }%
 |  Dependencies: | %$DEPENDENCIES% |
 |  Other Dependencies: | none |
 |  Perl Version: | 5.005 |

Modified: twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin/Export.pm
===================================================================
--- twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin/Export.pm	2016-11-22 07:33:18 UTC (rev 30285)
+++ twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin/Export.pm	2016-12-12 23:57:03 UTC (rev 30286)
@@ -128,10 +128,11 @@
 
     # Add a worksheet
     my $worksheet   = $workbook->add_worksheet();
-    my $configsheet = $workbook->add_worksheet();
+    my $configsheet;
+    if ( TWiki::Func::isTrue($query->param('configsheet'), 1) ) {
+        $configsheet = $workbook->add_worksheet();
+    }
 
-    #$configsheet->hide();
-
     # Set parameters of the worksheet
     $worksheet->freeze_panes( 1, 0 );
     $worksheet->set_margins(0);    #
@@ -344,12 +345,14 @@
                 $worksheet->set_column( $col, $col, $horizontalcolwidth );
             }
         }
-        $configsheet->write( $row,     $col, $name,             $headerformat );
-        $configsheet->write( $row + 1, $col, $shortname{$name}, $normalformat );
-        $configsheet->write( $row + 2, $col, $orientation{$name},
-            $normalformat );
-        $configsheet->write( $row + 3, $col, $width{$name}, $normalformat );
-        $configsheet->write( $row + 4, $col, $type{$name},  $normalformat );
+        if ( $configsheet ) {
+            $configsheet->write( $row,     $col, $name,             $headerformat );
+            $configsheet->write( $row + 1, $col, $shortname{$name}, $normalformat );
+            $configsheet->write( $row + 2, $col, $orientation{$name},
+                $normalformat );
+            $configsheet->write( $row + 3, $col, $width{$name}, $normalformat );
+            $configsheet->write( $row + 4, $col, $type{$name},  $normalformat );
+        }
         $col++;
     }
 
@@ -559,10 +562,11 @@
 
     # Add a worksheet
     my $worksheet   = $workbook->add_worksheet();
-    my $configsheet = $workbook->add_worksheet();
+    my $configsheet;
+    if ( TWiki::Func::isTrue($query->param('configsheet'), 1) ) {
+        $configsheet = $workbook->add_worksheet();
+    }
 
-    #$configsheet->hide();
-
     # Set parameters of the worksheet
     $worksheet->freeze_panes( 1, 0 );
     $worksheet->set_margins(0);    #
@@ -782,12 +786,14 @@
                 $worksheet->set_column( $col, $col, $horizontalcolwidth );
             }
         }
-        $configsheet->write( $row,     $col, $name,             $headerformat );
-        $configsheet->write( $row + 1, $col, $shortname{$name}, $normalformat );
-        $configsheet->write( $row + 2, $col, $orientation{$name},
-            $normalformat );
-        $configsheet->write( $row + 3, $col, $width{$name}, $normalformat );
-        $configsheet->write( $row + 4, $col, $type{$name},  $normalformat );
+        if ( $configsheet ) {
+            $configsheet->write( $row,     $col, $name,             $headerformat );
+            $configsheet->write( $row + 1, $col, $shortname{$name}, $normalformat );
+            $configsheet->write( $row + 2, $col, $orientation{$name},
+                $normalformat );
+            $configsheet->write( $row + 3, $col, $width{$name}, $normalformat );
+            $configsheet->write( $row + 4, $col, $type{$name},  $normalformat );
+        }
         $col++;
     }
 

Modified: twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin.pm
===================================================================
--- twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin.pm	2016-11-22 07:33:18 UTC (rev 30285)
+++ twiki/trunk/ExcelImportExportPlugin/lib/TWiki/Plugins/ExcelImportExportPlugin.pm	2016-12-12 23:57:03 UTC (rev 30286)
@@ -95,7 +95,7 @@
     my $disabled = ref $ctx && ( $ctx->{inactive} || $ctx->{content_slave} );
 
     return
-"<form name=\"main\" enctype=\"multipart/form-data\" action=\"%SCRIPTURLPATH{\"uploadexcel\"}%/%WEB%/%TOPIC%\" method=\"post\"><input class=\"twikiInputField\" type=\"file\" name=\"filepath\" value=\"%FILEPATH%\" size=\"30\" /><input type=\"hidden\" value=\"$template\" name=\"template\" /><input type=\"hidden\" value=\"$uploadtopic\" name=\"uploadtopic\" /><input type=\"hidden\" name=\"filename\" value=\"%FILENAME%\" /> &nbsp; <input type=\"submit\" value=\"Upload excel\" $disabled/></form>";
+"<form name=\"main\" enctype=\"multipart/form-data\" action=\"%SCRIPTURLPATH{\"uploadexcel\"}%/%WEB%/%TOPIC%\" method=\"post\"><input class=\"twikiInputFileField\" type=\"file\" name=\"filepath\" value=\"%FILEPATH%\" size=\"30\" /><input type=\"hidden\" value=\"$template\" name=\"template\" /><input type=\"hidden\" value=\"$uploadtopic\" name=\"uploadtopic\" /><input type=\"hidden\" name=\"filename\" value=\"%FILENAME%\" /> &nbsp; <input class=\"twikiSubmit\" type=\"submit\" value=\"Upload excel\" $disabled/></form>";
 
 }
 
@@ -108,6 +108,7 @@
     my $dynamic     = $params->{dynamic}    || '';
     my $html2text   = $params->{html2text}  || '';
     my $scale       = $params->{scale}      || '';
+    my $configsheet = $params->{configsheet}|| 'on';
 
 ## SMELL: Parameter "topic" seems to serve no function
     return
@@ -119,7 +120,8 @@
 "<input type=\"hidden\" value=\"$dynamic\" name=\"dynamic\" />".
 "<input type=\"hidden\" value=\"$html2text\" name=\"html2text\" />".
 "<input type=\"hidden\" value=\"$scale\" name=\"scale\" />".
-"<input type=\"submit\" value=\"Export table\" />".
+"<input type=\"hidden\" value=\"$configsheet\" name=\"configsheet\" />".
+"<input type=\"submit\" value=\"Export table\" class=\"twikiSubmit\" />".
 "</form>";
 
 }

Re: [TWiki-Dev] Postpone this week's TWiki release meeting?

[Imazu, H. <Hid...@mo...>]

How about skipping the third week of Dec meeting? If we postpone the meeting by one week, it's in the holiday season.

-----Original Message-----
From: Peter Thoeny [mailto:pe...@th...] 
Sent: Monday, December 12, 2016 21:26
To: TWiki-Dev list for developers
Subject: [TWiki-Dev] Postpone this week's TWiki release meeting?

All:

I am in vacation in the mountains with limited internet access. Shall we postpone the meeting by one week? Alternatively you could go head with me if you like. In that case I'll send the invite as usual.

Cheers,
Peter


--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration 
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography Knowledge cannot be 
> managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi _______________________________________________
TWiki-Dev mailing list
TWi...@li...
https://lists.sourceforge.net/lists/listinfo/twiki-dev


--------------------------------------------------------------------------------

NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers  If you cannot access these links, please notify us by reply message and we will send the contents to you. By communicating with Morgan Stanley you consent to the foregoing and to the voice recording of conversations with personnel of Morgan Stanley.

[TWiki-Dev] Postpone this week's TWiki release meeting?

[Peter T. <pe...@th...>]

All:

I am in vacation in the mountains with limited internet access. Shall we postpone the meeting by one week? Alternatively you could go head with me if you like. In that case I'll send the invite as usual.

Cheers,
Peter


--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography
> Knowledge cannot be managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public

[TWiki-Dev] TWiki Kampala Release Meeting, 2016-12-01, 23:00 GMT

[Peter T. <pe...@th...>]

All:

Please join the TWiki Kampala Release Meeting, http://twiki.org/cgi-bin/view/Codev/KampalaReleaseMeeting2016x12x01 scheduled for 2016-12-01 23:00 GMT [1] on IRC channel #twiki_release on the irc.freenode.net IRC network [2] - in about 27 hours from now.

ATTENTION: +1h GMT change due to daylight savings time change in the USA!

Proposed agenda:

   1. Feature Requests for Kampala Release
   2. Review Urgent and Not So Urgent Bugs
   3. Extensions
   4. Miscellaneous

The meeting is on Thursday or Friday, depending on your time zone. Meeting time in different time zones, tomorrow:

   * USA Pacific Time Zone: 03:00pm on Thu
   * USA Eastern Time Zone: 06:00pm on Thu
   * Central Europe: 24:00 on Thu/Fri night
   * Japan: 08:00 on Fri

Please show up in time to save everybody's time. And remember that the release meeting is where decisions are made. We invite allTWiki.org contributors to join, as well as people with interest in the TWiki project in general.

Cheers,
Peter


[1]: http://www.timeanddate.com/worldclock/converter.html?iso=20161201T230000&p1=tz_gmt&p2=248&p3=268&p4=224&p5=179
[2]: http://twiki.org/cgi-bin/view/Codev/TWikiIRC


--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography
> Knowledge cannot be managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public

[TWiki-Dev] [SVN] HideyoImazu r30285 - twiki/branches/TWikiRelease06x00/core/data/TWiki

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-22 07:33:18 +0000 (Tue, 22 Nov 2016)
New Revision: 30285
Trac url: http://develop.twiki.org/trac/changeset/30285

Modified:
   twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
Log:
Item7700: minor document improvement

Modified: twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:31:57 UTC (rev 30284)
+++ twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:33:18 UTC (rev 30285)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1479797825" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479799846" format="1.1" version="$Rev$"}%
 %STARTINCLUDE%
 ---+ TWiki CGI and Command Line Scripts
 
@@ -59,7 +59,7 @@
 For the =save= script, special variables are available as below:
 
 | *Parameter* | *Value* |
-| =$web= and =$topic= | The names of the web/topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
+| =$web= and =$topic= | The names of the web/topic of the topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
 | =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
 
 #AttachScript

[TWiki-Dev] [SVN] HideyoImazu r30284 - twiki/trunk/core/data/TWiki

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-22 07:31:57 +0000 (Tue, 22 Nov 2016)
New Revision: 30284
Trac url: http://develop.twiki.org/trac/changeset/30284

Modified:
   twiki/trunk/core/data/TWiki/TWikiScripts.txt
Log:
Item7700: minor document improvement

Modified: twiki/trunk/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:11:13 UTC (rev 30283)
+++ twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:31:57 UTC (rev 30284)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1479797825" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479799846" format="1.1" version="$Rev$"}%
 %STARTINCLUDE%
 ---+ TWiki CGI and Command Line Scripts
 
@@ -59,7 +59,7 @@
 For the =save= script, special variables are available as below:
 
 | *Parameter* | *Value* |
-| =$web= and =$topic= | The names of the web/topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
+| =$web= and =$topic= | The names of the web/topic of the topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
 | =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
 
 #AttachScript

[TWiki-Dev] [SVN] MahiroAndo r30283 - twiki/branches/TWikiRelease06x00/core/data/TWiki

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 07:11:13 +0000 (Tue, 22 Nov 2016)
New Revision: 30283
Trac url: http://develop.twiki.org/trac/changeset/30283

Modified:
   twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
Log:
Item7761: Add details in doc about $web and $topic for redirectto

Modified: twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:10:19 UTC (rev 30282)
+++ twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:11:13 UTC (rev 30283)
@@ -59,7 +59,7 @@
 For the =save= script, special variables are available as below:
 
 | *Parameter* | *Value* |
-| =$web= and =$topic= | The names of the web/topic that has just been saved. |
+| =$web= and =$topic= | The names of the web/topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
 | =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
 
 #AttachScript

[TWiki-Dev] [SVN] MahiroAndo r30282 - twiki/trunk/core/data/TWiki

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 07:10:19 +0000 (Tue, 22 Nov 2016)
New Revision: 30282
Trac url: http://develop.twiki.org/trac/changeset/30282

Modified:
   twiki/trunk/core/data/TWiki/TWikiScripts.txt
Log:
Item7761: Add details in doc about $web and $topic for redirectto

Modified: twiki/trunk/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:01:00 UTC (rev 30281)
+++ twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:10:19 UTC (rev 30282)
@@ -59,7 +59,7 @@
 For the =save= script, special variables are available as below:
 
 | *Parameter* | *Value* |
-| =$web= and =$topic= | The names of the web/topic that has just been saved. |
+| =$web= and =$topic= | The names of the web/topic that has just been saved. It is useful when the =redirectto= parameter is passed around over multiple redirections or form submissions, where the topic name is dynamically determined (e.g. using AUTOINC, custom topic creation form, and !JavaScript) |
 | =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
 
 #AttachScript

[TWiki-Dev] [SVN] MahiroAndo r30281 - twiki/branches/TWikiRelease06x00/core/data/TWiki

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 07:01:00 +0000 (Tue, 22 Nov 2016)
New Revision: 30281
Trac url: http://develop.twiki.org/trac/changeset/30281

Modified:
   twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
Log:
Item7761: Updating TWikiScripts document about redirectto

Modified: twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 06:59:17 UTC (rev 30280)
+++ twiki/branches/TWikiRelease06x00/core/data/TWiki/TWikiScripts.txt	2016-11-22 07:01:00 UTC (rev 30281)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1470820158" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479797825" format="1.1" version="$Rev$"}%
 %STARTINCLUDE%
 ---+ TWiki CGI and Command Line Scripts
 
@@ -53,9 +53,15 @@
 The parameter value can either be a =TopicName=, a =Web.TopicName= (optionally with parameters e.g. =FooBar?param1=value1=), or a URL.
 Please note that redirect to a URL only works if it is enabled in =configure= (Security setup > Miscellaneous ={AllowRedirectUrl}=).
 
-If the parameter value contains a =${field}= or =$field=, it's replaced with the value of the specified field of the page.
+If the parameter value contains a =${field}= or =$field=, it's replaced with the value of the specified field of the page (URL-encoded).
 To know what fields are there on the page, please look into the HTML of the page.
 
+For the =save= script, special variables are available as below:
+
+| *Parameter* | *Value* |
+| =$web= and =$topic= | The names of the web/topic that has just been saved. |
+| =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
+
 #AttachScript
 ---+++ =attach=
 

[TWiki-Dev] [SVN] MahiroAndo r30280 - twiki/branches/TWikiRelease06x00/core/lib

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 06:59:17 +0000 (Tue, 22 Nov 2016)
New Revision: 30280
Trac url: http://develop.twiki.org/trac/changeset/30280

Modified:
   twiki/branches/TWikiRelease06x00/core/lib/TWiki.pm
Log:
Item7761: Set $web and $topic in redirectto from session variable

Modified: twiki/branches/TWikiRelease06x00/core/lib/TWiki.pm
===================================================================
--- twiki/branches/TWikiRelease06x00/core/lib/TWiki.pm	2016-11-22 06:57:19 UTC (rev 30279)
+++ twiki/branches/TWikiRelease06x00/core/lib/TWiki.pm	2016-11-22 06:59:17 UTC (rev 30280)
@@ -866,7 +866,13 @@
     if ( $redirecturl =~ /AUTOINC/ && defined $session->{AUTOINC} ) {
         $redirecturl =~ s//$session->{AUTOINC}/g;
     }
-    $redirecturl =~ s/\$\{([^{}]*)\}|\$(\w+)/urlEncode($query->param($1 || $2)) || ''/eg;
+    my $sessionParam = {
+        web   => $session->{webName},
+        topic => $session->{topicName},
+    };
+    $redirecturl =~ s/\$\{([^{}]*)\}|\$(\w+)/
+        my $v = ($1 || $2);
+        urlEncode($query->param($v) || $sessionParam->{$v} || '')/eg;
     if( $redirecturl =~ m#^$regex{linkProtocolPattern}://#o ) {
         # assuming URL
         if (isRedirectSafe($redirecturl)) {

[TWiki-Dev] [SVN] MahiroAndo r30279 - twiki/trunk/core/data/TWiki

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 06:57:19 +0000 (Tue, 22 Nov 2016)
New Revision: 30279
Trac url: http://develop.twiki.org/trac/changeset/30279

Modified:
   twiki/trunk/core/data/TWiki/TWikiScripts.txt
Log:
Item7761: Updating TWikiScripts document about redirectto

Modified: twiki/trunk/core/data/TWiki/TWikiScripts.txt
===================================================================
--- twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 06:47:12 UTC (rev 30278)
+++ twiki/trunk/core/data/TWiki/TWikiScripts.txt	2016-11-22 06:57:19 UTC (rev 30279)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1470820158" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479797825" format="1.1" version="$Rev$"}%
 %STARTINCLUDE%
 ---+ TWiki CGI and Command Line Scripts
 
@@ -53,9 +53,15 @@
 The parameter value can either be a =TopicName=, a =Web.TopicName= (optionally with parameters e.g. =FooBar?param1=value1=), or a URL.
 Please note that redirect to a URL only works if it is enabled in =configure= (Security setup > Miscellaneous ={AllowRedirectUrl}=).
 
-If the parameter value contains a =${field}= or =$field=, it's replaced with the value of the specified field of the page.
+If the parameter value contains a =${field}= or =$field=, it's replaced with the value of the specified field of the page (URL-encoded).
 To know what fields are there on the page, please look into the HTML of the page.
 
+For the =save= script, special variables are available as below:
+
+| *Parameter* | *Value* |
+| =$web= and =$topic= | The names of the web/topic that has just been saved. |
+| =$dontnotify= | When "Quiet Save" is used, this value is set to "checked". |
+
 #AttachScript
 ---+++ =attach=
 

[TWiki-Dev] [SVN] PeterThoeny r30278 - twiki/branches/TWikiRelease06x00/core/lib

[<de...@de...>]

Author: PeterThoeny
Date: 2016-11-22 06:47:12 +0000 (Tue, 22 Nov 2016)
New Revision: 30278
Trac url: http://develop.twiki.org/trac/changeset/30278

Modified:
   twiki/branches/TWikiRelease06x00/core/lib/TWiki.spec
Log:
Item7762: Anti-spam e-mail padding only for unauthenticated guests - updating configure spec

Modified: twiki/branches/TWikiRelease06x00/core/lib/TWiki.spec
===================================================================
--- twiki/branches/TWikiRelease06x00/core/lib/TWiki.spec	2016-11-22 06:46:56 UTC (rev 30277)
+++ twiki/branches/TWikiRelease06x00/core/lib/TWiki.spec	2016-11-22 06:47:12 UTC (rev 30278)
@@ -695,6 +695,11 @@
 # rendered as fr...@us...
 $TWiki::cfg{AntiSpam}{EmailPadding} = '';
 
+# **STRING 50**
+# Same as <tt>{AntiSpam}{EmailPadding}</tt>, except that the spam
+# padding is only done for non-authenticated users.
+$TWiki::cfg{AntiSpam}{EmailGuestPadding} = '';
+
 # **BOOLEAN**
 # Normally TWiki stores the user's sensitive information (such as their e-mail
 # address) in a database out of public view. It also obfuscates e-mail

[TWiki-Dev] [SVN] PeterThoeny r30277 - twiki/branches/TWikiRelease06x00/core/lib/TWiki

[<de...@de...>]

Author: PeterThoeny
Date: 2016-11-22 06:46:56 +0000 (Tue, 22 Nov 2016)
New Revision: 30277
Trac url: http://develop.twiki.org/trac/changeset/30277

Modified:
   twiki/branches/TWikiRelease06x00/core/lib/TWiki/Render.pm
Log:
Item7762: Anti-spam e-mail padding only for unauthenticated guests

Modified: twiki/branches/TWikiRelease06x00/core/lib/TWiki/Render.pm
===================================================================
--- twiki/branches/TWikiRelease06x00/core/lib/TWiki/Render.pm	2016-11-22 06:46:38 UTC (rev 30276)
+++ twiki/branches/TWikiRelease06x00/core/lib/TWiki/Render.pm	2016-11-22 06:46:56 UTC (rev 30277)
@@ -1024,7 +1024,13 @@
     my $opt = '';
     my $icn = '';
     if( $url =~ /^mailto:/i ) {
-        if( $TWiki::cfg{AntiSpam}{EmailPadding} ) {
+        my $twiki = $this->{session};
+        if( $TWiki::cfg{AntiSpam}{EmailGuestPadding} && !$twiki->inContext( 'authenticated' ) ) {
+            $url =~  s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailGuestPadding}$2/;
+            if ($text) {
+                $text =~ s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailGuestPadding}$2/;
+            }
+        } elsif( $TWiki::cfg{AntiSpam}{EmailPadding} ) {
             $url =~  s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailPadding}$2/;
             if ($text) {
                 $text =~ s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailPadding}$2/;

[TWiki-Dev] [SVN] PeterThoeny r30276 - twiki/trunk/core/lib

[<de...@de...>]

Author: PeterThoeny
Date: 2016-11-22 06:46:38 +0000 (Tue, 22 Nov 2016)
New Revision: 30276
Trac url: http://develop.twiki.org/trac/changeset/30276

Modified:
   twiki/trunk/core/lib/TWiki.spec
Log:
Item7762: Anti-spam e-mail padding only for unauthenticated guests - upating configure spec

Modified: twiki/trunk/core/lib/TWiki.spec
===================================================================
--- twiki/trunk/core/lib/TWiki.spec	2016-11-22 06:46:21 UTC (rev 30275)
+++ twiki/trunk/core/lib/TWiki.spec	2016-11-22 06:46:38 UTC (rev 30276)
@@ -695,6 +695,11 @@
 # rendered as fr...@us...
 $TWiki::cfg{AntiSpam}{EmailPadding} = '';
 
+# **STRING 50**
+# Same as <tt>{AntiSpam}{EmailPadding}</tt>, except that the spam
+# padding is only done for non-authenticated users.
+$TWiki::cfg{AntiSpam}{EmailGuestPadding} = '';
+
 # **BOOLEAN**
 # Normally TWiki stores the user's sensitive information (such as their e-mail
 # address) in a database out of public view. It also obfuscates e-mail

[TWiki-Dev] [SVN] PeterThoeny r30275 - twiki/trunk/core/lib/TWiki

[<de...@de...>]

Author: PeterThoeny
Date: 2016-11-22 06:46:21 +0000 (Tue, 22 Nov 2016)
New Revision: 30275
Trac url: http://develop.twiki.org/trac/changeset/30275

Modified:
   twiki/trunk/core/lib/TWiki/Render.pm
Log:
Item7762: Anti-spam e-mail padding only for unauthenticated guests

Modified: twiki/trunk/core/lib/TWiki/Render.pm
===================================================================
--- twiki/trunk/core/lib/TWiki/Render.pm	2016-11-22 05:05:09 UTC (rev 30274)
+++ twiki/trunk/core/lib/TWiki/Render.pm	2016-11-22 06:46:21 UTC (rev 30275)
@@ -1024,7 +1024,13 @@
     my $opt = '';
     my $icn = '';
     if( $url =~ /^mailto:/i ) {
-        if( $TWiki::cfg{AntiSpam}{EmailPadding} ) {
+        my $twiki = $this->{session};
+        if( $TWiki::cfg{AntiSpam}{EmailGuestPadding} && !$twiki->inContext( 'authenticated' ) ) {
+            $url =~  s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailGuestPadding}$2/;
+            if ($text) {
+                $text =~ s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailGuestPadding}$2/;
+            }
+        } elsif( $TWiki::cfg{AntiSpam}{EmailPadding} ) {
             $url =~  s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailPadding}$2/;
             if ($text) {
                 $text =~ s/(\@[\w\_\-\+]+)(\.)/$1$TWiki::cfg{AntiSpam}{EmailPadding}$2/;

[TWiki-Dev] [SVN] MahiroAndo r30274 - twiki/trunk/core/lib

[<de...@de...>]

Author: MahiroAndo
Date: 2016-11-22 05:05:09 +0000 (Tue, 22 Nov 2016)
New Revision: 30274
Trac url: http://develop.twiki.org/trac/changeset/30274

Modified:
   twiki/trunk/core/lib/TWiki.pm
Log:
Item7761: Set $web and $topic in redirectto from session variable

Modified: twiki/trunk/core/lib/TWiki.pm
===================================================================
--- twiki/trunk/core/lib/TWiki.pm	2016-11-21 08:31:47 UTC (rev 30273)
+++ twiki/trunk/core/lib/TWiki.pm	2016-11-22 05:05:09 UTC (rev 30274)
@@ -868,7 +868,13 @@
     if ( $redirecturl =~ /AUTOINC/ && defined $session->{AUTOINC} ) {
         $redirecturl =~ s//$session->{AUTOINC}/g;
     }
-    $redirecturl =~ s/\$\{([^{}]*)\}|\$(\w+)/urlEncode($query->param($1 || $2)) || ''/eg;
+    my $sessionParam = {
+        web   => $session->{webName},
+        topic => $session->{topicName},
+    };
+    $redirecturl =~ s/\$\{([^{}]*)\}|\$(\w+)/
+        my $v = ($1 || $2);
+        urlEncode($query->param($v) || $sessionParam->{$v} || '')/eg;
     if( $redirecturl =~ m#^$regex{linkProtocolPattern}://#o ) {
         # assuming URL
         if (isRedirectSafe($redirecturl)) {

[TWiki-Dev] [SVN] HideyoImazu r30273 - twiki/branches/TWikiRelease06x00/core/lib/TWiki/Store

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-21 08:31:47 +0000 (Mon, 21 Nov 2016)
New Revision: 30273
Trac url: http://develop.twiki.org/trac/changeset/30273

Modified:
   twiki/branches/TWikiRelease06x00/core/lib/TWiki/Store/RcsFile.pm
Log:
Item7760: saveFile function to be atomic -- writing completely or not writing at all

Modified: twiki/branches/TWikiRelease06x00/core/lib/TWiki/Store/RcsFile.pm
===================================================================
--- twiki/branches/TWikiRelease06x00/core/lib/TWiki/Store/RcsFile.pm	2016-11-21 08:29:48 UTC (rev 30272)
+++ twiki/branches/TWikiRelease06x00/core/lib/TWiki/Store/RcsFile.pm	2016-11-21 08:31:47 UTC (rev 30273)
@@ -909,13 +909,20 @@
     mkPathTo( $name );
 
     my $FILE;
-    open($FILE, '>', $name ) ||
-      throw Error::Simple( 'RCS: failed to create file '.$name.': '.$! );
+    my $tmpName = $name . '.' . $$; # Item7760
+    open($FILE, '>', $tmpName ) ||
+      throw Error::Simple( 'RCS: failed to create file '.$tmpName.': '.$! );
     binmode($FILE ) ||
-      throw Error::Simple( 'RCS: failed to binmode '.$name.': '.$! );
+      throw Error::Simple( 'RCS: failed to binmode '.$tmpName.': '.$! );
     print $FILE $text;
     close($FILE) ||
-      throw Error::Simple( 'RCS: failed to create file '.$name.': '.$! );
+      throw Error::Simple( 'RCS: failed to create file '.$tmpName.': '.$! );
+    rename($tmpName, $name) or do { # Item7760
+        my $nameNoDir = $name;
+        $nameNoDir =~ s:^.*/::;
+        throw Error::Simple( 'RCS: failed to rename file '.$tmpName.
+            ' to '.$nameNoDir.': '.$! );
+    };
     return;
 }
 

[TWiki-Dev] [SVN] HideyoImazu r30272 - twiki/trunk/core/lib/TWiki/Store

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-21 08:29:48 +0000 (Mon, 21 Nov 2016)
New Revision: 30272
Trac url: http://develop.twiki.org/trac/changeset/30272

Modified:
   twiki/trunk/core/lib/TWiki/Store/RcsFile.pm
Log:
Item7760: saveFile function to be atomic -- writing completely or not writing at all

Modified: twiki/trunk/core/lib/TWiki/Store/RcsFile.pm
===================================================================
--- twiki/trunk/core/lib/TWiki/Store/RcsFile.pm	2016-11-14 06:59:46 UTC (rev 30271)
+++ twiki/trunk/core/lib/TWiki/Store/RcsFile.pm	2016-11-21 08:29:48 UTC (rev 30272)
@@ -909,13 +909,20 @@
     mkPathTo( $name );
 
     my $FILE;
-    open($FILE, '>', $name ) ||
-      throw Error::Simple( 'RCS: failed to create file '.$name.': '.$! );
+    my $tmpName = $name . '.' . $$; # Item7760
+    open($FILE, '>', $tmpName ) ||
+      throw Error::Simple( 'RCS: failed to create file '.$tmpName.': '.$! );
     binmode($FILE ) ||
-      throw Error::Simple( 'RCS: failed to binmode '.$name.': '.$! );
+      throw Error::Simple( 'RCS: failed to binmode '.$tmpName.': '.$! );
     print $FILE $text;
     close($FILE) ||
-      throw Error::Simple( 'RCS: failed to create file '.$name.': '.$! );
+      throw Error::Simple( 'RCS: failed to create file '.$tmpName.': '.$! );
+    rename($tmpName, $name) or do { # Item7760
+        my $nameNoDir = $name;
+        $nameNoDir =~ s:^.*/::;
+        throw Error::Simple( 'RCS: failed to rename file '.$tmpName.
+            ' to '.$nameNoDir.': '.$! );
+    };
     return;
 }
 

[TWiki-Dev] TWiki Kampala Release Meeting, 2016-11-17, 23:00 GMT

[Peter T. <pe...@th...>]

All:

Please join the TWiki Kampala Release Meeting, http://twiki.org/cgi-bin/view/Codev/KampalaReleaseMeeting2016x11x17 scheduled for 2016-11-17 22:00 GMT [1] on IRC channel #twiki_release on the irc.freenode.net IRC network [2] - in about 18 hours from now.

ATTENTION: +1h GMT change due to daylight savings time change in the USA!

Proposed agenda:

 1. Feature Requests for Kampala Release
 2. Review Urgent and Not So Urgent Bugs
 3. Extensions
 4. Miscellaneous

The meeting is on Thursday or Friday, depending on your time zone. Meeting time in different time zones, tomorrow:

 * USA Pacific Time Zone: 03:00pm on Thu
 * USA Eastern Time Zone: 06:00pm on Thu
 * Central Europe: 24:00 on Thu/Fri night
 * Japan: 08:00 on Fri (ATTENTION: +1h shift due to daylight saving difference USA & Japan)

Please show up in time to save everybody's time. And remember that the release meeting is where decisions are made. We invite all TWiki.org contributors to join, as well as people with interest in the TWiki project in general.

Cheers,
Peter


[1]: http://www.timeanddate.com/worldclock/converter.html?iso=20161117T230000&p1=tz_gmt&p2=248&p3=268&p4=224&p5=179
[2]: http://twiki.org/cgi-bin/view/Codev/TWikiIRC


--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography
> Knowledge cannot be managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public

[TWiki-Dev] [SVN] HideyoImazu r30271 - in twiki/branches/TWikiRelease06x00/EditTablePlugin: data/TWiki lib/TWiki/Plugins/EditTablePlugin

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-14 06:59:46 +0000 (Mon, 14 Nov 2016)
New Revision: 30271
Trac url: http://develop.twiki.org/trac/changeset/30271

Modified:
   twiki/branches/TWikiRelease06x00/EditTablePlugin/data/TWiki/EditTablePlugin.txt
   twiki/branches/TWikiRelease06x00/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm
Log:
Item7759: EditTablePlugin uses viewauth unnecessarily, brings down TWiki if headerrows and footerrows are inappropriate

Modified: twiki/branches/TWikiRelease06x00/EditTablePlugin/data/TWiki/EditTablePlugin.txt
===================================================================
--- twiki/branches/TWikiRelease06x00/EditTablePlugin/data/TWiki/EditTablePlugin.txt	2016-11-14 06:58:00 UTC (rev 30270)
+++ twiki/branches/TWikiRelease06x00/EditTablePlugin/data/TWiki/EditTablePlugin.txt	2016-11-14 06:59:46 UTC (rev 30271)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1452381551" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479106169" format="1.1" version="$Rev$"}%
 ---+!! Edit Table Plugin
 <!--
    Contributions to this TWiki plugin are appreciated. Please update the plugin page at
@@ -245,6 +245,7 @@
  hidelink="Hide Change History %ICONURL{toggleclose}% "
 }%
 %TABLE{ tablewidth="100%" columnwidths="170," }%
+|  2016-11-14: | TWikibug:Item7759: using viewauth unnecessarily, bringing down TWiki if headerrows and footerrows are inapprropriate -- TWiki:HideyoImazu |
 |  2016-01-08: | TWikibug:Item7708: Copyright update to 2016 |
 |  2015-01-10: | TWikibug:Item7604: Switch to GPL v3 |
 |  2013-12-03: | TWikibug:Item7394: EditTablePlugin is not showing space characters correctly in date fields. -- TWiki:Main.YaojunFei |

Modified: twiki/branches/TWikiRelease06x00/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm
===================================================================
--- twiki/branches/TWikiRelease06x00/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm	2016-11-14 06:58:00 UTC (rev 30270)
+++ twiki/branches/TWikiRelease06x00/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm	2016-11-14 06:59:46 UTC (rev 30271)
@@ -469,7 +469,7 @@
             my @footerRows = ();
             @bodyRows = @rows;    #clone
 
-            if ( $headerRowCount > 0 ) {
+            if ( $headerRowCount > 0 && $headerRowCount <= @bodyRows ) {
                 @headerRows = @rows;    # clone
                 splice @headerRows, $headerRowCount;
 
@@ -477,14 +477,12 @@
                 splice @bodyRows, 0, $headerRowCount;
             }
 
-            if ( $footerRowCount > 0 ) {
+            if ( $footerRowCount > 0 && $footerRowCount <= @bodyRows ) {
                 @footerRows = @rows;    # clone
-                splice @footerRows, 0, ( scalar @footerRows - $footerRowCount );
+                splice @footerRows, 0, - $footerRowCount;
 
                 # remove the footer rows from the body rows
-                splice @bodyRows,
-                  ( scalar @bodyRows - $footerRowCount ),
-                  $footerRowCount;
+                splice @bodyRows, - $footerRowCount;
             }
 
             # delete rows?
@@ -787,7 +785,9 @@
         $doEdit, $headerRowCount, $footerRowCount )
       = @_;
 
-    my $viewUrl = TWiki::Func::getScriptUrl( $theWeb, $theTopic, 'viewauth' )
+    my $ctx = TWiki::Func::getContext();
+    my $viewUrl = TWiki::Func::getScriptUrl( $theWeb, $theTopic,
+                      ($ctx->{authenticated} ? 'view' : 'viewauth') )
       . "\#${theTopic}edittable$theTableNr";
     my $text = '';
     if ($doEdit) {
@@ -1499,8 +1499,11 @@
             if ( $lockUser ne $loginUser ) {
 
                 # change the default oopsleaseconflict url
-                # use viewauth instead of view
-                $oopsUrl =~ s/param4=view/param4=viewauth/;
+                # use viewauth instead of view if necessary
+                my $ctx = TWiki::Func::getContext();
+                unless ( $ctx->{authenticated} ) {
+                    $oopsUrl =~ s/param4=view/param4=viewauth/;
+                }
 
                 # add info of the edited table
                 my $params = '';

[TWiki-Dev] [SVN] HideyoImazu r30270 - in twiki/trunk/EditTablePlugin: data/TWiki lib/TWiki/Plugins/EditTablePlugin

[<de...@de...>]

Author: HideyoImazu
Date: 2016-11-14 06:58:00 +0000 (Mon, 14 Nov 2016)
New Revision: 30270
Trac url: http://develop.twiki.org/trac/changeset/30270

Modified:
   twiki/trunk/EditTablePlugin/data/TWiki/EditTablePlugin.txt
   twiki/trunk/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm
Log:
Item7759: EditTablePlugin uses viewauth unnecessarily, brings down TWiki if headerrows and footerrows are inappropriate

Modified: twiki/trunk/EditTablePlugin/data/TWiki/EditTablePlugin.txt
===================================================================
--- twiki/trunk/EditTablePlugin/data/TWiki/EditTablePlugin.txt	2016-10-25 10:48:37 UTC (rev 30269)
+++ twiki/trunk/EditTablePlugin/data/TWiki/EditTablePlugin.txt	2016-11-14 06:58:00 UTC (rev 30270)
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="TWikiContributor" date="1452381551" format="1.1" version="$Rev$"}%
+%META:TOPICINFO{author="TWikiContributor" date="1479106169" format="1.1" version="$Rev$"}%
 ---+!! Edit Table Plugin
 <!--
    Contributions to this TWiki plugin are appreciated. Please update the plugin page at
@@ -245,6 +245,7 @@
  hidelink="Hide Change History %ICONURL{toggleclose}% "
 }%
 %TABLE{ tablewidth="100%" columnwidths="170," }%
+|  2016-11-14: | TWikibug:Item7759: using viewauth unnecessarily, bringing down TWiki if headerrows and footerrows are inapprropriate -- TWiki:HideyoImazu |
 |  2016-01-08: | TWikibug:Item7708: Copyright update to 2016 |
 |  2015-01-10: | TWikibug:Item7604: Switch to GPL v3 |
 |  2013-12-03: | TWikibug:Item7394: EditTablePlugin is not showing space characters correctly in date fields. -- TWiki:Main.YaojunFei |

Modified: twiki/trunk/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm
===================================================================
--- twiki/trunk/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm	2016-10-25 10:48:37 UTC (rev 30269)
+++ twiki/trunk/EditTablePlugin/lib/TWiki/Plugins/EditTablePlugin/Core.pm	2016-11-14 06:58:00 UTC (rev 30270)
@@ -469,7 +469,7 @@
             my @footerRows = ();
             @bodyRows = @rows;    #clone
 
-            if ( $headerRowCount > 0 ) {
+            if ( $headerRowCount > 0 && $headerRowCount <= @bodyRows ) {
                 @headerRows = @rows;    # clone
                 splice @headerRows, $headerRowCount;
 
@@ -477,14 +477,12 @@
                 splice @bodyRows, 0, $headerRowCount;
             }
 
-            if ( $footerRowCount > 0 ) {
+            if ( $footerRowCount > 0 && $footerRowCount <= @bodyRows ) {
                 @footerRows = @rows;    # clone
-                splice @footerRows, 0, ( scalar @footerRows - $footerRowCount );
+                splice @footerRows, 0, - $footerRowCount;
 
                 # remove the footer rows from the body rows
-                splice @bodyRows,
-                  ( scalar @bodyRows - $footerRowCount ),
-                  $footerRowCount;
+                splice @bodyRows, - $footerRowCount;
             }
 
             # delete rows?
@@ -787,7 +785,9 @@
         $doEdit, $headerRowCount, $footerRowCount )
       = @_;
 
-    my $viewUrl = TWiki::Func::getScriptUrl( $theWeb, $theTopic, 'viewauth' )
+    my $ctx = TWiki::Func::getContext();
+    my $viewUrl = TWiki::Func::getScriptUrl( $theWeb, $theTopic,
+                      ($ctx->{authenticated} ? 'view' : 'viewauth') )
       . "\#${theTopic}edittable$theTableNr";
     my $text = '';
     if ($doEdit) {
@@ -1499,8 +1499,11 @@
             if ( $lockUser ne $loginUser ) {
 
                 # change the default oopsleaseconflict url
-                # use viewauth instead of view
-                $oopsUrl =~ s/param4=view/param4=viewauth/;
+                # use viewauth instead of view if necessary
+                my $ctx = TWiki::Func::getContext();
+                unless ( $ctx->{authenticated} ) {
+                    $oopsUrl =~ s/param4=view/param4=viewauth/;
+                }
 
                 # add info of the edited table
                 my $params = '';

[TWiki-Dev] TWiki Kampala Release Meeting, 2016-11-03, 22:00 GMT

[Peter T. <pe...@th...>]

All:

Please join the TWiki Kampala Release Meeting, http://twiki.org/cgi-bin/view/Codev/KampalaReleaseMeeting2016x11x03 scheduled for 2016-11-03 22:00 GMT [1] on IRC channel #twiki_release on the irc.freenode.net IRC network [2] - in about 28 hours from now.

Proposed agenda:

   1. Feature Requests for Kampala Release
   2. Review Urgent and Not So Urgent Bugs
   3. Extensions
   4. Miscellaneous

The meeting is on Thursday or Friday, depending on your time zone. Meeting time in different time zones, tomorrow:

   * USA Pacific Time Zone: 03:00pm on Thu
   * USA Eastern Time Zone: 06:00pm on Thu
   * Central Europe: 23:00 on Thu/Fri night (ATTENTION: -1h shift due to daylight saving difference USA & Europe)
   * Japan: 07:00 on Fri

Please show up in time to save everybody's time. And remember that the release meeting is where decisions are made. We inviteallTWiki.org contributors to join, as well as people with interest in the TWiki project in general.

Cheers,
Peter


[1]: http://www.timeanddate.com/worldclock/converter.html?year=2016&month=11&day=03&hour=22&min=00&sec=0&p1=0&p2=283
[2]: http://twiki.org/cgi-bin/view/Codev/TWikiIRC


--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography
> Knowledge cannot be managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public

[TWiki-Dev] [SVN] MahiroAndo r30269 - in twiki/trunk/AutoSectionsPlugin: data/TWiki lib/TWiki/Plugins

[<de...@de...>]

Author: MahiroAndo
Date: 2016-10-25 10:48:37 +0000 (Tue, 25 Oct 2016)
New Revision: 30269
Trac url: http://develop.twiki.org/trac/changeset/30269

Modified:
   twiki/trunk/AutoSectionsPlugin/data/TWiki/AutoSectionsPlugin.txt
   twiki/trunk/AutoSectionsPlugin/lib/TWiki/Plugins/AutoSectionsPlugin.pm
Log:
Item7258: Update version info

Modified: twiki/trunk/AutoSectionsPlugin/data/TWiki/AutoSectionsPlugin.txt
===================================================================
--- twiki/trunk/AutoSectionsPlugin/data/TWiki/AutoSectionsPlugin.txt	2016-10-25 10:42:37 UTC (rev 30268)
+++ twiki/trunk/AutoSectionsPlugin/data/TWiki/AutoSectionsPlugin.txt	2016-10-25 10:48:37 UTC (rev 30269)
@@ -144,13 +144,14 @@
 |  Plugin Author(s): | TWiki:Main.MahiroAndo |
 |  Copyright: | © 2013-2016 TWiki:Main.MahiroAndo %BR% © 2013-2016 TWiki:TWiki.TWikiContributor |
 |  License: | [[http://www.gnu.org/licenses/gpl.html][GPL (Gnu General Public License)]] |
-|  Plugin Version: | 2016-10-05 |
+|  Plugin Version: | 2016-10-25 |
 %TWISTY{
  mode="div"
  showlink="Show Change History %ICONURL{toggleopen}%"
  hidelink="Hide Change History %ICONURL{toggleclose}% "
 }%
 %TABLE{ tablewidth="100%" columnwidths="170," }%
+|  2016-10-25: | TWikibug:Item7258: Resolve JS error with older IE - TWiki:Main.MahiroAndo |
 |  2016-10-05: | TWikibug:Item7555: During edit mono/proportional font preference fails - TWiki:Main.HideyoImazu |
 |  2016-07-29: | TWikibug:Item7550: Fix triple-click issue with FF; Fix NOTOC detection bug (TWikibug:Item7724); Make plugin aware of READONLYSKINMODE (TWikibug:Item7609); Handle DisplayTimeValues=servertime correctly (TWikibug:Item7739) - TWiki:Main.MahiroAndo |
 |  2016-02-16: | TWikibug:Item7726: eliminate hard-coded /pub/TWiki/ and to add !AutoSections.css to MANIFEST |

Modified: twiki/trunk/AutoSectionsPlugin/lib/TWiki/Plugins/AutoSectionsPlugin.pm
===================================================================
--- twiki/trunk/AutoSectionsPlugin/lib/TWiki/Plugins/AutoSectionsPlugin.pm	2016-10-25 10:42:37 UTC (rev 30268)
+++ twiki/trunk/AutoSectionsPlugin/lib/TWiki/Plugins/AutoSectionsPlugin.pm	2016-10-25 10:48:37 UTC (rev 30269)
@@ -37,7 +37,7 @@
 use POSIX;
 
 our $VERSION = '$Rev$';
-our $RELEASE = '2016-07-29';
+our $RELEASE = '2016-10-25';
 our $SHORTDESCRIPTION = 'Automatically make editable sections based on headings';
 our $NO_PREFS_IN_TOPIC = 1;
 our $debug = 0;

[TWiki-Dev] [SVN] MahiroAndo r30268 - twiki/trunk/AutoSectionsPlugin/pub/TWiki/AutoSectionsPlugin

[<de...@de...>]

Author: MahiroAndo
Date: 2016-10-25 10:42:37 +0000 (Tue, 25 Oct 2016)
New Revision: 30268
Trac url: http://develop.twiki.org/trac/changeset/30268

Modified:
   twiki/trunk/AutoSectionsPlugin/pub/TWiki/AutoSectionsPlugin/AutoSections.js
Log:
Item7258: Resolve JS error with older IE

Modified: twiki/trunk/AutoSectionsPlugin/pub/TWiki/AutoSectionsPlugin/AutoSections.js
===================================================================
--- twiki/trunk/AutoSectionsPlugin/pub/TWiki/AutoSectionsPlugin/AutoSections.js	2016-10-13 20:32:03 UTC (rev 30267)
+++ twiki/trunk/AutoSectionsPlugin/pub/TWiki/AutoSectionsPlugin/AutoSections.js	2016-10-25 10:42:37 UTC (rev 30268)
@@ -24,7 +24,7 @@
             contentNode: null,
             frameNode  : null,
             menuNode   : $prev.get(0),
-            headingNode: headingNode,
+            headingNode: headingNode
           };
         }
       }

[TWiki-Dev] TWiki Kampala Release Meeting, 2016-10-20, 22:00 GMT

[Peter T. <pe...@th...>]

All:

Please join the TWiki Kampala Release Meeting, http://twiki.org/cgi-bin/view/Codev/KampalaReleaseMeeting2016x10x20 scheduled for 2016-10-20 22:00 GMT [1] on IRC channel #twiki_release on the irc.freenode.net IRC network [2] - in about 27.5 hours from now.

Proposed agenda:

   1. Feature Requests for Kampala Release
   2. Review Urgent and Not So Urgent Bugs
   3. Extensions
   4. Miscellaneous

The meeting is on Thursday or Friday, depending on your time zone. Meeting time in different time zones, tomorrow:

   * USA Pacific Time Zone: 03:00pm on Thu
   * USA Eastern Time Zone: 06:00pm on Thu
   * Central Europe: 24:00 on Thu/Fri night
   * Japan: 07:00 on Fri

Please show up in time to save everybody's time. And remember that the release meeting is where decisions are made. We invite allTWiki.org contributors to join, as well as people with interest in the TWiki project in general.

Cheers,
Peter


[1]: http://www.timeanddate.com/worldclock/converter.html?year=2016&month=10&day=20&hour=22&min=00&sec=0&p1=0&p2=283
[2]: http://twiki.org/cgi-bin/view/Codev/TWikiIRC



--
> Peter Thoeny     - Peter09[at]Thoeny.org
> http://bit.ly/MrTWiki - consulting on enterprise collaboration
> http://TWiki.org - is your team already TWiki enabled?
> http://qualityHDR.com - Quality HDR Photography
> Knowledge cannot be managed, it can be discovered and shared
> This e-mail is:   (_) private    (_) ask first    (x) public