[TWiki-Dev] source diffs for some bug fixes.

[stanley <sta...@kt...>]

Peter,

I have some bug fixes since the 01dec2000 release
[well, I actualy downloaded it on Nov 26].

I've attached the diffs as a text file.

bugs fixed in my version:

- rcs errors during save now show up directly
rather than being discarded (at least, problems reported to stderr)
This makes most permission errors more obvious to the end user.

The biggest particular problem I had was it would *appear* to work
due to the working file being written, but in fact no checkin occurred
since the ,v was owned by some user.
Sometimes the 'oopssave.tmpl' file being displayed when save was called
properly and a different kind of error had really happened.

- altered wikistore.pm always does a co -l before trying to
check things in.  This helps avoid permission issues
that can otherwise happen and cause problems.
(for example, if a user explicitly checked in a new version
from their own account, not via the twiki scripts)

- altered oopssave.tmpl since that screen can appear when
save is called properly but an error occurs.

- default view.tmpl has a problem with using wrong variable
so the logo did not appear properly.

Also, I have code for the proposed enhancement
http://TWiki.org/cgi-bin/view/Codev/TocAndReportGeneration
working (at least with Internet Explorer & netscape 6 - Netscape 4 has a
bug)
I'll be refining it slightly in the next couple of days so the outline
documents
are more "wiki-like".

How would you want to handle the enhancement code?

Stanley Knutson
Chief Scientist
Knowledge Technologies International
http://www.ktiworld.com
st...@kt...
415-566-7862  (after 9am pacific time!)