[TWiki-Dev] [SVN] PeterThoeny r23406 - in twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins: . ExternalLinkTrackerPlugin

[<de...@de...>]

Author: PeterThoeny
Date: 2012-09-18 02:40:20 -0500 (Tue, 18 Sep 2012)
New Revision: 23406
Trac url: http://develop.twiki.org/trac/changeset/23406

Modified:
   twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin.pm
   twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin/Core.pm
Log:
Item6935: Configure setting to open up external link in a new window or tab - adding code

Modified: twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin/Core.pm
===================================================================
--- twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin/Core.pm	2012-09-18 07:39:50 UTC (rev 23405)
+++ twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin/Core.pm	2012-09-18 07:40:20 UTC (rev 23406)
@@ -31,6 +31,7 @@
     $this->{Debug}        = $TWiki::cfg{Plugins}{ExternalLinkTrackerPlugin}{Debug} || 0;
     $this->{ExternalIcon} = $TWiki::cfg{Plugins}{ExternalLinkTrackerPlugin}{ExternalIcon} || 0;;
     $this->{ForceAuth}    = $TWiki::cfg{Plugins}{ExternalLinkTrackerPlugin}{ForceAuth} || 0;
+    $this->{NewWindow}    = $TWiki::cfg{Plugins}{ExternalLinkTrackerPlugin}{NewWindow} || 0;
     $this->{AdminGroup}   = $TWiki::cfg{Plugins}{ExternalLinkTrackerPlugin}{AdminGroup} || '';
 
     bless( $this, $class );
@@ -73,17 +74,18 @@
         my $id = lc( $params->{_DEFAULT} );
         if( $this->{Def}{$id} ) {
             # Link to redirect URL
-            $text = '[[%SCRIPTURL{view';              # view script
+            $text = '<a href="%SCRIPTURL{view';              # view script
             $text .= 'auth' if( $this->{ForceAuth} ); # viewauth script
             $text .= '}%/%SYSTEMWEB%/ExternalLinkTrackerPlugin?'
                   . 'exlink_action=redirect;'
                   . "exlink_id=$id;"
                   . "exlink_web=$web;"
-                  . "exlink_topic=$topic"
-                  . ']['
+                  . "exlink_topic=$topic";
+            $text .= '" target="_blank' if( $this->{NewWindow} );
+            $text .= '">'
                   . $this->{Def}{$id}{Name};
             $text .= '%ICON{external}%' if( $this->{ExternalIcon} );
-            $text .= ']]';
+            $text .= '</a>';
             $this->_writeDebug( " Link changed to '$text'" );
 
         } else {

Modified: twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin.pm
===================================================================
--- twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin.pm	2012-09-18 07:39:50 UTC (rev 23405)
+++ twiki/trunk/ExternalLinkTrackerPlugin/lib/TWiki/Plugins/ExternalLinkTrackerPlugin.pm	2012-09-18 07:40:20 UTC (rev 23406)
@@ -27,7 +27,7 @@
 
 #==================================================================
 our $VERSION = '$Rev$';
-our $RELEASE = '2012-09-13';
+our $RELEASE = '2012-09-18';
 our $SHORTDESCRIPTION = 'Track and report on users clicking on external links';
 our $NO_PREFS_IN_TOPIC = 1;