[TWiki-Dev] [SVN] IanKluft r18353 - twiki/trunk/DropDownMenuPlugin/pub/TWiki/DropDownMenuPlugin

[<de...@de...>]

Author: IanKluft
Date: 2010-02-24 04:25:16 -0600 (Wed, 24 Feb 2010)
New Revision: 18353
Trac url: http://develop.twiki.org/trac/changeset/18353

Modified:
   twiki/trunk/DropDownMenuPlugin/pub/TWiki/DropDownMenuPlugin/twiki-dropdownmenu.js
Log:
Item6400: remove potential infinite loop scenario


Modified: twiki/trunk/DropDownMenuPlugin/pub/TWiki/DropDownMenuPlugin/twiki-dropdownmenu.js
===================================================================
--- twiki/trunk/DropDownMenuPlugin/pub/TWiki/DropDownMenuPlugin/twiki-dropdownmenu.js	2010-02-24 09:29:44 UTC (rev 18352)
+++ twiki/trunk/DropDownMenuPlugin/pub/TWiki/DropDownMenuPlugin/twiki-dropdownmenu.js	2010-02-24 10:25:16 UTC (rev 18353)
@@ -84,8 +84,8 @@
 	}
 
 	// find selected items
-	var i=0, sel=document.getElementsByTagName('select');
-	while(i < sel.length)
+	var i, sel=document.getElementsByTagName('select');
+	for ( i=0; i < sel.length; i++ )
 	{
 		// parent node should have the id of one of our menu divs
 		if ( ! sel[i].parentNode.hasAttribute( 'id' )) {
@@ -97,7 +97,7 @@
 		}
 
 		// add an onchange event to redo menu display status when changed
-		sel[i++].onchange=function()
+		sel[i].onchange=function()
 		{
 			// function which reacts to changing an item