[TWiki-Dev] [SVN] MarkusHesse r16829 - in twiki/trunk/SearchEngineKinoSearchAddOn: lib/TWiki/Contrib/SearchEngineKinoSearchAddOn test/unit/SearchEngineKinoSearchAddOn

[<de...@de...>]

Author: MarkusHesse
Date: 2008-05-24 14:36:30 -0500 (Sat, 24 May 2008)
New Revision: 16829
Trac url: http://develop.twiki.org/trac/changeset/16829

Modified:
   twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/Index.pm
   twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/StringifyBase.pm
   twiki/trunk/SearchEngineKinoSearchAddOn/test/unit/SearchEngineKinoSearchAddOn/StringifyBaseTest.pm
Log:
Item5646: Attachments with capital suffix lead to problems

Modified: twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/Index.pm
===================================================================
--- twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/Index.pm	2008-05-23 07:12:54 UTC (rev 16828)
+++ twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/Index.pm	2008-05-24 19:36:30 UTC (rev 16829)
@@ -489,7 +489,7 @@
 
     if ( @attachments ) {
 	$self->log("Attachments available for: $web, $topic");
-	
+
 	foreach my $attachment (@attachments) {
 	    my $name = $attachment->{'name'};
 	    # the attachment extension has to be checked

Modified: twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/StringifyBase.pm
===================================================================
--- twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/StringifyBase.pm	2008-05-23 07:12:54 UTC (rev 16828)
+++ twiki/trunk/SearchEngineKinoSearchAddOn/lib/TWiki/Contrib/SearchEngineKinoSearchAddOn/StringifyBase.pm	2008-05-24 19:36:30 UTC (rev 16829)
@@ -34,6 +34,7 @@
     sub handler_for {
         my ($self, $filename, $mime) = @_;
         if (exists $mime_handlers{$mime}) { return $mime_handlers{$mime} }
+	$filename = lc($filename);
         for my $spec (keys %extension_handlers) {
             if ($filename =~ /$spec$/) { return $extension_handlers{$spec} }
         }

Modified: twiki/trunk/SearchEngineKinoSearchAddOn/test/unit/SearchEngineKinoSearchAddOn/StringifyBaseTest.pm
===================================================================
--- twiki/trunk/SearchEngineKinoSearchAddOn/test/unit/SearchEngineKinoSearchAddOn/StringifyBaseTest.pm	2008-05-23 07:12:54 UTC (rev 16828)
+++ twiki/trunk/SearchEngineKinoSearchAddOn/test/unit/SearchEngineKinoSearchAddOn/StringifyBaseTest.pm	2008-05-24 19:36:30 UTC (rev 16829)
@@ -41,4 +41,20 @@
     $this->assert(! (-f $tmp_dir), "File $tmp_dir not deleteted.");
 }
 
+sub test_handler_for {
+    my $this = shift;
+    my $stringifier = TWiki::Contrib::SearchEngineKinoSearchAddOn::StringifyBase->new();
+
+    my $handler = $stringifier->handler_for("test.pdf", "dummy");
+    $this->assert($handler->isa("TWiki::Contrib::SearchEngineKinoSearchAddOn::StringifyPlugins::PDF"), 
+		  "Bad handler for test.pdf");
+
+    # I check that capital letters in the file name don't confuse the stringifier
+    $handler = $stringifier->handler_for("TEST.PDF", "dummy");
+    $this->assert($handler->isa("TWiki::Contrib::SearchEngineKinoSearchAddOn::StringifyPlugins::PDF"), 
+		  "Bad handler for TEST.PDF");
+
+    print "$handler \n";
+}
+
 1;