[TWiki-Dev] [SVN] CrawfordCurrie r15507 - in twiki/branches/MAIN/twikiplugins/WysiwygPlugin: data/TWiki lib/TWiki/Plugins/WysiwygPlugin/HTML2TML

[<de...@de...>]

Author: CrawfordCurrie
Date: 2007-11-06 12:42:11 -0600 (Tue, 06 Nov 2007)
New Revision: 15507

Modified:
   twiki/branches/MAIN/twikiplugins/WysiwygPlugin/data/TWiki/WysiwygPlugin.txt
   twiki/branches/MAIN/twikiplugins/WysiwygPlugin/lib/TWiki/Plugins/WysiwygPlugin/HTML2TML/Node.pm
Log:
Item4923: fixed blocking of table conversion due to empty attributes

Modified: twiki/branches/MAIN/twikiplugins/WysiwygPlugin/data/TWiki/WysiwygPlugin.txt
===================================================================
--- twiki/branches/MAIN/twikiplugins/WysiwygPlugin/data/TWiki/WysiwygPlugin.txt	2007-11-06 17:58:20 UTC (rev 15506)
+++ twiki/branches/MAIN/twikiplugins/WysiwygPlugin/data/TWiki/WysiwygPlugin.txt	2007-11-06 18:42:11 UTC (rev 15507)
@@ -165,6 +165,7 @@
 |  License | [[http://www.gnu.org/licenses/gpl.html][GPL (Gnu General Public License)]] |
 |  Plugin Version: | %$VERSION% |
 |  Change History: | |
+|  6 Nov 2007 | Bugs:Item4923: fixed blocking of table conversion due to empty attributes |
 |  2 Nov 2007 | Bugs:Item4903: corrected over-enthusiastive interpretation of ! as an escape |
 |  21 Oct 2007 | Bugs:Item4788: fixed unbalanced protect, which could cause loss of protected status Bugs:Item4811: noautolink *looks* like an HTML construct but in fact is not; the tag is infact an "on-off" switch and does not imply any HTML structure, so cannot be converted to a DIV or a span, so has to be removed. Bugs:Item4747: added <sticky> to try to overcome limitations in translation Bugs:Item4831: added increased flexibility in deciding what HTML get converted to TML, and what does not. Analysed all the HTML4 tags to establish initial settings. Bugs:Item4847: don't call non-existent function with older HTML::Parser releases Bugs:Item4844: Saving a table from IE didn't convert it back to TML Bugs:Item4855: table rows generated from TWiki variables were being eaten |
 |  6 Oct 2007 | Bugs:Item4700: fixed colspans Bugs:Item4701: removed extra line between %TABLE and the table Bugs:Item4705: fixed spacing around literal and verbatim blocks Bugs:Item4706: merge adjacent verbatim blocks separated only by whitespace Bugs:Item4712: fixed eating of noautolink and literal Bugs:Item4763: list items spanning multiple lines fixed Bugs:Item4867: released tml2html |

Modified: twiki/branches/MAIN/twikiplugins/WysiwygPlugin/lib/TWiki/Plugins/WysiwygPlugin/HTML2TML/Node.pm
===================================================================
--- twiki/branches/MAIN/twikiplugins/WysiwygPlugin/lib/TWiki/Plugins/WysiwygPlugin/HTML2TML/Node.pm	2007-11-06 17:58:20 UTC (rev 15506)
+++ twiki/branches/MAIN/twikiplugins/WysiwygPlugin/lib/TWiki/Plugins/WysiwygPlugin/HTML2TML/Node.pm	2007-11-06 18:42:11 UTC (rev 15507)
@@ -531,7 +531,8 @@
 
     require TWiki::Plugins::WysiwygPlugin;
     foreach my $attr (keys %{$this->{attrs}}) {
-        return 1 if TWiki::Plugins::WysiwygPlugin::protectedByAttr(
+        next unless length($this->{attrs}->{$attr}); # ignore nulls
+        return $attr if TWiki::Plugins::WysiwygPlugin::protectedByAttr(
             $this->{tag}, $attr);
     }
     return 0;