[TWiki-Dev] [SVN] r4511 - twiki/branches/DEVELOP/bin

[<Sve...@nt...>]

Author: SvenDowideit
Date: 2005-07-03 09:11:09 -0700 (Sun, 03 Jul 2005)
New Revision: 4511

Modified:
   twiki/branches/DEVELOP/bin/configure
Log:
NonRootTWikiInstaller: replaces , with . to make error useful, and added a SMELL - its probably an error really

Modified: twiki/branches/DEVELOP/bin/configure
===================================================================
--- twiki/branches/DEVELOP/bin/configure	2005-07-03 15:57:11 UTC (rev 4510)
+++ twiki/branches/DEVELOP/bin/configure	2005-07-03 16:11:09 UTC (rev 4511)
@@ -535,6 +535,7 @@
     return '';
 }
 
+#SMELL - I think this will unlink your log files if they already exist...
 sub _checkCanCreateFile {
     my $name = shift;
     if (-e $name) {
@@ -543,11 +544,11 @@
     my $txt1 = "test 1 2 3";
     unlink $name if( -e $name );
     open( FILE, ">$name" ) ||
-      return 'Could not create test file ', $name;
+      return 'Could not create test file '. $name;
     print FILE $txt1;
     close( FILE);
     open( IN_FILE, "<$name" ) ||
-      return 'Could not read test file ', $name;
+      return 'Could not read test file '. $name;
     my $txt2 = <IN_FILE>;
     close( IN_FILE );
     unlink $name if( -e $name );