#46 Add pick stroke direction feature

[Kevin_Joly]

Hello,

This hack adds pick stroke direction support (see the pick-stroke-example.png image enclosed).

Since we are working on some technical death metal topics with my guitar instructor, this feature is a must have for me!

How to test this patch

• Put pick_stroke_up.png and pick-stroke_down.png intoTuxGuitar/share/skins/*/. repositories (e.g. every skins repo)
• svn patch add-pick-stroke-feature.patch
• cd build-scripts/tuxguitar-linux-x86_64/
• mvn package
• target/tuxguitar-SNAPSHOT-linux-x86_64/tuxguitar.sh
• open some gpx with pick stroke directions and enjoy

Things to improve

• I had no idea of what I was doing to display it on the tab... Please tell me for any change, I'll be happy to do it. It display OK but I guess I did something wrong.
• I've only tested this feature on Linux-x86_64

Cheers,
Kevin JOLY

[Kevin_Joly]

Forgot to ask: Since I've modified the TGSongWriter/TGSongReader, do you want me to add it in the dev folder under Tuxguitar-compat?

[Kevin_Joly]

Forgot to remove an import I used for debugging. Please use this patch instead of the one in the zip file.

[Helmar Gerloni]

Thanks for the patch! I tested it on the fork https://github.com/helge17/tuxguitar. It worked quite well, but there are a few problems:
- I am currently trying to keep the fork's file format compatible with TuxGuitar 1.5.6. 1.5.6 is not able to open .TG files with the pick strokes.
- The fork shows more details about the bending (commit e982d11). This view clashes with the pick strokes.
- When I open the .GP4/5 files exported from TuxGuitar with Guitar Pro 6, some strokes are missing.
- The Android version is missing the menu items for the new feature.

You can find the updated patch and some details in the attached zip file.

So for now, I wouldn't include your patch in the fork, but I will certainly consider it for future versions!

[Kevin_Joly]

Hello Helmar,

Yes, it definately needs a new file format in order to keep the current format compatibility. It's probably better to wait for a new format. When this time comes, please tell me and I would gladly give you my help to integrate this patch :)

Thanks,
Kevin