Menu

#38 Allow instrument changes to be added to individual beats

Unstable (example)
open
nobody
None
5
2020-07-23
2019-05-31
No

This feature has long been supported in other editors. Patch includes a dialog for editing and a visual indicator above the beat. Also includes support for these in GP3/GP4/GP5 import/export (the guitar pro format calls them "mix table changes"). Anyone who wants to can help by tesing this with some guitar pro files.

The most important change here is the getMostRecentMixerChanges() method in TGSongManager which needs to "look back" every time a note is played to see what the last instrument change was. This is then used in MidiPlayer when playing is started, or when a note is edited.

1 Attachments

Discussion

  • Anonymous

    Anonymous - 2019-06-01

    Attaching a small addendum to previous patch that fixes the indicator on the score not being drawn sometimes, and the knobs in the dialog being in the wrong state sometimes.

     

    Last edit: Anonymous 2019-06-06
  • Anonymous

    Anonymous - 2019-06-01

    Attaching screenshot

     

    Last edit: Anonymous 2019-06-01
  • Anonymous

    Anonymous - 2019-06-18

    Add patch to update TG file reader/writer. Please tweak the version string as necessary.

     
  • Anonymous

    Anonymous - 2019-07-16

    New patch to fix three bugs:
    1. Mixer change flag conflicted with a different flag in the beat header, causing saving/loading not to work sometimes
    2. Mixer changes in the middle of a measure wouldn't apply when clicking in that measure during play
    3. Inserting a rest note before a mixer change beat would erase the mixer change

     
  • Anonymous

    Anonymous - 2020-07-23

    There is a bug with this that is corrupting files, will post a fix soon

     

Log in to post a comment.