#77 Too many repeats in GPX files

[floflooo]

Hi,
I freshly installed Tuxguitar 1.4 from the deb file provided on sourceforge, and I am glad it supports GPX. Thanks for the good work.
However, I noted a problem in GPX playback: when a section is repeated, it seems to always be played by Tuxguitar once more than expected (compared with the Guitar Pro software). I can provide an example file on request (by email).
Best,
Florent

[Helmar Gerloni]

Problem still exists in version 1.5.2. The patch below removes the additional repeat, but maybe this is more a workaroud than a fix.

Tuxguitar and Guitar Pro have different methods to count the repeats: TG asks for the "Number of Repetitions", GP asks how often to play the part ("Play X times").
E.g. to indicate "play that part six times" TG shows "x5" in the score, GP shows "x6".

$ diff -u TuxGuitar-gpx/src/org/herac/tuxguitar/io/gpx/GPXDocumentReader.java.orig TuxGuitar-gpx/src/org/herac/tuxguitar/io/gpx/GPXDocumentReader.java
--- TuxGuitar-gpx/src/org/herac/tuxguitar/io/gpx/GPXDocumentReader.java.orig    2018-01-14 14:03:04.000000000 +0100
+++ TuxGuitar-gpx/src/org/herac/tuxguitar/io/gpx/GPXDocumentReader.java 2019-02-05 20:19:41.549957938 +0100
@@ -228,7 +228,7 @@
                                        if( repeatNode != null ){
                                                masterBar.setRepeatStart(getAttributeBooleanValue(repeatNode, "start"));
                                                if( getAttributeBooleanValue(repeatNode, "end") ){
-                                                       masterBar.setRepeatCount( getAttributeIntegerValue(repeatNode, "count"));
+                                                       masterBar.setRepeatCount( getAttributeIntegerValue(repeatNode, "count") - 1);
                                                }
                                        }

[b4dc0d3r]

https://sourceforge.net/p/tuxguitar-fork/code/160/
https://sourceforge.net/projects/tuxguitar-fork/files/plugins-1.5.2/

(needs the lib file in ..\core-1.5.2)