Menu

#2 FTBFS on clang: scary memcmp error

Unstable_(example)
closed-fixed
nobody
None
5
2015-01-02
2015-01-01
No

Fails to build on Clang due to -Werror catching something scary:

Index: src/turnserver.c
===================================================================
--- src/turnserver.c    (revision 246)
+++ src/turnserver.c    (working copy)
@@ -957,7 +957,7 @@
     struct list_head* n2 = NULL;

     if(tmp->relayed_transport_protocol != IPPROTO_TCP ||
-        memcmp(tmp->key, account->key, sizeof(tmp->key) != 0))
+        memcmp(tmp->key, account->key, sizeof(tmp->key)) != 0)
     {
       continue;
     }

Discussion

  • Sebastien Vincent

    • status: open --> closed-fixed
     
  • Sebastien Vincent

    Thank you. It is fixed in SVN revision 247.

     

Log in to post a comment.