#53 random algorithm sucks

[Philip Lowman]

somehow you don't always get 10 random songs on index.php

[David Ward]

Logged In: YES
user_id=272259

The way that the songs are shown is in two stages. The
first gets a list of 10 songs, the second shows them if they
are (possibly) not hidden.

Replacing random_song_ids() with the following will make
sure that only "active" song ids are fetched in the first place.

function random_song_ids($number) {
$random_song_ids = array();

$query = "select song_id from songs where
{$GLOBALS['show_active']} order by rand() limit $number";
$result = tunez_query($query);

while ($row = mysql_fetch_object($result)) {
$random_song_ids[] = $row->song_id;
}

return $random_song_ids;
}

[David Ward]

Logged In: YES
user_id=272259

I've uploaded a patch (#1094606) with this fix.

[Philip Lowman]

Logged In: YES
user_id=78148

fixed with patch 1094606
http://sourceforge.net/tracker/index.php?func=detail&aid=1094606&group_id=2266&atid=302266