TrouSerS / Bugs / #156 Patch fixing some memory leaks in libtspi

#156 Patch fixing some memory leaks in libtspi

Milestone: Bug

Status: closed-fixed

Owner: Kent Yoder

Labels: TSP Interface Library (74)

Priority: 7

Updated: 2012-08-16

Created: 2012-07-10

Creator: Anonymous

Private: No

Hi,
I found and fixed some memory leaks which are occurring when calling the Tspi_TPM_Quote() and Tspi_TPM_Quote2() functions.
Attached are the patches relative to the trousers-0.3.9 tarball. Looking at the source code I suspect that there are some more leaks of a similar kind around.

Best regards

Andreas

======================================================================
Andreas Steffen andreas.steffen@strongswan.org
strongSwan - the Linux VPN Solution! www.strongswan.org
Institute for Internet Technologies and Applications
University of Applied Sciences Rapperswil
CH-8640 Rapperswil (Switzerland)
===========================================================[ITA-HSR]==

Discussion

Comment has been marked as spam.
Undo

View and moderate all "bugs Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Bugs"

Anonymous - 2012-07-10

Patch fixing some memory leaks in libtspi

Last edit: Anonymous 2013-11-26

Patch fixing some memory leaks in libtspi

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

trousers-0.3.9.patch.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "bugs Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Bugs"
Anonymous - 2012-07-10

priority: 5 --> 7

- **priority**: 5 --> 7

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kent Yoder - 2012-08-13

Hi Andreas, thanks for the patch!

In hunk 3 of this patch, when unloading pcrComp using Trspi_UnloadBlob_PCR_COMPOSITE, if Trspi_UnloadBlob_PCR_SELECTION fails, we'll try to free pcrComp.select.pcrSelect, which hasn't been initialized yet. If you can add a memset to 0 of pcrComp at the top, that would fix this issue.

Also to include this patch I need a Signed-off-by line at the top from you, which shows you agree to to the trousers DCO: http://trousers.sourceforge.net/dco.text

Thanks,
Kent

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kent Yoder - 2012-08-13

assigned_to: phreakz --> kyoder
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "bugs Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Bugs"

Anonymous - 2012-08-16

Updated and signed-off patch fixing some memory leaks in libtspi

Updated and signed-off patch fixing some memory leaks in libtspi

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

trousers-0.3.9a.patch.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "bugs Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Bugs"

Anonymous - 2012-08-16

Hi Kent,

I added the memset to 0 of pcrComp and signed-off and uploaded the updated patch.

Regards

Andreas

Hi Kent, I added the memset to 0 of pcrComp and signed-off and uploaded the updated patch. Regards Andreas

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kent Yoder - 2012-08-16

Thanks Andreas, applied!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kent Yoder - 2012-08-16

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.