Menu

#107 A bug in tspi

Bug
closed
debora
5
2008-04-15
2008-02-27
Anonymous
No

TrouSerS 0.2.9.2
obj_rsakey_get_tcs_handle( )(in file /tspi/Obj_rsakey.c)

original:
if (rsakey->tcsHandle)
*tcsHandle = rsakey->tcsHandle;
else
result = TSPERR(TSS_E_KEY_NOT_LOADED);

obj_list_put(&rsakey_list);

return TSS_SUCCESS;

changed:
if (rsakey->tcsHandle)
*tcsHandle = rsakey->tcsHandle;
else
{ obj_list_put(&rsakey_list);
return TSPERR(TSS_E_KEY_NOT_LOADED);}

obj_list_put(&rsakey_list);

return TSS_SUCCESS;

Discussion

  • debora

    debora - 2008-03-13

    Logged In: YES
    user_id=1367797
    Originator: NO

    I think the following fix would be more consistent with the rest of the code:

    if (rsakey->tcsHandle)
    *tcsHandle = rsakey->tcsHandle;
    else
    result = TSPERR(TSS_E_KEY_NOT_LOADED);

    obj_list_put(&rsakey_list);

    return result;

     
  • debora

    debora - 2008-03-13
    • assigned_to: kyoder --> dvelarde
     
  • debora

    debora - 2008-04-15

    Logged In: YES
    user_id=1367797
    Originator: NO

    Fix committed to CVS

     
  • debora

    debora - 2008-04-15
    • status: open --> closed
     

Log in to post a comment.