[Triplea-develop] Some bug fixes

[Ali I. <aha...@ho...>]

Hi,

I have addressed some of the bugs in #1003736. I cleaned up the 
neutrality violation messages for 4th edition. I also changed the logic 
at the end of battles to reflect the change in 4th edition allowing 
defending planes to land in any adjacent territory if their carrier is 
lost in combat (in 2nd edition planes could only land in an island in 
the sea zone). If there are multiple adjacent territories to the sea 
zone it pops up a dialog asking for the territory to land the plane in. 
I tested my changes as much as possible and they are checked in to CVS.

I will keep working on these game play bugs. Next up is allowing users 
to choose where battleships bombard if at all (my current thinking is 
between the combat move and combat phases to cycle through each 
battleship adjacent to a battle and query the user if it should bombard 
and where), and following that finding a solution for the incorrect 
logic determining whether planes can land when carriers are involved.

One general organization note is that I think it would be a good idea to 
tag the codebase for each release (using cvs tag). This will allow us to 
easily revert to a release version to check out bugs and figure out the 
differences between releases.

By the way does anyone know where the code that loads the last saved 
game and can cause the unsightly exception when TripleA loads? I can't 
only find the code that loads the last game type (classic, 4th edition, 
etc.).

Regards,

Ali Ibrahim